From patchwork Mon Dec 2 09:41:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 180555 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp4961687ile; Mon, 2 Dec 2019 01:42:15 -0800 (PST) X-Google-Smtp-Source: APXvYqxdhoIrC0Szewp+O76jYNdYXhk9gUWbJ77rE9c4D/uq/i4ekAVELW/mZYy1GdiNNhkW3oJq X-Received: by 2002:aa7:d356:: with SMTP id m22mr61125181edr.170.1575279735503; Mon, 02 Dec 2019 01:42:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575279735; cv=none; d=google.com; s=arc-20160816; b=PxRP9YCNGf0IRt18MtDlASt86YOWG3FQIHOqJSiUpSbMLBE9KZmz6KfMnKxhZcktrW 0qebnL2yO9AO+rC6o0V83/Ng6lFzNaU/wS0cS/fWVwI47yH5dHX27Sfpz2p3MZyUH2Oh lsmIS7au9hRfU7GUGIFnTuhBbmOKIwTQbz4NZJx3HW9YrKbVkdvNnDxEfnb+eXFi3qEi +Vu+kybnzncxoAlvKSL9okYc4iHdbwW5rxpk/nOWbNzrCIUzE51ZUVjygH5vBd6+O1zL UX22LiVERGOSrMd3Mlbem1mLuqdPRlnFp4fd84pm9sz6zYPwXQdsucD3zcgi5Y+Kb3AV 5fOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=kaD4X+iA+hefnr2SY426Cp6AZq0PIpD1GzWQcMxIds0=; b=SprkPnV/66We7is6IQV0kS3RpiT+wn00cTssVvk5IIW83u3ur2rClQoES51bXjJSF8 BAKKq2pkVP8T6o+b70f75pmmbkv/jQO7jObww8GVXOOutYz//dxsnxd6kf/0/OuXLdg8 RG5wgylnURHk5+YU+4F3m1lzAq99WXAH1HkQQZ9RbQOAPyGImqACm1KS4Zleq/tthxVw 3pPgVHbPiilvhzBbKb4fSO/kojPMQxFUBWwKH7ew4OErHw8KNzmR4jnNyLpgKz3PliDj 6ZDa8lEX1gAWvhJNrbXlz6bY3QzXvyfkyyeGsmk9xClyN6iUg+52Kzd6PNvSFVLLU4z2 QOcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AX10FchA; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h26si6534896eja.154.2019.12.02.01.42.15; Mon, 02 Dec 2019 01:42:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AX10FchA; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726350AbfLBJmO (ORCPT + 15 others); Mon, 2 Dec 2019 04:42:14 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:35237 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726516AbfLBJmO (ORCPT ); Mon, 2 Dec 2019 04:42:14 -0500 Received: by mail-wm1-f66.google.com with SMTP id u8so6828185wmu.0 for ; Mon, 02 Dec 2019 01:42:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=kaD4X+iA+hefnr2SY426Cp6AZq0PIpD1GzWQcMxIds0=; b=AX10FchAzj258tGdsEXsMQf+oayOn8Rmx/rDannYqYzO/9kuBXeGWesbgaupbxVDti F7R+ztIOU8P+HWp03T8AKFlkcOcGFINVvPgyHZh1g1Bn+FsXlyfcNxmo4Off6677TTBI U38teApdACZtqNPxSu41RzLJNqy3HjF6BEPKvl4mnOFmtEKffV9RAxToDn7p/bFGLLpm J9UuCYR8l+AVtA3ANQ9yCDKtNaZm9RxYcfAbb+tnM+EH0EQagPiLxtRvPy34aHURJtL4 sf1IAUWC2oFjCPIsDNs0gz7A4x8LpwbOXCNvXfRGoqqyzzhZfd7xeuSXhahHlCLgeohw 5pOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kaD4X+iA+hefnr2SY426Cp6AZq0PIpD1GzWQcMxIds0=; b=mUbkGvkTpb7AUFC0f4tPhTtcFIHzWfnh6RWweLPvn2n7UUps/aGBuXF8oWEint9qQr 7At61d3ZMGFQxHlv/BQ4w2ki9imi/1+SKN5uIGLgUVBMP/jisDUYK1a2Ksiw+HYZ5U1q qjPJDSIfS2n0OQQjJx87o0j55jdG82+w9KZ5qAMjlSk6b1PsNoFIIWpS+XfbyuIenPkl +QjvVC1A2g32dFoyaL3b1mPdf2Z4I4/uqGfcwpAtOPCJ8XYNlDBJQ19Rj6lNi4E0seMw fsuIFI2S6sJi2x0sZZZ+LGewq6c0CtUXWYVi0c1t0RBEMQ7slI/bci+AotFiCCOyQwnk Sm9g== X-Gm-Message-State: APjAAAUW+PEqo5c0YPsYHGuY1itrMKTS5icRDqEcq18W/VUT120J438Z cUqyyF+bv+pzUeLO1cbMMSc78lVnwsg= X-Received: by 2002:a1c:ed05:: with SMTP id l5mr28968074wmh.161.1575279732668; Mon, 02 Dec 2019 01:42:12 -0800 (PST) Received: from localhost.localdomain ([2.27.35.155]) by smtp.gmail.com with ESMTPSA id w8sm990381wmm.0.2019.12.02.01.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2019 01:42:12 -0800 (PST) From: Lee Jones To: stable@vger.kernel.org Subject: [PATCH 4.4 4/4] pwm: Clear chip_data in pwm_put() Date: Mon, 2 Dec 2019 09:41:50 +0000 Message-Id: <20191202094150.32485-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191202094150.32485-1-lee.jones@linaro.org> References: <20191202094150.32485-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Uwe Kleine-König [ Upstream commit e926b12c611c2095c7976e2ed31753ad6eb5ff1a ] After a PWM is disposed by its user the per chip data becomes invalid. Clear the data in common code instead of the device drivers to get consistent behaviour. Before this patch only three of nine drivers cleaned up here. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding Signed-off-by: Lee Jones --- drivers/pwm/core.c | 1 + drivers/pwm/pwm-samsung.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) -- 2.24.0 diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 6911f9662300..5e582099ebaa 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -781,6 +781,7 @@ void pwm_put(struct pwm_device *pwm) if (pwm->chip->ops->free) pwm->chip->ops->free(pwm->chip, pwm); + pwm_set_chip_data(pwm, NULL); pwm->label = NULL; module_put(pwm->chip->ops->owner); diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c index ada2d326dc3e..42f270ef2f7b 100644 --- a/drivers/pwm/pwm-samsung.c +++ b/drivers/pwm/pwm-samsung.c @@ -226,7 +226,6 @@ static int pwm_samsung_request(struct pwm_chip *chip, struct pwm_device *pwm) static void pwm_samsung_free(struct pwm_chip *chip, struct pwm_device *pwm) { devm_kfree(chip->dev, pwm_get_chip_data(pwm)); - pwm_set_chip_data(pwm, NULL); } static int pwm_samsung_enable(struct pwm_chip *chip, struct pwm_device *pwm)