From patchwork Mon Dec 2 09:50:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 180559 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp4969111ile; Mon, 2 Dec 2019 01:50:36 -0800 (PST) X-Google-Smtp-Source: APXvYqxO1dJQc1mIiuKxkrHmd2nRZHi1vx1q/prnGIS3LdxAJgUNkoEjH5k1TphPLAaiwB6gFe7G X-Received: by 2002:a50:ea8a:: with SMTP id d10mr60670893edo.97.1575280236186; Mon, 02 Dec 2019 01:50:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575280236; cv=none; d=google.com; s=arc-20160816; b=bkjcRR2a+GLGqZBpaS5azpAF299GA35ioeTruliD05swLrkE1PbhOx7L714mMKnvZs zgO8Gu1ysk26Oit2ANF/VCWg3TiTUo79ricbZYeQbTGt34vl/QsGsVtd9f2giHFjwCTY aAuvLIb0xvhkiONLNu+LfYKUs7luYfHT72AMjf/V5S5O7PUTMUaMcPX2VzcUstnssqu4 EvVlryYflQeF/1ujMomDxCrFg4lGzdtm5jYbnDQ1mCHtP1mjdtHg9J/tDjO6Aiw+MTCa dWv+84jIjRGr0FFQdCB29jOBVSAGcYywhcg3wpn4x7OR1vDHmsWRFTHtxsdrZ0YJCWwi 0rkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=cwSTsKyp+VB/yrtk55Z3QdqURnT8SdzS6bse74wQ6jk=; b=IrcAGLzmdLMg6sQkiyB1/+Oa84U/ethNabimqlBSw+quxL3LJ+KEJWKzgb1Xxzrx4z Z94wZc/V6ReyNFCIYn09V+gIj1ODU/MSeYQBtGbBT4rYoytNJNg5PUIPFhMEoUdab0MV 4PXuS/R3E6PAqy/xxElKAUWEZ8LQvYv6JIZZpvY+2hp2X9DXaz6YY/35iOe/Ckm78+Vb aAybYCKeP8qifRsFZ67HWG21zJ2UO/mDUDWATwBvhvrfnrbqwysUGmxEZ1MdIjxyF1fT AEhvV6MOoNLFjtwIzzfntv2mARueoHPdZRW929rStw+63IXANqToxmbIlREmJ7caVKgV 09sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=L8rGxBrv; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j29si22786482edj.327.2019.12.02.01.50.35; Mon, 02 Dec 2019 01:50:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=L8rGxBrv; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726474AbfLBJuf (ORCPT + 15 others); Mon, 2 Dec 2019 04:50:35 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43621 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726399AbfLBJuf (ORCPT ); Mon, 2 Dec 2019 04:50:35 -0500 Received: by mail-wr1-f68.google.com with SMTP id n1so43370918wra.10 for ; Mon, 02 Dec 2019 01:50:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=cwSTsKyp+VB/yrtk55Z3QdqURnT8SdzS6bse74wQ6jk=; b=L8rGxBrvBN4zhJoD7z3/4BPgF4sx4kYC1FH/wRUev01IT9jPUyxx6WL+MgsE4qOjkR F2SxNeRQtZd9oIoIgr5WfRRjLiLlVVgGN1iNO59Y+/VfDJrnZVft1Mv8m0lofkJMIdLn 679rRZoCSJtIw2fZVWt3HShMKX+PW9xieNwvuapCY/9OyR4b9RDaJ6w6uxXBP7KJyYe8 efI//8FgZrqLE5X3Bdk5Mkf28i/Q1M3GVIi0xAGxgqvF1PbeW960cIm/LtKRmHGtC7vB ZMbqv+A4/LzyahZSYQJ9lmzuIYCd52j1ppa7XFU7fmktnnEY4rGjeqDMyuV/qqf+beFD 9HSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cwSTsKyp+VB/yrtk55Z3QdqURnT8SdzS6bse74wQ6jk=; b=dwP73ILMhTJvD+FyoufHd1INQwAF9CakKQY6bAZEXpnFiPIpjCB1CGtTfBQoimYpqS XqnUiPpn92kyUSWE9wXaKK4Qa8KFPq2lrtY8IcYnKB+zIaNumfqxKsBUjHQiUyDSB7oL +LJv1v1jhfC6mI/SB9lbFFMS9ZAFRg/aFCvLO8uN9pBBj8um323wun02Vgcj9gGr9iwU Nljq5yNplXpBxjnqU2nKwY4Xom0UTbzjpzjXsebrurXzl2GiLDOZG1Mt+N9T7YeKNxGg hxTP6kTIuKBtWfSYY21gYFRd+RirKDx8xOAng9FcaBbqHDFtXf55UY4joxVH77qsF2OQ pehA== X-Gm-Message-State: APjAAAUoAAOQXS7fHjxP5ZQVRfiqS7dSNfM4ncenFo3TKT8yimLMpzZj 5LRfQvSBjAkUueErkKjcycRjQY5jIwY= X-Received: by 2002:adf:ea4e:: with SMTP id j14mr19775324wrn.101.1575280232603; Mon, 02 Dec 2019 01:50:32 -0800 (PST) Received: from localhost.localdomain ([2.27.35.155]) by smtp.gmail.com with ESMTPSA id l3sm4629698wrt.29.2019.12.02.01.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2019 01:50:32 -0800 (PST) From: Lee Jones To: stable@vger.kernel.org Subject: [PATCH 4.9 4/6] net: macb: fix error format in dev_err() Date: Mon, 2 Dec 2019 09:50:10 +0000 Message-Id: <20191202095012.559-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191202095012.559-1-lee.jones@linaro.org> References: <20191202095012.559-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Luca Ceresoli [ Upstream commit f413cbb332a0b5251a790f396d0eb4ebcade5dec ] Errors are negative numbers. Using %u shows them as very large positive numbers such as 4294967277 that don't make sense. Use the %d format instead, and get a much nicer -19. Signed-off-by: Luca Ceresoli Fixes: b48e0bab142f ("net: macb: Migrate to devm clock interface") Fixes: 93b31f48b3ba ("net/macb: unify clock management") Fixes: 421d9df0628b ("net/macb: merge at91_ether driver into macb driver") Fixes: aead88bd0e99 ("net: ethernet: macb: Add support for rx_clk") Fixes: f5473d1d44e4 ("net: macb: Support clock management for tsu_clk") Acked-by: Nicolas Ferre Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Lee Jones --- drivers/net/ethernet/cadence/macb.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.24.0 diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index a0d640243df2..30e93041bf83 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b/drivers/net/ethernet/cadence/macb.c @@ -2364,14 +2364,14 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk, *pclk = devm_clk_get(&pdev->dev, "pclk"); if (IS_ERR(*pclk)) { err = PTR_ERR(*pclk); - dev_err(&pdev->dev, "failed to get macb_clk (%u)\n", err); + dev_err(&pdev->dev, "failed to get macb_clk (%d)\n", err); return err; } *hclk = devm_clk_get(&pdev->dev, "hclk"); if (IS_ERR(*hclk)) { err = PTR_ERR(*hclk); - dev_err(&pdev->dev, "failed to get hclk (%u)\n", err); + dev_err(&pdev->dev, "failed to get hclk (%d)\n", err); return err; } @@ -2385,25 +2385,25 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk, err = clk_prepare_enable(*pclk); if (err) { - dev_err(&pdev->dev, "failed to enable pclk (%u)\n", err); + dev_err(&pdev->dev, "failed to enable pclk (%d)\n", err); return err; } err = clk_prepare_enable(*hclk); if (err) { - dev_err(&pdev->dev, "failed to enable hclk (%u)\n", err); + dev_err(&pdev->dev, "failed to enable hclk (%d)\n", err); goto err_disable_pclk; } err = clk_prepare_enable(*tx_clk); if (err) { - dev_err(&pdev->dev, "failed to enable tx_clk (%u)\n", err); + dev_err(&pdev->dev, "failed to enable tx_clk (%d)\n", err); goto err_disable_hclk; } err = clk_prepare_enable(*rx_clk); if (err) { - dev_err(&pdev->dev, "failed to enable rx_clk (%u)\n", err); + dev_err(&pdev->dev, "failed to enable rx_clk (%d)\n", err); goto err_disable_txclk; } @@ -2823,7 +2823,7 @@ static int at91ether_clk_init(struct platform_device *pdev, struct clk **pclk, err = clk_prepare_enable(*pclk); if (err) { - dev_err(&pdev->dev, "failed to enable pclk (%u)\n", err); + dev_err(&pdev->dev, "failed to enable pclk (%d)\n", err); return err; }