go: Reset unneeded GOARCH variables for native recipe

Message ID 20191202182613.3380457-1-raj.khem@gmail.com
State New
Headers show
Series
  • go: Reset unneeded GOARCH variables for native recipe
Related show

Commit Message

Khem Raj Dec. 2, 2019, 6:26 p.m.
These variables depend on TUNE_FEATURES variable and that creeps into
dependencies for native as well as a result, which means go-native gets
recompiled everytime machine/arch is changed.

Fixes sstate differences found e.g.

basehash changed from 600fb6be571fa4853232a7fed78945ee19b324e54b1b94cff93ef472b6290103 to 994de861190a56064d3e186d9c411152127e230bf2f77b17e59b2c5932a41249
List of dependencies for variable TUNE_FEATURES changed from '{'TUNE_FEATURES_tune-core2-32', 'DEFAULTTUNE'}' to '{'TUNE_FEATURES_tune-armv7vethf-neon', 'DEFAULTTUNE'}'
changed items: {'TUNE_FEATURES_tune-core2-32', 'TUNE_FEATURES_tune-armv7vethf-neon'}

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta/recipes-devtools/go/go-common.inc | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

-- 
2.24.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Richard Purdie Dec. 4, 2019, 12:45 p.m. | #1
On Mon, 2019-12-02 at 10:26 -0800, Khem Raj wrote:
> These variables depend on TUNE_FEATURES variable and that creeps into

> dependencies for native as well as a result, which means go-native

> gets

> recompiled everytime machine/arch is changed.

> 

> Fixes sstate differences found e.g.

> 

> basehash changed from

> 600fb6be571fa4853232a7fed78945ee19b324e54b1b94cff93ef472b6290103 to

> 994de861190a56064d3e186d9c411152127e230bf2f77b17e59b2c5932a41249

> List of dependencies for variable TUNE_FEATURES changed from

> '{'TUNE_FEATURES_tune-core2-32', 'DEFAULTTUNE'}' to

> '{'TUNE_FEATURES_tune-armv7vethf-neon', 'DEFAULTTUNE'}'

> changed items: {'TUNE_FEATURES_tune-core2-32', 'TUNE_FEATURES_tune-

> armv7vethf-neon'}

> 

> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> ---

>  meta/recipes-devtools/go/go-common.inc | 24 ++++++++++++++++++++++++

>  1 file changed, 24 insertions(+)

> 

> diff --git a/meta/recipes-devtools/go/go-common.inc b/meta/recipes-

> devtools/go/go-common.inc

> index f18d928c70..8e4dd137a0 100644

> --- a/meta/recipes-devtools/go/go-common.inc

> +++ b/meta/recipes-devtools/go/go-common.inc

> @@ -37,6 +37,30 @@ export GO386 ?= "${TARGET_GO386}"

>  export GOMIPS ?= "${TARGET_GOMIPS}"

>  export GOROOT_FINAL ?= "${libdir}/go"

> 

> +GOARM[export] = "1"

> +GOARM_class-native = ""

> +GOARM_class-native[export] = "0"


Can we at least do:

GOEXPORTVARS = "1"
GOEXPORTVARS_class-native = "0"

GO386[export] = "${GOEXPORTVARS}"

to clean this up a bit please? :)

Cheers,

Richard

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-devtools/go/go-common.inc b/meta/recipes-devtools/go/go-common.inc
index f18d928c70..8e4dd137a0 100644
--- a/meta/recipes-devtools/go/go-common.inc
+++ b/meta/recipes-devtools/go/go-common.inc
@@ -37,6 +37,30 @@  export GO386 ?= "${TARGET_GO386}"
 export GOMIPS ?= "${TARGET_GOMIPS}"
 export GOROOT_FINAL ?= "${libdir}/go"
 
+GOARM[export] = "1"
+GOARM_class-native = ""
+GOARM_class-native[export] = "0"
+
+GO386[export] = "1"
+GO386_class-native = ""
+GO386_class-native[export] = "0"
+
+GOMIPS[export] = "1"
+GOMIPS_class-native = ""
+GOMIPS_class-native[export] = "0"
+
+HOST_GOARM[export] = "1"
+HOST_GOARM_class-native = ""
+HOST_GOARM_class-native[export] = "0"
+
+HOST_GO386[export] = "1"
+HOST_GO386_class-native = ""
+HOST_GO386_class-native[export] = "0"
+
+HOST_GOMIPS[export] = "1"
+HOST_GOMIPS_class-native = ""
+HOST_GOMIPS_class-native[export] = "0"
+
 do_compile_prepend() {
 	BUILD_CC=${BUILD_CC}
 }