From patchwork Tue Dec 3 02:29:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 180690 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp956160ile; Mon, 2 Dec 2019 18:57:33 -0800 (PST) X-Google-Smtp-Source: APXvYqwjVURlZ3oSPXSC5LUmORNXuFb+mbq5IrE77Kjl4o+XWNCoCysjMQR3QqEoKnJq+Z/eepEZ X-Received: by 2002:a17:906:6043:: with SMTP id p3mr3498578ejj.103.1575341853608; Mon, 02 Dec 2019 18:57:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575341853; cv=none; d=google.com; s=arc-20160816; b=T2/vlq2B0wvybGwbzQppb4DvrGNM+/eJ4B9nFn6m92HtGPK0OyVr1aA9V23MT6NYoY tCMLzOujy+UeQJAkh7gcdI4u4BDcOAGQSxplHRej8czvDJa5OHBrj1BbDCd8NYNGL4t+ Ww6/ps/+W2WvAN+yXiOVJ/OKXIZi76moRywpnB+tuSLBviUGRFyM0YwfCz4TELeL+0TX C6i2zSY9FrixmkqoTP+la3LnKX51DXEQMcGo6bAEb4ZXjOyj0PKG4fNf4ON1eo8DO7Rv UqWwMYFyuEAq7QgAPIJktGLdSw8m5mCdjrfnMv4CBFvqPLZLzHS9s7M0J5fUIUb0zUFU IUZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:references:in-reply-to :message-id:date:subject:to:from:dkim-signature; bh=u63gqALS75nKLyBBgFxH9YCXnhD2J6j4ZQ6v9GcNUx4=; b=dVLJhfms5av5sWFkmMEEGd70iRuL39tM28FT+FsIWmJN1Ax2CrO/mV8gHUdWw0jxL7 Wb2cBg0d1GI8NVkv3PgWkGmny5+EG5UM2lGElXqILAgbKs4YYqqt+s6KUg2zt761l/jB 8zMON7o1gf207//jJyCsTiqEuf4j4p/QBc59tO9W/RzR7EmgO2jPi92/QYPnkKXKywbt pB0f6xyYdJO/y2KfRfblSyB/6T/VD9494tTXyywOWITSNcz0ak4F8Gif87/4/B7UGUjy bUUeXALNtecEzGrQPd79OGs2Ytjok9nV5V8ZFCS1aerSqtallKsbJz+wfg8HDo6xyq8U J3ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="QKRfFCH/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y24si1176344edm.333.2019.12.02.18.57.33 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Dec 2019 18:57:33 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="QKRfFCH/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:47614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibyNX-0003fU-3b for patch@linaro.org; Mon, 02 Dec 2019 21:57:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33788) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibxxP-0003Vp-Si for qemu-devel@nongnu.org; Mon, 02 Dec 2019 21:30:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibxxO-0000RB-E4 for qemu-devel@nongnu.org; Mon, 02 Dec 2019 21:30:31 -0500 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]:36165) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibxxO-0000PL-70 for qemu-devel@nongnu.org; Mon, 02 Dec 2019 21:30:30 -0500 Received: by mail-pj1-x1044.google.com with SMTP id n96so827612pjc.3 for ; Mon, 02 Dec 2019 18:30:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=u63gqALS75nKLyBBgFxH9YCXnhD2J6j4ZQ6v9GcNUx4=; b=QKRfFCH/7LRf3OLHS7U5cg6JJEOvd1qGoiwEkrkNI6YXjyjGHVfKasmnCbzuPF2/Vl I28BdiB53bjLj2f6vDrPQprcP3zOG8V7kuAkKer/ohY8cZQXgy8kj5jNQsdGnvdueiS1 Y9bF7x+j3uPw+meszc9eNR8/rAJZ/5zlCd9UhnyXvesRs/xrgrl4T6A4zfacCrz9Eexa dFhrm7667UgAfyHZOxY/d7cTRvvSwG1itiSs3HfRkzxaICaNTxuRmI7tt8lbwkucMtGR 2cvom6roIPoq4sLv6P+bTa+mdwN2cFRfdTfMvdxCsB9Kd8CbQwkekqYJ0zZgD3Pl8V5l UKEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=u63gqALS75nKLyBBgFxH9YCXnhD2J6j4ZQ6v9GcNUx4=; b=CAQqDWOVCCNcrYxPWbtz0nNWamgpycguqLt6UOsAkyQMTIkiFHujFKcQrTBSFQgwUp ybVQ/Ts6Re94fKCaaIb5SJsavWzDMGkUTTLWCmsMcUtVhoyGqm+CcCtENpKQPntKUAgH tuplujUpQP69n7hI9DV4xakzqd8Or/1Pg/VVedz6t4NdcL4t6C7Re8ksEeyTEroHaglY iRJqCrIAmADTPYctd0so2n/GPi311fJeu1BH9dZPndA41+++xbiaAPjo94ztV/yAW2+h fmYNsyCfyry2uSPFjWuiGRD07OdEJVe9SKMEjCrVxAMuAcFdtL5v5nOUEgjrnSAwJhN1 G9kg== X-Gm-Message-State: APjAAAXAfcPSv6Stvl5ILe4EDLnZTZMWzB99daLcf4Qshb4N+sjb7sWC w9gu3NgmGBLz4WuxgwHIMIA2dcIybvI= X-Received: by 2002:a17:90b:3007:: with SMTP id hg7mr2964339pjb.73.1575340228735; Mon, 02 Dec 2019 18:30:28 -0800 (PST) Received: from localhost.localdomain (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id q22sm873695pfg.170.2019.12.02.18.30.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2019 18:30:28 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 39/40] target/arm: Use bool for unmasked in arm_excp_unmasked Date: Mon, 2 Dec 2019 18:29:36 -0800 Message-Id: <20191203022937.1474-40-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191203022937.1474-1-richard.henderson@linaro.org> References: <20191203022937.1474-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::1044 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The value computed is fully boolean; using int8_t is odd. Signed-off-by: Richard Henderson --- target/arm/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.17.1 Reviewed-by: Philippe Mathieu-Daudé diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 7a1177b883..a366448c6d 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -417,7 +417,7 @@ static inline bool arm_excp_unmasked(CPUState *cs, unsigned int excp_idx, { CPUARMState *env = cs->env_ptr; bool pstate_unmasked; - int8_t unmasked = 0; + bool unmasked = false; /* * Don't take exceptions if they target a lower EL. @@ -468,7 +468,7 @@ static inline bool arm_excp_unmasked(CPUState *cs, unsigned int excp_idx, * don't affect the masking logic, only the interrupt routing. */ if (target_el == 3 || !secure) { - unmasked = 1; + unmasked = true; } } else { /* @@ -514,7 +514,7 @@ static inline bool arm_excp_unmasked(CPUState *cs, unsigned int excp_idx, } if ((scr || hcr) && !secure) { - unmasked = 1; + unmasked = true; } } }