spec: mingw: add deps for genprotocol.pl usage

Message ID 2236b4ca5653b3a5b6cf423f9792745b748a0fbe.1575393110.git.crobinso@redhat.com
State Accepted
Commit d0d728c7c00fd3a62731e50c7bc646df323c0622
Headers show
Series
  • spec: mingw: add deps for genprotocol.pl usage
Related show

Commit Message

Cole Robinson Dec. 3, 2019, 5:11 p.m.
As of 0985a9597bb03 we no longer distribute generated files. mingw
needs to call genprotocol.pl itself, which means it needs rpcgen
and cpp installed.

Signed-off-by: Cole Robinson <crobinso@redhat.com>

---
 mingw-libvirt.spec.in | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Daniel P. Berrangé Dec. 3, 2019, 5:19 p.m. | #1
On Tue, Dec 03, 2019 at 12:11:50PM -0500, Cole Robinson wrote:
> As of 0985a9597bb03 we no longer distribute generated files. mingw
> needs to call genprotocol.pl itself, which means it needs rpcgen
> and cpp installed.
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  mingw-libvirt.spec.in | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel

Patch

diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
index c29f3eeed2..fd9b729591 100644
--- a/mingw-libvirt.spec.in
+++ b/mingw-libvirt.spec.in
@@ -89,6 +89,10 @@  BuildRequires: mingw64-libssh2
 BuildRequires: mingw32-curl
 BuildRequires: mingw64-curl
 %endif
+BuildRequires: cpp
+%if 0%{?fedora} || 0%{?rhel} > 7
+BuildRequires: rpcgen
+%endif
 
 BuildArch:      noarch