From patchwork Tue Dec 3 22:36:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 180761 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp2163429ile; Tue, 3 Dec 2019 14:59:32 -0800 (PST) X-Google-Smtp-Source: APXvYqzWRSaEs/R+j613Vak8OIQD+dXqVlYFZMazSjDJg/VmMbqfeRaAPmVWhGlz7TNcRSc4oNVf X-Received: by 2002:a05:6808:996:: with SMTP id a22mr39495oic.146.1575413971900; Tue, 03 Dec 2019 14:59:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575413971; cv=none; d=google.com; s=arc-20160816; b=Q+QhgD+siC7lZ4/eSseQQ6/GdqBulFbh3qqWx0uYHgyyIxAmIKjfOJo3MVnRwBUTOM iH5N2vKbMn034KMKX5RRctu1Fh9bZX1avyUBdJOV/nEDLO71L0oxj0kDvgy0WTW1xCAc yJT8B7hFEQFgyqqSUx9sKea17Bx/LFOlYsF3m0Jc4uzXxt+JtkGEDlQIfgHJ+DsO2536 5KJAnETMFCypYX5DVoUZUCDBxU4LNkq1oh187us0TvsXDoAXsej+FobfGb5H6TpASdLL pF6bV6505DQbb1tGZOvwskIMECAT5Tbp4qFacwtp4AB5rFgSGqJ5dKCOdzPOyevGHseA dxiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nxk44Ed3cxcn+nr9qLObQkFtmVbofUsX1+oF2VicHdI=; b=ZahavN8d6bHoPf7cMcBVCUVYb62H2PszO7/vYmGUO7+Rupf9wSljHLDnilsP2ftRGP Ze6fVbSdvsrH1/mEyKM+iZ1dquaJ491WPkXk91ifOes9zCNIR0riX4uHwYTLavkZuq8R srSYzca3R/bXNodyoJwWXNKKspgmNHoHkE7Me4Yjqag9oYXo1ISSVy4hcjvn1UWnC4xO BRdt+DglP4YLpyjkpmvbTiYylkI4H1vgrUkWUGjP1/c5lByBFxiR+z6uh2fri+NViQ07 vXl8tPytQs1LOtFy2BJmGhnJyQCh9I5hi7Tiv/MeALU8t1mGl9P09jVPk/4l9FFIh+fn t15w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EV0Ufkmh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p5si2309907oto.116.2019.12.03.14.59.31; Tue, 03 Dec 2019 14:59:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EV0Ufkmh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730427AbfLCW7a (ORCPT + 27 others); Tue, 3 Dec 2019 17:59:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:55938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730463AbfLCW7T (ORCPT ); Tue, 3 Dec 2019 17:59:19 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 450BD2053B; Tue, 3 Dec 2019 22:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413958; bh=Yt7MeVL/h89vHQ3EdAWoNy1Iz3N+bvLPZVujGOMb+sU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EV0UfkmhmcVA+OSXbhMj8+ybDUaMFS2LkN9dmorHdBsm5GZQ/S0sJvfKbJPjpDM6d 6rmv74G8ZxdETPTamQFnzmURrynHv3kEayYBvBmcAarRK29q+621niWK3q1o8HcsIG ee8NiCSO8NJJ+onN1Hj+1GqgrVqHeEHthOf6AqUU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lionel Debieve , Herbert Xu , Mathieu Poirier Subject: [PATCH 4.19 305/321] crypto: stm32/hash - Fix hmac issue more than 256 bytes Date: Tue, 3 Dec 2019 23:36:11 +0100 Message-Id: <20191203223443.014386583@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203223427.103571230@linuxfoundation.org> References: <20191203223427.103571230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lionel Debieve commit 0acabecebc912b3ba06289e4ef40476acc499a37 upstream. Correct condition for the second hmac loop. Key must be only set in the first loop. Initial condition was wrong, HMAC_KEY flag was not properly checked. Signed-off-by: Lionel Debieve Signed-off-by: Herbert Xu Signed-off-by: Mathieu Poirier Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/stm32/stm32-hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/crypto/stm32/stm32-hash.c +++ b/drivers/crypto/stm32/stm32-hash.c @@ -365,7 +365,7 @@ static int stm32_hash_xmit_cpu(struct st return -ETIMEDOUT; if ((hdev->flags & HASH_FLAGS_HMAC) && - (hdev->flags & ~HASH_FLAGS_HMAC_KEY)) { + (!(hdev->flags & HASH_FLAGS_HMAC_KEY))) { hdev->flags |= HASH_FLAGS_HMAC_KEY; stm32_hash_write_key(hdev); if (stm32_hash_wait_busy(hdev))