[1/2] dt-bindings: tcan4x5x: Make wake-gpio an optional gpio

Message ID 20191204175112.7308-1-dmurphy@ti.com
State Accepted
Commit 1202d2318e2f370befe6c154db75ffaad3ec7ba0
Headers show
Series
  • [1/2] dt-bindings: tcan4x5x: Make wake-gpio an optional gpio
Related show

Commit Message

Dan Murphy Dec. 4, 2019, 5:51 p.m.
The wake-up of the device can be configured as an optional
feature of the device.  Move the wake-up gpio from a requried
property to an optional property.

Signed-off-by: Dan Murphy <dmurphy@ti.com>

CC: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/net/can/tcan4x5x.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.23.0

Comments

Sean Nyekjaer Dec. 5, 2019, 7:39 a.m. | #1
On 04/12/2019 18.51, Dan Murphy wrote:
> The device has the ability to disable the wake-up pin option.

> The wake-up pin can be either force to GND or Vsup and does not have to

> be tied to a GPIO.  In order for the device to not use the wake-up feature

> write the register to disable the WAKE_CONFIG option.

> 

> Signed-off-by: Dan Murphy <dmurphy@ti.com>

> CC: Sean Nyekjaer <sean@geanix.com>

Reviewed-by: Sean Nyekjaer <sean@geanix.com>

> ---



Hi Dan,

I would add tcan4x5x to the subject of this patch ->
"net: m_can: tcan4x5x Make wake-up gpio an optional"

Will be testing this during this or the next week...

/Sean

Patch

diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
index 27e1b4cebfbd..7cf5ef7acba4 100644
--- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
+++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
@@ -10,7 +10,6 @@  Required properties:
 	- #size-cells: 0
 	- spi-max-frequency: Maximum frequency of the SPI bus the chip can
 			     operate at should be less than or equal to 18 MHz.
-	- device-wake-gpios: Wake up GPIO to wake up the TCAN device.
 	- interrupt-parent: the phandle to the interrupt controller which provides
                     the interrupt.
 	- interrupts: interrupt specification for data-ready.
@@ -23,6 +22,7 @@  Optional properties:
 		       reset.
 	- device-state-gpios: Input GPIO that indicates if the device is in
 			      a sleep state or if the device is active.
+	- device-wake-gpios: Wake up GPIO to wake up the TCAN device.
 
 Example:
 tcan4x5x: tcan4x5x@0 {