From patchwork Wed Dec 4 17:54:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 180825 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp931350ile; Wed, 4 Dec 2019 10:02:29 -0800 (PST) X-Google-Smtp-Source: APXvYqw73jlYfjUGygCDKQo1qnsBnCiv2rNxWSMNu1ml9aZlGtL6V6xLfkcZ5KQcp9hngSj5OiN3 X-Received: by 2002:aca:503:: with SMTP id 3mr3565109oif.24.1575482549758; Wed, 04 Dec 2019 10:02:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575482549; cv=none; d=google.com; s=arc-20160816; b=wrLmkC2nkR3B8yCZbyYAgRm/cVAtDVEIelCLuN6vrufqu7T+bs9Gc0f0nE1BCAtHtE 6oFVH2rnjI0MEpHD2Q0Zo/ZTwIDf5R0C+UFbT0DdLOYGwVFocqAI8G2ttxU/kMj16GA7 eA9nQ7+F++Lmf225LRCHjvbjdnoYoiCp143tzTFzCBydnXeJEqGBlX+fauFl7ZJ80hWm t78a5K3wOMe/fkLQNPpxUjNSLhupo5UDCVE03rE60Dx/yWc0yWhNSPq7Wrj3rKnYnUvn ESVWbxMiZY/4TERAjHiFPuxKm+zN3k0W1yQbWKK6vCncFr9nYUXHxl+6OHHGBp7OlE0/ ADEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LVrgQHZvT+o7zYOcstxfFuQGkt4Jaj+bjz8pK6/SoCo=; b=fcBtVA7Pr7SnLI4D5eX6mRwcUvps5VMcW+LSYT/h9zI9Ppy6zEhb8wCv7Bmy12vW3Y xrCO1ogX8Luop9v9lWH8eSY4f+uzudMzg0TtSMJtpuik8r0yYpvRSiteBR1tWNAxBFBv DPdPJuKjG2bM9fyykjp+hCLvSOHsamjXM09g8iWDfpw6I9Dd6TSfAjmTEsso9ryeWvOc EA891dyFj47IjMdM93j17Mn6m2nzb2BDECNNOmD6UkZWzHlx6RSds09n33PNkTRE+aZb SYDUlV/twRYu0Hr3A0WDqEP5oMNJX1Uf63RctmZA2b25WoSLsMqwpA2cmktKVlvZRxeT 4zdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WUWtpkdC; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r6si3554919otq.95.2019.12.04.10.02.29; Wed, 04 Dec 2019 10:02:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WUWtpkdC; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728738AbfLDSC1 (ORCPT + 15 others); Wed, 4 Dec 2019 13:02:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:44416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729838AbfLDSC0 (ORCPT ); Wed, 4 Dec 2019 13:02:26 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9A67620659; Wed, 4 Dec 2019 18:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482546; bh=cmKGOHgM7wHlc5kYMfA4o8dgcIF1tniR9eks2UIjlII=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WUWtpkdCWGBRHVp76LG18vcHKm5kMugsxcmgYTsoKFzUkW85jNumL9NTTu+JKXTYb KZ6EKYeAHYmRZKvYYFnnYzyYuLSp5JDpFqsI47zPh7WgT7ViVBtcO3XGKl3imjqaFd K4gbkpss+/4dE+uu/onbzazhHjhynwixz9tMzV5o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Steve Capper , Will Deacon , Suzuki K Poulose , Sasha Levin Subject: [PATCH 4.14 038/209] arm64: smp: Handle errors reported by the firmware Date: Wed, 4 Dec 2019 18:54:10 +0100 Message-Id: <20191204175324.047182044@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175321.609072813@linuxfoundation.org> References: <20191204175321.609072813@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Suzuki K Poulose [ Upstream commit f357b3a7e17af7736d67d8267edc1ed3d1dd9391 ] The __cpu_up() routine ignores the errors reported by the firmware for a CPU bringup operation and looks for the error status set by the booting CPU. If the CPU never entered the kernel, we could end up in assuming stale error status, which otherwise would have been set/cleared appropriately by the booting CPU. Reported-by: Steve Capper Cc: Will Deacon Signed-off-by: Suzuki K Poulose Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- arch/arm64/kernel/smp.c | 1 + 1 file changed, 1 insertion(+) -- 2.20.1 diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index 0881dfab10f8f..909bf3926fd23 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -144,6 +144,7 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle) } } else { pr_err("CPU%u: failed to boot: %d\n", cpu, ret); + return ret; } secondary_data.task = NULL;