From patchwork Wed Dec 4 17:56:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 180832 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp940328ile; Wed, 4 Dec 2019 10:09:09 -0800 (PST) X-Google-Smtp-Source: APXvYqzUxOi0mroz89Cquub/xTDl1FKe8PdxGRWWhBIru9zWqM5AmHc4DgIy0WUcScTyHx+FuiLH X-Received: by 2002:a54:4788:: with SMTP id o8mr3836463oic.32.1575482949711; Wed, 04 Dec 2019 10:09:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575482949; cv=none; d=google.com; s=arc-20160816; b=liWIU56Dl1Ewk8IqTsvwuZtMeVVFADzIsdhAU5bqkISO4pi9urtq5MgyqftlewJYcM uQLDF7faJ7taWFU/l80niMjm2n+hASYhjwRsomDFvdb5u1lJXtd4U+PrrJz90H+m1ZVa Py9R1ebvrQryNkUvYQB/B5oQWzM/7CCXHWisOb/NbnqZXzYbKgrgk0D5MUnNHjnqgtkd JhuVlJgMZlc6Cdb7QFyRGyX4wp+PmLoSVJ1oJ6RfTN3sHH5bGDX7oUNbXWL9iEYgZQOZ 9sRHp5Zx4uyqLnMginRctxWjcALFC2+g4BEwV5X26fSACDI50udC3PiOnNddD9qrm/sQ iJbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=AiicBYpvpa06yC7avYYD25GfI6z68tBgsqYkHpArztM=; b=YwZXfjRPDUqgi/uVHZLiFyUc5aC0NnJrY/HuLVjbJ+YNOGPxOiLU4SeFn2tuHSC3hW s4WPYHIurMdVXfa6Eeottiof/T19M2ZrZ6WMqrSCKRHgSI/f1MmkoG2XE9CEkutvua+Y HfwtqjJrm8RXtcfeqpzicOuSK7nRWL5K4Db+ZCrph6fREuvOcUoDHZ8lKbDJmFXtKRZN HcLak2UaqA85TU/V5avg5HAqiYg7NpqrDoqn+jR71qE13AqwEKYos5KzUAKsr9MJY6l1 z51vl5C7sS2AkbP1LNbP/BYFjZj9/RNsvRwxtP/YGONYEDTQXpuvbVmc/dig1J4xr9hB fW3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Nz7sap94; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o11si3560798otl.286.2019.12.04.10.09.08; Wed, 04 Dec 2019 10:09:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Nz7sap94; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731009AbfLDSJG (ORCPT + 15 others); Wed, 4 Dec 2019 13:09:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:34178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730997AbfLDSJF (ORCPT ); Wed, 4 Dec 2019 13:09:05 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0D8920675; Wed, 4 Dec 2019 18:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482945; bh=2HhXux3UgyzTgTzC9CWGxVny0zbkSdgUsNwkVpdPeZM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nz7sap94DqMNhzcfEZVt+03Rt/HFHE0YitYDO69KD4rLVttNvjax1V2puBVVlceM2 HR8CD6BpgISqQIvggOI4D0JoVhrqFA8sfOuDR9q/iyzToRYviNgcHriNr3df0vmRsb QeCkCSN8fMzDCTpnE5z8KpuSkChKnYYhMg++pGcM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lionel Debieve , Herbert Xu , Mathieu Poirier Subject: [PATCH 4.14 199/209] crypto: stm32/hash - Fix hmac issue more than 256 bytes Date: Wed, 4 Dec 2019 18:56:51 +0100 Message-Id: <20191204175337.184460827@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175321.609072813@linuxfoundation.org> References: <20191204175321.609072813@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Lionel Debieve commit 0acabecebc912b3ba06289e4ef40476acc499a37 upstream. Correct condition for the second hmac loop. Key must be only set in the first loop. Initial condition was wrong, HMAC_KEY flag was not properly checked. Signed-off-by: Lionel Debieve Signed-off-by: Herbert Xu Signed-off-by: Mathieu Poirier Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/stm32/stm32-hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/crypto/stm32/stm32-hash.c +++ b/drivers/crypto/stm32/stm32-hash.c @@ -361,7 +361,7 @@ static int stm32_hash_xmit_cpu(struct st return -ETIMEDOUT; if ((hdev->flags & HASH_FLAGS_HMAC) && - (hdev->flags & ~HASH_FLAGS_HMAC_KEY)) { + (!(hdev->flags & HASH_FLAGS_HMAC_KEY))) { hdev->flags |= HASH_FLAGS_HMAC_KEY; stm32_hash_write_key(hdev); if (stm32_hash_wait_busy(hdev))