util-linux: Use PCRE for hardlink

Message ID 20191204193254.2418208-1-raj.khem@gmail.com
State New
Headers show
Series
  • util-linux: Use PCRE for hardlink
Related show

Commit Message

Khem Raj Dec. 4, 2019, 7:32 p.m.
Use PCRE, this enables using posix extended Regexps on cmdline

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta/recipes-core/util-linux/util-linux.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.24.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Richard Purdie Dec. 4, 2019, 8 p.m. | #1
On Wed, 2019-12-04 at 11:32 -0800, Khem Raj wrote:
> Use PCRE, this enables using posix extended Regexps on cmdline

> 

> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> ---

>  meta/recipes-core/util-linux/util-linux.inc | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/meta/recipes-core/util-linux/util-linux.inc

> b/meta/recipes-core/util-linux/util-linux.inc

> index 1fa82363b1..8f867aa9b4 100644

> --- a/meta/recipes-core/util-linux/util-linux.inc

> +++ b/meta/recipes-core/util-linux/util-linux.inc

> @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "

> file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099

>  

>  #gtk-doc is not enabled as it requires xmlto which requires util-

> linux

>  inherit autotools gettext manpages pkgconfig systemd update-

> alternatives python3-dir bash-completion ptest

> -DEPENDS = "libcap-ng ncurses virtual/crypt zlib"

> +DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"

>  

>  MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"

>  SRC_URI =

> "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${BP}.tar.x

> z \


Given it works today without that, shouldn't it be a PACKAGECONFIG?

Cheers,

Richard

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj Dec. 4, 2019, 8:12 p.m. | #2
On Wed, Dec 4, 2019 at 12:00 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>

> On Wed, 2019-12-04 at 11:32 -0800, Khem Raj wrote:

> > Use PCRE, this enables using posix extended Regexps on cmdline

> >

> > Signed-off-by: Khem Raj <raj.khem@gmail.com>

> > ---

> >  meta/recipes-core/util-linux/util-linux.inc | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> >

> > diff --git a/meta/recipes-core/util-linux/util-linux.inc

> > b/meta/recipes-core/util-linux/util-linux.inc

> > index 1fa82363b1..8f867aa9b4 100644

> > --- a/meta/recipes-core/util-linux/util-linux.inc

> > +++ b/meta/recipes-core/util-linux/util-linux.inc

> > @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "

> > file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099

> >

> >  #gtk-doc is not enabled as it requires xmlto which requires util-

> > linux

> >  inherit autotools gettext manpages pkgconfig systemd update-

> > alternatives python3-dir bash-completion ptest

> > -DEPENDS = "libcap-ng ncurses virtual/crypt zlib"

> > +DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"

> >

> >  MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"

> >  SRC_URI =

> > "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${BP}.tar.x

> > z \

>

> Given it works today without that, shouldn't it be a PACKAGECONFIG?


its default with other main linux distros. I thought since what we
were doing was not
default, I did not see a need for packageconfig. I can certain do a v2
with packageconfig
and enabling it by default, is that better ?

>

> Cheers,

>

> Richard

>

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Richard Purdie Dec. 4, 2019, 8:18 p.m. | #3
On Wed, 2019-12-04 at 12:12 -0800, Khem Raj wrote:
> On Wed, Dec 4, 2019 at 12:00 PM Richard Purdie

> <richard.purdie@linuxfoundation.org> wrote:

> > On Wed, 2019-12-04 at 11:32 -0800, Khem Raj wrote:

> > > Use PCRE, this enables using posix extended Regexps on cmdline

> > > 

> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>

> > > ---

> > >  meta/recipes-core/util-linux/util-linux.inc | 2 +-

> > >  1 file changed, 1 insertion(+), 1 deletion(-)

> > > 

> > > diff --git a/meta/recipes-core/util-linux/util-linux.inc

> > > b/meta/recipes-core/util-linux/util-linux.inc

> > > index 1fa82363b1..8f867aa9b4 100644

> > > --- a/meta/recipes-core/util-linux/util-linux.inc

> > > +++ b/meta/recipes-core/util-linux/util-linux.inc

> > > @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "

> > > file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099

> > > 

> > >  #gtk-doc is not enabled as it requires xmlto which requires

> > > util-

> > > linux

> > >  inherit autotools gettext manpages pkgconfig systemd update-

> > > alternatives python3-dir bash-completion ptest

> > > -DEPENDS = "libcap-ng ncurses virtual/crypt zlib"

> > > +DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"

> > > 

> > >  MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"

> > >  SRC_URI =

> > > "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${BP}.t

> > > ar.x

> > > z \

> > 

> > Given it works today without that, shouldn't it be a PACKAGECONFIG?

> 

> its default with other main linux distros. I thought since what we

> were doing was not

> default, I did not see a need for packageconfig. I can certain do a

> v2 with packageconfig and enabling it by default, is that better ?


We're embedded so we're supposed to expose this kind of config and tend
to the more minimal ;-)

Cheers,

Richard

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj Dec. 4, 2019, 8:21 p.m. | #4
On Wed, Dec 4, 2019 at 12:18 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>

> On Wed, 2019-12-04 at 12:12 -0800, Khem Raj wrote:

> > On Wed, Dec 4, 2019 at 12:00 PM Richard Purdie

> > <richard.purdie@linuxfoundation.org> wrote:

> > > On Wed, 2019-12-04 at 11:32 -0800, Khem Raj wrote:

> > > > Use PCRE, this enables using posix extended Regexps on cmdline

> > > >

> > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>

> > > > ---

> > > >  meta/recipes-core/util-linux/util-linux.inc | 2 +-

> > > >  1 file changed, 1 insertion(+), 1 deletion(-)

> > > >

> > > > diff --git a/meta/recipes-core/util-linux/util-linux.inc

> > > > b/meta/recipes-core/util-linux/util-linux.inc

> > > > index 1fa82363b1..8f867aa9b4 100644

> > > > --- a/meta/recipes-core/util-linux/util-linux.inc

> > > > +++ b/meta/recipes-core/util-linux/util-linux.inc

> > > > @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "

> > > > file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099

> > > >

> > > >  #gtk-doc is not enabled as it requires xmlto which requires

> > > > util-

> > > > linux

> > > >  inherit autotools gettext manpages pkgconfig systemd update-

> > > > alternatives python3-dir bash-completion ptest

> > > > -DEPENDS = "libcap-ng ncurses virtual/crypt zlib"

> > > > +DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"

> > > >

> > > >  MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"

> > > >  SRC_URI =

> > > > "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${BP}.t

> > > > ar.x

> > > > z \

> > >

> > > Given it works today without that, shouldn't it be a PACKAGECONFIG?

> >

> > its default with other main linux distros. I thought since what we

> > were doing was not

> > default, I did not see a need for packageconfig. I can certain do a

> > v2 with packageconfig and enabling it by default, is that better ?

>

> We're embedded so we're supposed to expose this kind of config and tend

> to the more minimal ;-)


I was more looking into native and nativesdk variants where this could
be more important.

>

> Cheers,

>

> Richard

>

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Richard Purdie Dec. 4, 2019, 8:22 p.m. | #5
On Wed, 2019-12-04 at 12:21 -0800, Khem Raj wrote:
> On Wed, Dec 4, 2019 at 12:18 PM Richard Purdie

> <richard.purdie@linuxfoundation.org> wrote:

> > On Wed, 2019-12-04 at 12:12 -0800, Khem Raj wrote:

> > > On Wed, Dec 4, 2019 at 12:00 PM Richard Purdie

> > > <richard.purdie@linuxfoundation.org> wrote:

> > > > On Wed, 2019-12-04 at 11:32 -0800, Khem Raj wrote:

> > > > > Use PCRE, this enables using posix extended Regexps on

> > > > > cmdline

> > > > > 

> > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>

> > > > > ---

> > > > >  meta/recipes-core/util-linux/util-linux.inc | 2 +-

> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)

> > > > > 

> > > > > diff --git a/meta/recipes-core/util-linux/util-linux.inc

> > > > > b/meta/recipes-core/util-linux/util-linux.inc

> > > > > index 1fa82363b1..8f867aa9b4 100644

> > > > > --- a/meta/recipes-core/util-linux/util-linux.inc

> > > > > +++ b/meta/recipes-core/util-linux/util-linux.inc

> > > > > @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "

> > > > > file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099

> > > > > 

> > > > >  #gtk-doc is not enabled as it requires xmlto which requires

> > > > > util-

> > > > > linux

> > > > >  inherit autotools gettext manpages pkgconfig systemd update-

> > > > > alternatives python3-dir bash-completion ptest

> > > > > -DEPENDS = "libcap-ng ncurses virtual/crypt zlib"

> > > > > +DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"

> > > > > 

> > > > >  MAJOR_VERSION =

> > > > > "${@'.'.join(d.getVar('PV').split('.')[0:2])}"

> > > > >  SRC_URI =

> > > > > "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${B

> > > > > P}.t

> > > > > ar.x

> > > > > z \

> > > > 

> > > > Given it works today without that, shouldn't it be a

> > > > PACKAGECONFIG?

> > > 

> > > its default with other main linux distros. I thought since what

> > > we

> > > were doing was not

> > > default, I did not see a need for packageconfig. I can certain do

> > > a

> > > v2 with packageconfig and enabling it by default, is that better

> > > ?

> > 

> > We're embedded so we're supposed to expose this kind of config and

> > tend

> > to the more minimal ;-)

> 

> I was more looking into native and nativesdk variants where this

> could be more important.


Sure, but your patch changes the target version too...

Cheers,

Richard

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj Dec. 4, 2019, 8:25 p.m. | #6
On Wed, Dec 4, 2019 at 12:22 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>

> On Wed, 2019-12-04 at 12:21 -0800, Khem Raj wrote:

> > On Wed, Dec 4, 2019 at 12:18 PM Richard Purdie

> > <richard.purdie@linuxfoundation.org> wrote:

> > > On Wed, 2019-12-04 at 12:12 -0800, Khem Raj wrote:

> > > > On Wed, Dec 4, 2019 at 12:00 PM Richard Purdie

> > > > <richard.purdie@linuxfoundation.org> wrote:

> > > > > On Wed, 2019-12-04 at 11:32 -0800, Khem Raj wrote:

> > > > > > Use PCRE, this enables using posix extended Regexps on

> > > > > > cmdline

> > > > > >

> > > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>

> > > > > > ---

> > > > > >  meta/recipes-core/util-linux/util-linux.inc | 2 +-

> > > > > >  1 file changed, 1 insertion(+), 1 deletion(-)

> > > > > >

> > > > > > diff --git a/meta/recipes-core/util-linux/util-linux.inc

> > > > > > b/meta/recipes-core/util-linux/util-linux.inc

> > > > > > index 1fa82363b1..8f867aa9b4 100644

> > > > > > --- a/meta/recipes-core/util-linux/util-linux.inc

> > > > > > +++ b/meta/recipes-core/util-linux/util-linux.inc

> > > > > > @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "

> > > > > > file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099

> > > > > >

> > > > > >  #gtk-doc is not enabled as it requires xmlto which requires

> > > > > > util-

> > > > > > linux

> > > > > >  inherit autotools gettext manpages pkgconfig systemd update-

> > > > > > alternatives python3-dir bash-completion ptest

> > > > > > -DEPENDS = "libcap-ng ncurses virtual/crypt zlib"

> > > > > > +DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"

> > > > > >

> > > > > >  MAJOR_VERSION =

> > > > > > "${@'.'.join(d.getVar('PV').split('.')[0:2])}"

> > > > > >  SRC_URI =

> > > > > > "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${B

> > > > > > P}.t

> > > > > > ar.x

> > > > > > z \

> > > > >

> > > > > Given it works today without that, shouldn't it be a

> > > > > PACKAGECONFIG?

> > > >

> > > > its default with other main linux distros. I thought since what

> > > > we

> > > > were doing was not

> > > > default, I did not see a need for packageconfig. I can certain do

> > > > a

> > > > v2 with packageconfig and enabling it by default, is that better

> > > > ?

> > >

> > > We're embedded so we're supposed to expose this kind of config and

> > > tend

> > > to the more minimal ;-)

> >

> > I was more looking into native and nativesdk variants where this

> > could be more important.

>

> Sure, but your patch changes the target version too...

>


sent a v2

> Cheers,

>

> Richard

>

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc
index 1fa82363b1..8f867aa9b4 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -20,7 +20,7 @@  LIC_FILES_CHKSUM = "file://README.licensing;md5=972a134f1e14b2b060e365df2fab0099
 
 #gtk-doc is not enabled as it requires xmlto which requires util-linux
 inherit autotools gettext manpages pkgconfig systemd update-alternatives python3-dir bash-completion ptest
-DEPENDS = "libcap-ng ncurses virtual/crypt zlib"
+DEPENDS = "libcap-ng ncurses virtual/crypt zlib libpcre2"
 
 MAJOR_VERSION = "${@'.'.join(d.getVar('PV').split('.')[0:2])}"
 SRC_URI = "${KERNELORG_MIRROR}/linux/utils/${BPN}/v${MAJOR_VERSION}/${BP}.tar.xz \