[v6,04/15] arm64: kernel: avoid x18 in __cpu_soft_restart

Message ID 20191206221351.38241-5-samitolvanen@google.com
State New
Headers show
Series
  • Untitled series #25464
Related show

Commit Message

Sami Tolvanen Dec. 6, 2019, 10:13 p.m.
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>


The code in __cpu_soft_restart() uses x18 as an arbitrary temp register,
which will shortly be disallowed. So use x8 instead.

Link: https://patchwork.kernel.org/patch/9836877/
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

[Sami: updated commit message]
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>

Reviewed-by: Mark Rutland <mark.rutland@arm.com>

Reviewed-by: Kees Cook <keescook@chromium.org>

---
 arch/arm64/kernel/cpu-reset.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.24.0.393.g34dc348eaf-goog

Patch

diff --git a/arch/arm64/kernel/cpu-reset.S b/arch/arm64/kernel/cpu-reset.S
index 6ea337d464c4..32c7bf858dd9 100644
--- a/arch/arm64/kernel/cpu-reset.S
+++ b/arch/arm64/kernel/cpu-reset.S
@@ -42,11 +42,11 @@  ENTRY(__cpu_soft_restart)
 	mov	x0, #HVC_SOFT_RESTART
 	hvc	#0				// no return
 
-1:	mov	x18, x1				// entry
+1:	mov	x8, x1				// entry
 	mov	x0, x2				// arg0
 	mov	x1, x3				// arg1
 	mov	x2, x4				// arg2
-	br	x18
+	br	x8
 ENDPROC(__cpu_soft_restart)
 
 .popsection