[1/4] selftest-hardlink: don't RDEPEND on gdb explicitly

Message ID 20191209122007.13306-1-ross.burton@intel.com
State New
Headers show
Series
  • [1/4] selftest-hardlink: don't RDEPEND on gdb explicitly
Related show

Commit Message

Ross Burton Dec. 9, 2019, 12:20 p.m.
For easy of reuse and speed of building, don't RDEPEND on gdb
explicitly.  Instead put gdb.sh into ${PN} and explicitly install gdb
into the image if needed.

This means other tests that don't need to use gdb can reuse
this recipe without waiting for a target gdb to build.

Signed-off-by: Ross Burton <ross.burton@intel.com>

---
 .../recipes-test/selftest-hardlink/selftest-hardlink.bb       | 4 ----
 meta/lib/oeqa/selftest/cases/package.py                       | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

-- 
2.20.1

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta-selftest/recipes-test/selftest-hardlink/selftest-hardlink.bb b/meta-selftest/recipes-test/selftest-hardlink/selftest-hardlink.bb
index 842a9772cbe..8b336a04c9f 100644
--- a/meta-selftest/recipes-test/selftest-hardlink/selftest-hardlink.bb
+++ b/meta-selftest/recipes-test/selftest-hardlink/selftest-hardlink.bb
@@ -24,7 +24,3 @@  do_install () {
 
 	dd if=/dev/zero of=${D}${bindir}/sparsetest bs=1 count=0 seek=1M
 }
-
-RDEPENDS_${PN}-gdb += "gdb"
-PACKAGES =+ "${PN}-gdb"
-FILES_${PN}-gdb = "${bindir}/gdb.sh"
diff --git a/meta/lib/oeqa/selftest/cases/package.py b/meta/lib/oeqa/selftest/cases/package.py
index b87f8dc3e2c..c6444062674 100644
--- a/meta/lib/oeqa/selftest/cases/package.py
+++ b/meta/lib/oeqa/selftest/cases/package.py
@@ -118,7 +118,7 @@  class PackageTests(OESelftestTestCase):
     def test_gdb_hardlink_debug(self):
         features = 'IMAGE_INSTALL_append = " selftest-hardlink"\n'
         features += 'IMAGE_INSTALL_append = " selftest-hardlink-dbg"\n'
-        features += 'IMAGE_INSTALL_append = " selftest-hardlink-gdb"\n'
+        features += 'IMAGE_INSTALL_append = " gdb"\n'
         self.write_config(features)
         bitbake("core-image-minimal")