[PATCHv1,1/2] dt-bindings: max3421-udc: add dt bindings for MAX3420 UDC

Message ID 20191210003124.32376-1-jassisinghbrar@gmail.com
State New
Headers show
Series
  • [PATCHv1,1/2] dt-bindings: max3421-udc: add dt bindings for MAX3420 UDC
Related show

Commit Message

Jassi Brar Dec. 10, 2019, 12:31 a.m.
From: Jassi Brar <jaswinder.singh@linaro.org>


Add YAML dt bindings for Maxim MAX3420 UDC controller.

Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>

---
 .../bindings/usb/maxim,max3420-udc.yaml       | 60 +++++++++++++++++++
 1 file changed, 60 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/maxim,max3420-udc.yaml

-- 
2.20.1

Comments

Rob Herring Dec. 19, 2019, 7:40 p.m. | #1
On Mon, Dec 09, 2019 at 06:31:24PM -0600, jassisinghbrar@gmail.com wrote:
> From: Jassi Brar <jaswinder.singh@linaro.org>

> 

> Add YAML dt bindings for Maxim MAX3420 UDC controller.

> 

> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>

> ---

>  .../bindings/usb/maxim,max3420-udc.yaml       | 60 +++++++++++++++++++

>  1 file changed, 60 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/usb/maxim,max3420-udc.yaml

> 

> diff --git a/Documentation/devicetree/bindings/usb/maxim,max3420-udc.yaml b/Documentation/devicetree/bindings/usb/maxim,max3420-udc.yaml

> new file mode 100644

> index 000000000000..cf4eec8a618e

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/usb/maxim,max3420-udc.yaml

> @@ -0,0 +1,60 @@

> +# SPDX-License-Identifier: GPL-2.0-only


Dual license new bindings please:

(GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2

> +---

> +$id: http://devicetree.org/schemas/usb/maxim,max3420-udc.yaml#

> +$schema: http://devicetree.org/meta-schemas/core.yaml#

> +

> +title: MAXIM MAX3420/1 USB Peripheral Controller

> +

> +maintainers:

> +  - Jassi Brar <jaswinder.singh@linaro.org>

> +

> +description: |

> +  The controller provices USB2.0 compliant FullSpeed peripheral

> +  implementation over the  SPI interface.


space                        ^

> +

> +  Specifications about the part can be found at:

> +    http://datasheets.maximintegrated.com/en/ds/MAX3420E.pdf

> +

> +properties:

> +  compatible:

> +    enum:

> +      - maxim,max3420-udc

> +      - maxim,max3421-udc

> +

> +  reg:

> +    maxItems: 1

> +

> +  interrupts:

> +    minItems: 1

> +    maxItems: 2

> +    items:

> +      - const: udc

> +      - const: vbus


interrupts are integers, not strings. Should be interrupt-names?

> +

> +  spi-max-frequency:

> +    maximum: 26000000

> +

> +required:

> +  - compatible

> +  - reg

> +  - interrupts

> +  - interrupt-names


Add:

additionalProperties: false

> +

> +examples:

> +  - |

> +      #include <dt-bindings/gpio/gpio.h>

> +      #include <dt-bindings/interrupt-controller/irq.h>

> +      spi0 {

> +            #address-cells = <1>;

> +            #size-cells = <0>;

> +

> +            udc@0 {

> +                  compatible = "maxim,max3420-udc";

> +                  reg = <0>;

> +                  interrupt-parent = <&gpio>;

> +                  interrupts = <0 IRQ_TYPE_EDGE_FALLING>, <10 IRQ_TYPE_EDGE_BOTH>;

> +                  interrupt-names = "udc", "vbus";

> +                  spi-max-frequency = <12500000>;

> +            };

> +      };

> -- 

> 2.20.1

>
Jassi Brar Dec. 23, 2019, 9:44 p.m. | #2
On Thu, Dec 19, 2019 at 1:40 PM Rob Herring <robh@kernel.org> wrote:
>

> On Mon, Dec 09, 2019 at 06:31:24PM -0600, jassisinghbrar@gmail.com wrote:

> > From: Jassi Brar <jaswinder.singh@linaro.org>

> >

> > Add YAML dt bindings for Maxim MAX3420 UDC controller.

> >

> > Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>

> > ---

> >  .../bindings/usb/maxim,max3420-udc.yaml       | 60 +++++++++++++++++++

> >  1 file changed, 60 insertions(+)

> >  create mode 100644 Documentation/devicetree/bindings/usb/maxim,max3420-udc.yaml

> >

> > diff --git a/Documentation/devicetree/bindings/usb/maxim,max3420-udc.yaml b/Documentation/devicetree/bindings/usb/maxim,max3420-udc.yaml

> > new file mode 100644

> > index 000000000000..cf4eec8a618e

> > --- /dev/null

> > +++ b/Documentation/devicetree/bindings/usb/maxim,max3420-udc.yaml

> > @@ -0,0 +1,60 @@

> > +# SPDX-License-Identifier: GPL-2.0-only

>

> Dual license new bindings please:

>

> (GPL-2.0-only OR BSD-2-Clause)

>

ok

> > +%YAML 1.2

> > +---

> > +$id: http://devicetree.org/schemas/usb/maxim,max3420-udc.yaml#

> > +$schema: http://devicetree.org/meta-schemas/core.yaml#

> > +

> > +title: MAXIM MAX3420/1 USB Peripheral Controller

> > +

> > +maintainers:

> > +  - Jassi Brar <jaswinder.singh@linaro.org>

> > +

> > +description: |

> > +  The controller provices USB2.0 compliant FullSpeed peripheral

> > +  implementation over the  SPI interface.

>

> space                        ^

>

ok

> > +

> > +  Specifications about the part can be found at:

> > +    http://datasheets.maximintegrated.com/en/ds/MAX3420E.pdf

> > +

> > +properties:

> > +  compatible:

> > +    enum:

> > +      - maxim,max3420-udc

> > +      - maxim,max3421-udc

> > +

> > +  reg:

> > +    maxItems: 1

> > +

> > +  interrupts:

> > +    minItems: 1

> > +    maxItems: 2

> > +    items:

> > +      - const: udc

> > +      - const: vbus

>

> interrupts are integers, not strings. Should be interrupt-names?

>

yes

> > +

> > +  spi-max-frequency:

> > +    maximum: 26000000

> > +

> > +required:

> > +  - compatible

> > +  - reg

> > +  - interrupts

> > +  - interrupt-names

>

> Add:

>

> additionalProperties: false

>

ok

Thanks.

Patch

diff --git a/Documentation/devicetree/bindings/usb/maxim,max3420-udc.yaml b/Documentation/devicetree/bindings/usb/maxim,max3420-udc.yaml
new file mode 100644
index 000000000000..cf4eec8a618e
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/maxim,max3420-udc.yaml
@@ -0,0 +1,60 @@ 
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/maxim,max3420-udc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MAXIM MAX3420/1 USB Peripheral Controller
+
+maintainers:
+  - Jassi Brar <jaswinder.singh@linaro.org>
+
+description: |
+  The controller provices USB2.0 compliant FullSpeed peripheral
+  implementation over the  SPI interface.
+
+  Specifications about the part can be found at:
+    http://datasheets.maximintegrated.com/en/ds/MAX3420E.pdf
+
+properties:
+  compatible:
+    enum:
+      - maxim,max3420-udc
+      - maxim,max3421-udc
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    minItems: 1
+    maxItems: 2
+    items:
+      - const: udc
+      - const: vbus
+
+  spi-max-frequency:
+    maximum: 26000000
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-names
+
+examples:
+  - |
+      #include <dt-bindings/gpio/gpio.h>
+      #include <dt-bindings/interrupt-controller/irq.h>
+      spi0 {
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            udc@0 {
+                  compatible = "maxim,max3420-udc";
+                  reg = <0>;
+                  interrupt-parent = <&gpio>;
+                  interrupts = <0 IRQ_TYPE_EDGE_FALLING>, <10 IRQ_TYPE_EDGE_BOTH>;
+                  interrupt-names = "udc", "vbus";
+                  spi-max-frequency = <12500000>;
+            };
+      };