[oe,meta-networking] netperf: add "intervals" and "histogram" PACKAGECONFIGs

Message ID 1576014699-29663-1-git-send-email-denis@denix.org
State New
Headers show
Series
  • [oe,meta-networking] netperf: add "intervals" and "histogram" PACKAGECONFIGs
Related show

Commit Message

Denys Dmytriyenko Dec. 10, 2019, 9:51 p.m.
From: Denys Dmytriyenko <denys@ti.com>

From https://hewlettpackard.github.io/netperf/doc/netperf.html:

Other optional configure-time settings include --enable-intervals=yes to give
netperf the ability to “pace” its _STREAM tests and --enable-histogram=yes to
have netperf keep a histogram of interesting times.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 meta-networking/recipes-support/netperf/netperf_git.bb | 2 ++
 1 file changed, 2 insertions(+)

Comments

Khem Raj Dec. 10, 2019, 11:48 p.m. | #1
On Tue, Dec 10, 2019 at 1:52 PM Denys Dmytriyenko <denis@denix.org> wrote:
>
> From: Denys Dmytriyenko <denys@ti.com>
>
> From https://hewlettpackard.github.io/netperf/doc/netperf.html:
>
> Other optional configure-time settings include --enable-intervals=yes to give
> netperf the ability to “pace” its _STREAM tests and --enable-histogram=yes to
> have netperf keep a histogram of interesting times.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>  meta-networking/recipes-support/netperf/netperf_git.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-networking/recipes-support/netperf/netperf_git.bb b/meta-networking/recipes-support/netperf/netperf_git.bb
> index 8921ea7..f1f62df 100644
> --- a/meta-networking/recipes-support/netperf/netperf_git.bb
> +++ b/meta-networking/recipes-support/netperf/netperf_git.bb
> @@ -31,6 +31,8 @@ CFLAGS_append = "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', \
>
>  PACKAGECONFIG ??= ""
>  PACKAGECONFIG[sctp] = "--enable-sctp,--disable-sctp,lksctp-tools,"
> +PACKAGECONFIG[intervals] = "--enable-intervals,--disable-intervals,,"
> +PACKAGECONFIG[histogram] = "--enable-histogram,--disable-histogram,,"
>

now that they are explicitly disabled, Does it change the defaults ?


>  # autotools.bbclass attends to include m4 files with path depth <= 2 by
>  # "find ${S} -maxdepth 2 -name \*.m4", so move m4 files from m4/m4.
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Denys Dmytriyenko Dec. 11, 2019, 12:21 a.m. | #2
On Tue, Dec 10, 2019 at 03:48:58PM -0800, Khem Raj wrote:
> On Tue, Dec 10, 2019 at 1:52 PM Denys Dmytriyenko <denis@denix.org> wrote:
> >
> > From: Denys Dmytriyenko <denys@ti.com>
> >
> > From https://hewlettpackard.github.io/netperf/doc/netperf.html:
> >
> > Other optional configure-time settings include --enable-intervals=yes to give
> > netperf the ability to “pace” its _STREAM tests and --enable-histogram=yes to
> > have netperf keep a histogram of interesting times.
> >
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> >  meta-networking/recipes-support/netperf/netperf_git.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta-networking/recipes-support/netperf/netperf_git.bb b/meta-networking/recipes-support/netperf/netperf_git.bb
> > index 8921ea7..f1f62df 100644
> > --- a/meta-networking/recipes-support/netperf/netperf_git.bb
> > +++ b/meta-networking/recipes-support/netperf/netperf_git.bb
> > @@ -31,6 +31,8 @@ CFLAGS_append = "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', \
> >
> >  PACKAGECONFIG ??= ""
> >  PACKAGECONFIG[sctp] = "--enable-sctp,--disable-sctp,lksctp-tools,"
> > +PACKAGECONFIG[intervals] = "--enable-intervals,--disable-intervals,,"
> > +PACKAGECONFIG[histogram] = "--enable-histogram,--disable-histogram,,"
> >
> 
> now that they are explicitly disabled, Does it change the defaults ?

I don't know if there were any automatic checks under the hood to enable them 
by default (I don't believe so), but I needed to explicitly enable them in few 
of my builds to get them in.

Patch

diff --git a/meta-networking/recipes-support/netperf/netperf_git.bb b/meta-networking/recipes-support/netperf/netperf_git.bb
index 8921ea7..f1f62df 100644
--- a/meta-networking/recipes-support/netperf/netperf_git.bb
+++ b/meta-networking/recipes-support/netperf/netperf_git.bb
@@ -31,6 +31,8 @@  CFLAGS_append = "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', \
 
 PACKAGECONFIG ??= ""
 PACKAGECONFIG[sctp] = "--enable-sctp,--disable-sctp,lksctp-tools,"
+PACKAGECONFIG[intervals] = "--enable-intervals,--disable-intervals,,"
+PACKAGECONFIG[histogram] = "--enable-histogram,--disable-histogram,,"
 
 # autotools.bbclass attends to include m4 files with path depth <= 2 by
 # "find ${S} -maxdepth 2 -name \*.m4", so move m4 files from m4/m4.