mfd: ab8500: Fix ab8500-clk typo

Message ID 20191211114639.748463-1-linus.walleij@linaro.org
State Accepted
Commit 702204c22c53f94b2e25a3bdcda759cce7b26305
Headers show
Series
  • mfd: ab8500: Fix ab8500-clk typo
Related show

Commit Message

Linus Walleij Dec. 11, 2019, 11:46 a.m.
Commit f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
has a typo error renaming "ab8500-clk" to "abx500-clk"
with the result att ALSA SoC audio broke as the clock
driver was not probing anymore. Fixed it up.

Cc: Stephan Gerhold <stephan@gerhold.net>
Fixes: f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 drivers/mfd/ab8500-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.23.0

Comments

Stephan Gerhold Dec. 11, 2019, 5:18 p.m. | #1
On Wed, Dec 11, 2019 at 12:46:39PM +0100, Linus Walleij wrote:
> Commit f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")

> has a typo error renaming "ab8500-clk" to "abx500-clk"

> with the result att ALSA SoC audio broke as the clock

> driver was not probing anymore. Fixed it up.

> 

> Cc: Stephan Gerhold <stephan@gerhold.net>

> Fixes: f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>


FWIW:
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>


> ---

>  drivers/mfd/ab8500-core.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c

> index bafc729fc434..3c6fda68e6bc 100644

> --- a/drivers/mfd/ab8500-core.c

> +++ b/drivers/mfd/ab8500-core.c

> @@ -631,8 +631,8 @@ static const struct mfd_cell ab8500_devs[] = {

>  		    NULL, NULL, 0, 0, "stericsson,ab8500-ext-regulator"),

>  	OF_MFD_CELL("ab8500-regulator",

>  		    NULL, NULL, 0, 0, "stericsson,ab8500-regulator"),

> -	OF_MFD_CELL("abx500-clk",

> -		    NULL, NULL, 0, 0, "stericsson,abx500-clk"),

> +	OF_MFD_CELL("ab8500-clk",

> +		    NULL, NULL, 0, 0, "stericsson,ab8500-clk"),

>  	OF_MFD_CELL("ab8500-gpadc",

>  		    NULL, NULL, 0, 0, "stericsson,ab8500-gpadc"),

>  	OF_MFD_CELL("ab8500-rtc",

> -- 

> 2.23.0

>
Lee Jones Dec. 16, 2019, 3:22 p.m. | #2
On Wed, 11 Dec 2019, Linus Walleij wrote:

> Commit f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")

> has a typo error renaming "ab8500-clk" to "abx500-clk"

> with the result att ALSA SoC audio broke as the clock

> driver was not probing anymore. Fixed it up.

> 

> Cc: Stephan Gerhold <stephan@gerhold.net>

> Fixes: f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> ---

>  drivers/mfd/ab8500-core.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)


Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Patch

diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
index bafc729fc434..3c6fda68e6bc 100644
--- a/drivers/mfd/ab8500-core.c
+++ b/drivers/mfd/ab8500-core.c
@@ -631,8 +631,8 @@  static const struct mfd_cell ab8500_devs[] = {
 		    NULL, NULL, 0, 0, "stericsson,ab8500-ext-regulator"),
 	OF_MFD_CELL("ab8500-regulator",
 		    NULL, NULL, 0, 0, "stericsson,ab8500-regulator"),
-	OF_MFD_CELL("abx500-clk",
-		    NULL, NULL, 0, 0, "stericsson,abx500-clk"),
+	OF_MFD_CELL("ab8500-clk",
+		    NULL, NULL, 0, 0, "stericsson,ab8500-clk"),
 	OF_MFD_CELL("ab8500-gpadc",
 		    NULL, NULL, 0, 0, "stericsson,ab8500-gpadc"),
 	OF_MFD_CELL("ab8500-rtc",