[1/2] net: ethernet: ti: select PAGE_POOL for switchdev driver

Message ID 20191211125643.1987157-1-arnd@arndb.de
State Accepted
Commit 99e9fe2248f9bd86dd10e773c90c9b54055b1d92
Headers show
Series
  • [1/2] net: ethernet: ti: select PAGE_POOL for switchdev driver
Related show

Commit Message

Arnd Bergmann Dec. 11, 2019, 12:56 p.m.
The new driver misses a dependency:

drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_rx_handler':
cpsw_new.c:(.text+0x259c): undefined reference to `__page_pool_put_page'
cpsw_new.c:(.text+0x25d0): undefined reference to `page_pool_alloc_pages'
drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_fill_rx_channels':
cpsw_priv.c:(.text+0x22d8): undefined reference to `page_pool_alloc_pages'
cpsw_priv.c:(.text+0x2420): undefined reference to `__page_pool_put_page'
drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_create_xdp_rxqs':
cpsw_priv.c:(.text+0x2624): undefined reference to `page_pool_create'
drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_run_xdp':
cpsw_priv.c:(.text+0x2dc8): undefined reference to `__page_pool_put_page'

Other drivers use 'select' for PAGE_POOL, so do the same here.

Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/net/ethernet/ti/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.0

Comments

Ilias Apalodimas Dec. 11, 2019, 1:05 p.m. | #1
On Wed, Dec 11, 2019 at 01:56:09PM +0100, Arnd Bergmann wrote:
> The new driver misses a dependency:

> 

> drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_rx_handler':

> cpsw_new.c:(.text+0x259c): undefined reference to `__page_pool_put_page'

> cpsw_new.c:(.text+0x25d0): undefined reference to `page_pool_alloc_pages'

> drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_fill_rx_channels':

> cpsw_priv.c:(.text+0x22d8): undefined reference to `page_pool_alloc_pages'

> cpsw_priv.c:(.text+0x2420): undefined reference to `__page_pool_put_page'

> drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_create_xdp_rxqs':

> cpsw_priv.c:(.text+0x2624): undefined reference to `page_pool_create'

> drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_run_xdp':

> cpsw_priv.c:(.text+0x2dc8): undefined reference to `__page_pool_put_page'

> 

> Other drivers use 'select' for PAGE_POOL, so do the same here.

> 

> Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

>  drivers/net/ethernet/ti/Kconfig | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig

> index a46f4189fde3..bf98e0fa7d8b 100644

> --- a/drivers/net/ethernet/ti/Kconfig

> +++ b/drivers/net/ethernet/ti/Kconfig

> @@ -63,6 +63,7 @@ config TI_CPSW_SWITCHDEV

>  	tristate "TI CPSW Switch Support with switchdev"

>  	depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST

>  	depends on NET_SWITCHDEV

> +	select PAGE_POOL

>  	select TI_DAVINCI_MDIO

>  	select MFD_SYSCON

>  	select REGMAP

> -- 

> 2.20.0

> 


Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Jesper Dangaard Brouer Dec. 11, 2019, 1:17 p.m. | #2
On Wed, 11 Dec 2019 13:56:09 +0100
Arnd Bergmann <arnd@arndb.de> wrote:

> The new driver misses a dependency:

> 

> drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_rx_handler':

> cpsw_new.c:(.text+0x259c): undefined reference to `__page_pool_put_page'

> cpsw_new.c:(.text+0x25d0): undefined reference to `page_pool_alloc_pages'

> drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_fill_rx_channels':

> cpsw_priv.c:(.text+0x22d8): undefined reference to `page_pool_alloc_pages'

> cpsw_priv.c:(.text+0x2420): undefined reference to `__page_pool_put_page'

> drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_create_xdp_rxqs':

> cpsw_priv.c:(.text+0x2624): undefined reference to `page_pool_create'

> drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_run_xdp':

> cpsw_priv.c:(.text+0x2dc8): undefined reference to `__page_pool_put_page'

> 

> Other drivers use 'select' for PAGE_POOL, so do the same here.

> 

> Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>


Thanks for fixing this.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer
Grygorii Strashko Dec. 11, 2019, 1:19 p.m. | #3
On 11/12/2019 14:56, Arnd Bergmann wrote:
> The new driver misses a dependency:

> 

> drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_rx_handler':

> cpsw_new.c:(.text+0x259c): undefined reference to `__page_pool_put_page'

> cpsw_new.c:(.text+0x25d0): undefined reference to `page_pool_alloc_pages'

> drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_fill_rx_channels':

> cpsw_priv.c:(.text+0x22d8): undefined reference to `page_pool_alloc_pages'

> cpsw_priv.c:(.text+0x2420): undefined reference to `__page_pool_put_page'

> drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_create_xdp_rxqs':

> cpsw_priv.c:(.text+0x2624): undefined reference to `page_pool_create'

> drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_run_xdp':

> cpsw_priv.c:(.text+0x2dc8): undefined reference to `__page_pool_put_page'

> 

> Other drivers use 'select' for PAGE_POOL, so do the same here.

> 

> Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

>   drivers/net/ethernet/ti/Kconfig | 1 +

>   1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig

> index a46f4189fde3..bf98e0fa7d8b 100644

> --- a/drivers/net/ethernet/ti/Kconfig

> +++ b/drivers/net/ethernet/ti/Kconfig

> @@ -63,6 +63,7 @@ config TI_CPSW_SWITCHDEV

>   	tristate "TI CPSW Switch Support with switchdev"

>   	depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST

>   	depends on NET_SWITCHDEV

> +	select PAGE_POOL

>   	select TI_DAVINCI_MDIO

>   	select MFD_SYSCON

>   	select REGMAP

> 


Thank you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>


-- 
Best regards,
grygorii
Jakub Kicinski Dec. 14, 2019, 8:53 p.m. | #4
On Wed, 11 Dec 2019 13:56:09 +0100, Arnd Bergmann wrote:
> The new driver misses a dependency:


Applied both, thank you!

Patch

diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index a46f4189fde3..bf98e0fa7d8b 100644
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -63,6 +63,7 @@  config TI_CPSW_SWITCHDEV
 	tristate "TI CPSW Switch Support with switchdev"
 	depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST
 	depends on NET_SWITCHDEV
+	select PAGE_POOL
 	select TI_DAVINCI_MDIO
 	select MFD_SYSCON
 	select REGMAP