[v2,2/4] ARM: dts: qcom: Correct USB3503 GPIOs polarity

Message ID 20191211145208.24976-1-m.szyprowski@samsung.com
State New
Headers show
Series
  • USB3503: correct GPIOs polarity and update the driver
Related show

Commit Message

Marek Szyprowski Dec. 11, 2019, 2:52 p.m.
Current USB3503 driver ignores GPIO polarity and always operates as if the
GPIO lines were flagged as ACTIVE_HIGH. Fix the polarity for the existing
USB3503 chip applications to match the chip specification and common
convention for naming the pins. The only pin, which has to be ACTIVE_LOW
is the reset pin. The remaining are ACTIVE_HIGH. This change allows later
to fix the USB3503 driver to properly use generic GPIO bindings and read
polarity from DT.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

---
 arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

Comments

Bjorn Andersson Dec. 18, 2019, 5:42 a.m. | #1
On Wed 11 Dec 06:52 PST 2019, Marek Szyprowski wrote:

> Current USB3503 driver ignores GPIO polarity and always operates as if the

> GPIO lines were flagged as ACTIVE_HIGH. Fix the polarity for the existing

> USB3503 chip applications to match the chip specification and common

> convention for naming the pins. The only pin, which has to be ACTIVE_LOW

> is the reset pin. The remaining are ACTIVE_HIGH. This change allows later

> to fix the USB3503 driver to properly use generic GPIO bindings and read

> polarity from DT.

> 

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>


Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>


> ---

>  arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts

> index 26160c324802..942e3a2cac35 100644

> --- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts

> +++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts

> @@ -143,7 +143,7 @@

>  				compatible = "smsc,usb3503a";

>  				reg = <0x8>;

>  				connect-gpios = <&gpioext2 1 GPIO_ACTIVE_HIGH>;

> -				intn-gpios = <&gpioext2 0 GPIO_ACTIVE_LOW>;

> +				intn-gpios = <&gpioext2 0 GPIO_ACTIVE_HIGH>;

>  				initial-mode = <1>;

>  			};

>  		};

> -- 

> 2.17.1

>

Patch

diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
index 26160c324802..942e3a2cac35 100644
--- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
+++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
@@ -143,7 +143,7 @@ 
 				compatible = "smsc,usb3503a";
 				reg = <0x8>;
 				connect-gpios = <&gpioext2 1 GPIO_ACTIVE_HIGH>;
-				intn-gpios = <&gpioext2 0 GPIO_ACTIVE_LOW>;
+				intn-gpios = <&gpioext2 0 GPIO_ACTIVE_HIGH>;
 				initial-mode = <1>;
 			};
 		};