From patchwork Wed Dec 11 15:03:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 181234 Delivered-To: patch@linaro.org Received: by 2002:ac9:44c4:0:0:0:0:0 with SMTP id t4csp910020och; Wed, 11 Dec 2019 07:17:25 -0800 (PST) X-Google-Smtp-Source: APXvYqzuNohWxLJKFVHMUu/kkufCHpVWytzXHPWcREKxFkA++Y/B6/W7dCQmuaxaV8v68tvnTaVN X-Received: by 2002:a9d:7393:: with SMTP id j19mr2547098otk.336.1576077445883; Wed, 11 Dec 2019 07:17:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576077445; cv=none; d=google.com; s=arc-20160816; b=RDh1jKiWNEiA0u/CBAtZwYORHKfwXBnBQAVrH8IiyH9yEP9E0YbWSPYPdFkR9df+J3 Zjw1rYDPbH4f+0WnAGllQDU7TR2JN0h4/uImrkvLLc0HUWyACQecoWVED538+1UoxJVD sZg44V3BCczzwNJYMh4c9kh9XKfsInlOabPMaBB8WWIIS6F57kHbLz84tw5a+My/Q8Ky g5U+EJjkXQ0rmHCx3PhspUX/NoPVxQtby/fQl7sDZKE1BrU+9fJcils/ThFkOB3ruCEY Z6KMytEZDTIW4KObgJElsZbEJHAR9/muk5F/HxIvLuxOI2T/v2WTO3uGJ7F1LkdpcPY6 XaHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1n3eSJ5jl4gISH/u8iKdGZEIUadfpuKbEgMZMZITeAg=; b=HObUovRUFKitZ1JOs6xV6QYszyPbJjDotSgF09wIEti0syOwhH2Odixnm0nIu+8mf0 TDS3vSEURWMKmer8C/tfIoZ78BjkAf/1C+5ErL+7mhzGQ2mcSLhuK/iZaZBf6QV2iDak LsZ6M99MHfVzGpNCRCKLd8JgDOhEhTS14ou/0NLlYYxfrvClJlpJ3k3lzWLofs7nwrKc nyO87W0OHqn3janrGUHL1WBgwIRdYvDG6+cdbCCNaUVPmC1Nq0UO7aPGfPNyQMh2e9uL R8RoGEeaXXuQyTMrTRkxr2h3+D61zrjWiaYSh0OKOC7AuutAWjm8l6TY1I4HNeeJdL4E 562g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="lxPOd25/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4si1158238otk.172.2019.12.11.07.17.25; Wed, 11 Dec 2019 07:17:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="lxPOd25/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732011AbfLKPRY (ORCPT + 27 others); Wed, 11 Dec 2019 10:17:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:44762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730738AbfLKPRW (ORCPT ); Wed, 11 Dec 2019 10:17:22 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE09B24654; Wed, 11 Dec 2019 15:17:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077441; bh=xlTCbem2gi9LaqW/ch6R47FmwnGQF0tvIApcLDExZyQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lxPOd25/+ahkUEN58qla2iYxh+xScavTYeIi9KL13+JdyCECvvwGrvL/Z2qrU9UJw qYP1wK6W6sekTlgW0XNWI1K/pOHeLHhObCGXj9+mdlPNKJL1MfK9RdGFQl41/3797z lt3jBl6Vx0bm0+9/fhcMm++1RL0ZDuLhqeRVW7YU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Szyprowski , Chanwoo Choi , Sasha Levin Subject: [PATCH 4.19 041/243] extcon: max8997: Fix lack of path setting in USB device mode Date: Wed, 11 Dec 2019 16:03:23 +0100 Message-Id: <20191211150341.930414616@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150339.185439726@linuxfoundation.org> References: <20191211150339.185439726@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marek Szyprowski [ Upstream commit a2dc50914744eea9f83a70a5db0486be625e5dc0 ] MAX8997 driver disables automatic path selection from MicroUSB connector and manually sets path to either UART or USB lines. However the code for setting USB path worked only for USB host mode (when ID pin is set to ground). When standard USB cable (USB device mode) is connected, path registers are not touched. This means that once the non-USB accessory is connected to MAX8997-operated micro USB port, the path is no longer set to USB and USB device mode doesn't work. This patch fixes it by setting USB path both for USB and USB host modes. Signed-off-by: Marek Szyprowski Signed-off-by: Chanwoo Choi Signed-off-by: Sasha Levin --- drivers/extcon/extcon-max8997.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) -- 2.20.1 diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c index 9f30f4929b729..7a767b66dd865 100644 --- a/drivers/extcon/extcon-max8997.c +++ b/drivers/extcon/extcon-max8997.c @@ -321,12 +321,10 @@ static int max8997_muic_handle_usb(struct max8997_muic_info *info, { int ret = 0; - if (usb_type == MAX8997_USB_HOST) { - ret = max8997_muic_set_path(info, info->path_usb, attached); - if (ret < 0) { - dev_err(info->dev, "failed to update muic register\n"); - return ret; - } + ret = max8997_muic_set_path(info, info->path_usb, attached); + if (ret < 0) { + dev_err(info->dev, "failed to update muic register\n"); + return ret; } switch (usb_type) {