From patchwork Wed Dec 11 15:03:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 181236 Delivered-To: patch@linaro.org Received: by 2002:ac9:44c4:0:0:0:0:0 with SMTP id t4csp911988och; Wed, 11 Dec 2019 07:18:59 -0800 (PST) X-Google-Smtp-Source: APXvYqwyb2J3RdlXPYZ610ELKTqclP0nrBEBXXrFy9LbGYGFDnpH4oQyVRvilEDdup4cT4Z534ZL X-Received: by 2002:a05:6830:14c7:: with SMTP id t7mr2720224otq.72.1576077539094; Wed, 11 Dec 2019 07:18:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576077539; cv=none; d=google.com; s=arc-20160816; b=fjPBL5BwXDOpCrStY6oBb0+EOT1Y1MAfZtQYOKBq7lOCxtbRgKycStoSRkTO6cJkuP sICC5sSHfmAifPIw2LZ8aXqZqOhhoA2KzXEsBhBR9IU6vfuJYYPGLhAlbDyeCIyFGuw0 bgTksNTpXOnV5s/FNXxeQpDoG9X2Ma1IzAC7sQhUWH1AOae8acxKFlohgvJYAo3FUYEJ tZpITRcqKRZGsaFA0LlCcI8MrtoPHd4cYjfdRF/x6Y/cJgCemQBfsGbwJcQFJ4EW91U+ 4S0SdnwsRGLYDDrwAnMyemV+7zTXPpS0aMBwXeiGH2dcq9FFIcol9HS3NFP0bj0Npxgh WJqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+mfnqcl/BRaMBJ31XvXXSyKaJBXC8gQsTqFrN+w4PEc=; b=PZAMpY6qUTMWPP7zt6rSTBC0icyoJJ03wq8UlzoUndhdF6MdLB/QMt/L7FH/UI6AX9 V3Vp3O43Ki8zgVo23jCB5LLU9Dt7aeRRjux6C0ewchUUChHEgScHLPDBfCpHBSfOeVxB vTVVA2qTh+8K/XMnJ4VhMpoTgqBcP2BhvSs8X7YmoweD+h4wA5Dx29McwQEQNn9EWTll mdYXMbok7VhT8OS5t4nUBwRmeQsHYmKAWu5etrWUmIhCARx4GkHVftI7MM7AdXZxRI2u py1ZFeKZKvAPFeX1Uj3YfDFVGa84U6Hy3TgKykODOIlatnPpeJWJRy0gIKBqexYWTrSa M9CA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=b0KVAoL5; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x26si1283085oie.58.2019.12.11.07.18.58; Wed, 11 Dec 2019 07:18:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=b0KVAoL5; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730557AbfLKPS4 (ORCPT + 14 others); Wed, 11 Dec 2019 10:18:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:47258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732040AbfLKPSz (ORCPT ); Wed, 11 Dec 2019 10:18:55 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1062324654; Wed, 11 Dec 2019 15:18:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077534; bh=cZRXYZr3dnqdd2ZANv1oCOypDbcNrsP6ksZp+LUmUVU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b0KVAoL5cYDPuofzMR6XCplmEoxGCPrS9VW+mxaaPGae4z0DZpoIEFYRAD5T/w5co qqi8OAnppLKS5IZq8jR+l4Du7OpGuHfv5W8McKWcNjWBecPGW4VVKYKHof91bYlfJP 8RNRcozqyWOQGE1lX1DZhKH5q324KHOAkGjnRYf0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Cheng-Yi Chiang , Mark Brown , Douglas Anderson , Sasha Levin Subject: [PATCH 4.19 068/243] regulator: Fix return value of _set_load() stub Date: Wed, 11 Dec 2019 16:03:50 +0100 Message-Id: <20191211150343.689372303@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150339.185439726@linuxfoundation.org> References: <20191211150339.185439726@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Mark Brown [ Upstream commit f1abf67217de91f5cd3c757ae857632ca565099a ] The stub implementation of _set_load() returns a mode value which is within the bounds of valid return codes for success (the documentation just says that failures are negative error codes) but not sensible or what the actual implementation does. Fix it to just return 0. Reported-by: Cheng-Yi Chiang Signed-off-by: Mark Brown Reviewed-by: Douglas Anderson Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- include/linux/regulator/consumer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/include/linux/regulator/consumer.h b/include/linux/regulator/consumer.h index 25602afd48447..f3f76051e8b00 100644 --- a/include/linux/regulator/consumer.h +++ b/include/linux/regulator/consumer.h @@ -508,7 +508,7 @@ static inline int regulator_get_error_flags(struct regulator *regulator, static inline int regulator_set_load(struct regulator *regulator, int load_uA) { - return REGULATOR_MODE_NORMAL; + return 0; } static inline int regulator_allow_bypass(struct regulator *regulator,