From patchwork Thu Dec 12 01:42:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 181378 Delivered-To: patches@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp280417ile; Wed, 11 Dec 2019 17:42:43 -0800 (PST) X-Received: by 2002:a63:c250:: with SMTP id l16mr7457684pgg.38.1576114963150; Wed, 11 Dec 2019 17:42:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576114963; cv=none; d=google.com; s=arc-20160816; b=WjEUrlsZiHzPaaL1yYs/M+t0WPcx1kL1s3B9QRDQgdpfksyXvFNksy1ol4GpgP6lwZ /GHo+zNXLkrrhCQlq7h2Mkx6JM2BXkCriDqbgIJ7IOxy0woRF0feSX3q7Qn+I7oU8kA3 wsD66oZI0FLpd3XetXIJk4evyRDjLmbyd3FNYtVr7DD/Kn4W3qtKRXYVLuoMTZ9CPWjE SU5EiIAAtR3mmm8NGuDokuTTMEzs1XsTWE8F7HGk03bvlTW4QA3llPwfy2DOgH0a5wIW 2mq6mj8vDaQKFXxpd0/VHjQBJ4VOVuXYE60s/2piPoRkchHa7ObAVbW/1oHj/vSyzqPD CTzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lzv7sY1flH0+P+bTRde+D/HgFmOOUcTmct5WYnIY1iE=; b=vFhKshyJHAvaavHvX2rQIvpx/ohDUu7np9R1STpXVEgm2eJ85A52dVcF4ClEvw26Ey 3iRajj4/s5TwesV4wfuEGRkKysphucpKPT4Hn4kMQ37xgockMjbfwJHA+f1l/4wovNnU AIDPJdq9jLf0TCQo1VFLC9U6+uHSO3yzp+5dFnXYkAktwtQY02l0ANnoMK8SBwNsbdsO XStAgalDnlw9q9pVnkF+T4PQ+JgCHVqGu286WRIaveOZaufninywvS9acW1wE5S9xw7K pT7DwHZk+cR7/W5XtfKjhfFOhtTIYkUALOyXosIKkrYScgumLN7FcfzselWeRF1f6OHm mLvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="UZw/F1Ml"; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id 91sor4546273plc.12.2019.12.11.17.42.43 for (Google Transport Security); Wed, 11 Dec 2019 17:42:43 -0800 (PST) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="UZw/F1Ml"; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lzv7sY1flH0+P+bTRde+D/HgFmOOUcTmct5WYnIY1iE=; b=UZw/F1MlTuPlHpKe4kDgjY8F/v9Xiz+1gFoJAVS8UHhspGP2Fpw30FdQGna543kbZg NbdJ1yCDvKj06pyzxBU0LtWEiCOyPP2nEnN5BQp2LQPpQQh1psGtyt854LkbViLnC/lZ zz5LUJ5yIGZ2v/n8y29ac7682PdEVLzC0fdyMrtdayTHw7t725nH9/M9yyMuNfvE9asz LvvbKS5ncKH2sjpaV1y6oNpbpM55xotDt0IKntm3jKD+mR2Cbrs0sG1O55wRIIcJcdVc haJ/fBVgZw5PBDj5189st+r/ZpQMkoJcgE/UEqyhv/NtKX4ai4J9wrizbLIRKyjvs6vz 8YTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lzv7sY1flH0+P+bTRde+D/HgFmOOUcTmct5WYnIY1iE=; b=r721xurgcNW3tbcKFHhIYtmXFmrYdEy7HLko0/GfG6qwsTBi4JIMJwt6cXsL4qCL+s sQAQltoELbtVk1AT3mTjhDPoKvND8a4n+O755PEpKooLBEcTBQxOE2NS6JOEhI4cWrJW +AB3VZwrK60HJGoZGDAv32qyVPq0zQKtCXlZFb7nfJmOH3yRcNo/33vx/STJPCLNCLzk RmtuLgpMPBN5zcFPZ9Wiu0MxYby1Axe2fIVndPe5eOmyykwlRK53YHJbw4EB1eW7XrmW HmvwTcMEpGT2GW62c+ML5yliKskLQfmYzSoxjN6FA8Z5D3gS9ORMOtidALnkXoUevAue 31Fg== X-Gm-Message-State: APjAAAU4nlWDAahbtA0lh96FaCAIDpiFAIRYtAOT9N9PcX6mEaPDF/iU R4NSF4DFYTPW4rzXDiwstpWIxtK6 X-Google-Smtp-Source: APXvYqz1y2cw7lalEK+SC8etwGXhPJDXQAo5rWmg0AyCI1cAqs37h6s3jVRWoE17CI7K8C0/J8/9lQ== X-Received: by 2002:a17:902:43:: with SMTP id 61mr6924104pla.88.1576114962763; Wed, 11 Dec 2019 17:42:42 -0800 (PST) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id p16sm4217996pgi.50.2019.12.11.17.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 17:42:42 -0800 (PST) From: John Stultz To: lkml Cc: John Stultz , Greg Kroah-Hartman , Rob Herring , Mark Rutland , ShuFan Lee , Heikki Krogerus , Suzuki K Poulose , Chunfeng Yun , Yu Chen , Felipe Balbi , Hans de Goede , Andy Shevchenko , Jun Li , Valentin Schneider , Guillaume Gardet , Jack Pham , linux-usb@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v7 6/8] usb: dwc3: Rework resets initialization to be more flexible Date: Thu, 12 Dec 2019 01:42:31 +0000 Message-Id: <20191212014233.32799-7-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191212014233.32799-1-john.stultz@linaro.org> References: <20191212014233.32799-1-john.stultz@linaro.org> The dwc3 core binding specifies one reset. However some variants of the hardware may have more. Previously this was handled by using the dwc3-of-simple glue driver, but that resulted in a proliferation of bindings for for every variant, when the only difference was the clocks and resets lists. So this patch reworks the reading of the resets to fetch all the resets specified in the dts together. This patch was recommended by Rob Herring as an alternative to creating multiple bindings for each variant of hardware. Cc: Greg Kroah-Hartman Cc: Rob Herring Cc: Mark Rutland CC: ShuFan Lee Cc: Heikki Krogerus Cc: Suzuki K Poulose Cc: Chunfeng Yun Cc: Yu Chen Cc: Felipe Balbi Cc: Hans de Goede Cc: Andy Shevchenko Cc: Jun Li Cc: Valentin Schneider Cc: Guillaume Gardet Cc: Jack Pham Cc: linux-usb@vger.kernel.org Cc: devicetree@vger.kernel.org Suggested-by: Rob Herring Signed-off-by: John Stultz --- v3: Rework dwc3 core rather then adding another dwc-of-simple binding. v6: Re-introduce this patch, on Rob's suggestion --- drivers/usb/dwc3/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index c6316d4b7593..19504b907476 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1462,7 +1462,7 @@ static int dwc3_probe(struct platform_device *pdev) dwc3_get_properties(dwc); - dwc->reset = devm_reset_control_get_optional_shared(dev, NULL); + dwc->reset = devm_reset_control_array_get(dev, true, true); if (IS_ERR(dwc->reset)) return PTR_ERR(dwc->reset);