diff mbox series

[v3,5/5] MAINTAINERS: add entry for tidss

Message ID 09da3a37ca59bb45bef62f2335a191985363d393.1576158368.git.jsarha@ti.com
State Superseded
Headers show
Series drm/tidss: New driver for TI Keystone platform Display SubSystem | expand

Commit Message

Jyri Sarha Dec. 12, 2019, 1:52 p.m. UTC
Add entry for tidss DRM driver.

Version history:

v2: no change

v3: - Move tidss entry after omapdrm
    - Add "T:     git git://anongit.freedesktop.org/drm/drm-misc"

Signed-off-by: Jyri Sarha <jsarha@ti.com>

---
 MAINTAINERS | 11 +++++++++++
 1 file changed, 11 insertions(+)

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Comments

Daniel Vetter Dec. 13, 2019, 10:30 a.m. UTC | #1
On Thu, Dec 12, 2019 at 03:52:01PM +0200, Jyri Sarha wrote:
> Add entry for tidss DRM driver.

> 

> Version history:

> 

> v2: no change

> 

> v3: - Move tidss entry after omapdrm

>     - Add "T:     git git://anongit.freedesktop.org/drm/drm-misc"

> 

> Signed-off-by: Jyri Sarha <jsarha@ti.com>

> ---

>  MAINTAINERS | 11 +++++++++++

>  1 file changed, 11 insertions(+)

> 

> diff --git a/MAINTAINERS b/MAINTAINERS

> index 741e3f433f6e..e89fbfb1ce06 100644

> --- a/MAINTAINERS

> +++ b/MAINTAINERS

> @@ -5559,6 +5559,17 @@ S:	Maintained

>  F:	drivers/gpu/drm/omapdrm/

>  F:	Documentation/devicetree/bindings/display/ti/

>  

> +DRM DRIVERS FOR TI KEYSTONE

> +M:	Jyri Sarha <jsarha@ti.com>

> +M:	Tomi Valkeinen <tomi.valkeinen@ti.com>

> +L:	dri-devel@lists.freedesktop.org

> +S:	Maintained

> +F:	drivers/gpu/drm/tidss/

> +F:	Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml

> +F:	Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml

> +F:	Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml

> +T:	git git://anongit.freedesktop.org/drm/drm-misc


Is the plan to also move other TI drivers over (like tilcdc) or just an
experiment to see what happens? Asking since if eventually omapdrm moves
that might be a bit much (or at least needs a discussion first).
-Daniel

> +

>  DRM DRIVERS FOR V3D

>  M:	Eric Anholt <eric@anholt.net>

>  S:	Supported

> -- 

> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

> 

> _______________________________________________

> dri-devel mailing list

> dri-devel@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/dri-devel


-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Daniel Vetter Dec. 13, 2019, 8:15 p.m. UTC | #2
On Fri, Dec 13, 2019 at 01:17:59PM +0200, Tomi Valkeinen wrote:
> Hi Daniel,

> 

> On 13/12/2019 12:30, Daniel Vetter wrote:

> 

> > > +DRM DRIVERS FOR TI KEYSTONE

> > > +M:	Jyri Sarha <jsarha@ti.com>

> > > +M:	Tomi Valkeinen <tomi.valkeinen@ti.com>

> > > +L:	dri-devel@lists.freedesktop.org

> > > +S:	Maintained

> > > +F:	drivers/gpu/drm/tidss/

> > > +F:	Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml

> > > +F:	Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml

> > > +F:	Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml

> > > +T:	git git://anongit.freedesktop.org/drm/drm-misc

> > 

> > Is the plan to also move other TI drivers over (like tilcdc) or just an

> > experiment to see what happens? Asking since if eventually omapdrm moves

> > that might be a bit much (or at least needs a discussion first).

> 

> Hmm, yes, I think we should have a plan for these.

> 

> tilcdc: small, old driver, and I don't see much changes for it. The HW is

> very different from the ones supported by omapdrm and tidss (the two of

> which have many commonalities). I think drm-misc is fine for tilcdc.

> 

> omapdrm: big changes going on for now, but after the rewrite to get rid of

> omapdrm specific drivers is done, I expect the patch count to drop, as the

> HW is "legacy".

> 

> tidss: the "new" driver, which should get most attention in the future (after omapdrm rewrite).

> 

> All in all, sometimes there have been very few patches for many months, and

> then sometimes there's a big series.


Yeah occasionally big series is totally fine for -misc. We're pulling in
pretty big amounts of refactoring all the time, so really doesn't make a
difference.

> I haven't seen a need to have a maintained branch for omapdrm, as multiple

> people working on conflicting items has been very rare (there aren't that

> many people working on omapdrm). So I've picked patches to my private

> branch, which I have rebased as needed. And then I've either pushed via

> drm-misc if there's just a few patches, or sent a pull request if there's a

> lot.

> 

> Is such a mixed model ok?

> 

> I'm not sure how much is too much for drm-misc, but probably omapdrm and

> tidss combined (if pushing everything always via drm-misc) is a bit too

> much. So perhaps a maintained TI tree would be an option too, and pushing

> everything for omapdrm and tidss via that tree.


tbh I dunno either when too much is too much for -misc. I think tilcdc and
omapdrm should both easily fit (maybe after the big rewrite). If the shiny
new one here becomes too big we can always reconsider.

I think the really big drivers like amdgpu or intel don't belong in -misc,
that one is clear. In between I guess we'll see.

> I'm fine with all options, so I think we can go with whatever is most

> acceptable from DRM maintainer point of view.


Whatever floats the boat, with a preference for not having tiny trees
(simply because those pull request tend to get lost in the noise).
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 741e3f433f6e..e89fbfb1ce06 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5559,6 +5559,17 @@  S:	Maintained
 F:	drivers/gpu/drm/omapdrm/
 F:	Documentation/devicetree/bindings/display/ti/
 
+DRM DRIVERS FOR TI KEYSTONE
+M:	Jyri Sarha <jsarha@ti.com>
+M:	Tomi Valkeinen <tomi.valkeinen@ti.com>
+L:	dri-devel@lists.freedesktop.org
+S:	Maintained
+F:	drivers/gpu/drm/tidss/
+F:	Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml
+F:	Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
+F:	Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml
+T:	git git://anongit.freedesktop.org/drm/drm-misc
+
 DRM DRIVERS FOR V3D
 M:	Eric Anholt <eric@anholt.net>
 S:	Supported