ARM: dts: imx6qdl: Enable egalax touch screen

Message ID 20191212160220.2265521-1-sjoerd.simons@collabora.co.uk
State New
Headers show
Series
  • ARM: dts: imx6qdl: Enable egalax touch screen
Related show

Commit Message

Sjoerd Simons Dec. 12, 2019, 4:02 p.m.
Sabrelite boards can have an lvds screen attached with a built-in i2c touch
screen. Enable this in the dtsi.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

---

 arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
2.24.0

Comments

Marco Felsch Dec. 12, 2019, 4:07 p.m. | #1
Hi Sjoerd,

On 19-12-12 17:02, Sjoerd Simons wrote:
> Sabrelite boards can have an lvds screen attached with a built-in i2c touch

> screen. Enable this in the dtsi.


Can this be any screen available on the market?

> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

> ---

> 

>  arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 8 ++++++++

>  1 file changed, 8 insertions(+)

> 

> diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi

> index 8468216dae9b..382b127b2251 100644

> --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi

> +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi

> @@ -416,6 +416,14 @@ &i2c3 {

>  	pinctrl-names = "default";

>  	pinctrl-0 = <&pinctrl_i2c3>;

>  	status = "okay";

> +

> +	touchscreen@4 {

> +		compatible = "eeti,egalax_ts";

> +		reg = <0x04>;

> +		interrupt-parent = <&gpio1>;

> +		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;

> +		wakeup-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;


The wakeup-gpio and the irq-line are sharing the same gpio line?

Regards,
  Marco 

> +	};

>  };

>  

>  &iomuxc {

> -- 

> 2.24.0

> 

> 

> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
Sjoerd Simons Dec. 12, 2019, 4:22 p.m. | #2
On Thu, 2019-12-12 at 17:07 +0100, Marco Felsch wrote:
> Hi Sjoerd,

> 

> On 19-12-12 17:02, Sjoerd Simons wrote:

> > Sabrelite boards can have an lvds screen attached with a built-in

> > i2c touch

> > screen. Enable this in the dtsi.

> 

> Can this be any screen available on the market?


I guess i should have been more clear here; This is the touchscreen in
the hannstar display (already part of the dts) that was sold as an
accessoiry to the sabrelite.

Same as the screen that can be used on the boundary nitrogen6 boards
(which do have the touch part already enabled in the dts)

> 

> > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

> > ---

> > 

> >  arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 8 ++++++++

> >  1 file changed, 8 insertions(+)

> > 

> > diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi

> > b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi

> > index 8468216dae9b..382b127b2251 100644

> > --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi

> > +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi

> > @@ -416,6 +416,14 @@ &i2c3 {

> >  	pinctrl-names = "default";

> >  	pinctrl-0 = <&pinctrl_i2c3>;

> >  	status = "okay";

> > +

> > +	touchscreen@4 {

> > +		compatible = "eeti,egalax_ts";

> > +		reg = <0x04>;

> > +		interrupt-parent = <&gpio1>;

> > +		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;

> > +		wakeup-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;

> 

> The wakeup-gpio and the irq-line are sharing the same gpio line?

> 

> Regards,

>   Marco 

> 

> > +	};

> >  };

> >  

> >  &iomuxc {

> > -- 

> > 2.24.0

> > 

> > 

> > 

-- 
Sjoerd Simons
Collabora Ltd.
Marco Felsch Dec. 12, 2019, 4:23 p.m. | #3
On 19-12-12 17:07, Marco Felsch wrote:
> Hi Sjoerd,

> 

> On 19-12-12 17:02, Sjoerd Simons wrote:

> > Sabrelite boards can have an lvds screen attached with a built-in i2c touch

> > screen. Enable this in the dtsi.

> 

> Can this be any screen available on the market?


At least you should adapt the title to: "ARM: dts: imx6qdl-sabrelite: ..."

Regards,
  Marco


> 

> > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

> > ---

> > 

> >  arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 8 ++++++++

> >  1 file changed, 8 insertions(+)

> > 

> > diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi

> > index 8468216dae9b..382b127b2251 100644

> > --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi

> > +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi

> > @@ -416,6 +416,14 @@ &i2c3 {

> >  	pinctrl-names = "default";

> >  	pinctrl-0 = <&pinctrl_i2c3>;

> >  	status = "okay";

> > +

> > +	touchscreen@4 {

> > +		compatible = "eeti,egalax_ts";

> > +		reg = <0x04>;

> > +		interrupt-parent = <&gpio1>;

> > +		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;

> > +		wakeup-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;

> 

> The wakeup-gpio and the irq-line are sharing the same gpio line?

> 

> Regards,

>   Marco 

> 

> > +	};

> >  };

> >  

> >  &iomuxc {

> > -- 

> > 2.24.0

> > 

> > 

> > 

> 

> -- 

> Pengutronix e.K.                           |                             |

> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |

> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |

> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

> 

> _______________________________________________

> linux-arm-kernel mailing list

> linux-arm-kernel@lists.infradead.org

> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
Sjoerd Simons Dec. 13, 2019, 9:03 a.m. | #4
On Thu, 2019-12-12 at 17:25 +0100, Marco Felsch wrote:
> On 19-12-12 17:22, Sjoerd Simons wrote:

> > On Thu, 2019-12-12 at 17:07 +0100, Marco Felsch wrote:

> > > Hi Sjoerd,

> > > 

> > > On 19-12-12 17:02, Sjoerd Simons wrote:

> > > > Sabrelite boards can have an lvds screen attached with a built-

> > > > in

> > > > i2c touch

> > > > screen. Enable this in the dtsi.

> > > 

> > > Can this be any screen available on the market?

> > 

> > I guess i should have been more clear here; This is the touchscreen

> > in

> > the hannstar display (already part of the dts) that was sold as an

> > accessoiry to the sabrelite.

> 

> That is more clear =) Pls can you add this to the commit message?


Ofcourse will do; You also made me dig up the model number etc so i'll
include that information.

> > Same as the screen that can be used on the boundary nitrogen6

> > boards

> > (which do have the touch part already enabled in the dts)

> > 

> > > > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

> > > > ---

> > > > 

> > > >  arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 8 ++++++++

> > > >  1 file changed, 8 insertions(+)

> > > > 

> > > > diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi

> > > > b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi

> > > > index 8468216dae9b..382b127b2251 100644

> > > > --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi

> > > > +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi

> > > > @@ -416,6 +416,14 @@ &i2c3 {

> > > >  	pinctrl-names = "default";

> > > >  	pinctrl-0 = <&pinctrl_i2c3>;

> > > >  	status = "okay";

> > > > +

> > > > +	touchscreen@4 {

> > > > +		compatible = "eeti,egalax_ts";

> > > > +		reg = <0x04>;

> > > > +		interrupt-parent = <&gpio1>;

> > > > +		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;

> > > > +		wakeup-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;

> > > 

> > > The wakeup-gpio and the irq-line are sharing the same gpio line?

> 

> Lastly should we add a own pinctrl entry for the touchscreen?


Would probably make sense to do that indeed; Will have a look

Thanks for the review!

-- 
Sjoerd Simons
Collabora Ltd.

Patch

diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
index 8468216dae9b..382b127b2251 100644
--- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
@@ -416,6 +416,14 @@  &i2c3 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_i2c3>;
 	status = "okay";
+
+	touchscreen@4 {
+		compatible = "eeti,egalax_ts";
+		reg = <0x04>;
+		interrupt-parent = <&gpio1>;
+		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
+		wakeup-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
+	};
 };
 
 &iomuxc {