[net,v2] net: dsa: ocelot: add NET_VENDOR_MICROSEMI dependency

Message ID 20191215221214.15337-1-olteanv@gmail.com
State New
Headers show
Series
  • [net,v2] net: dsa: ocelot: add NET_VENDOR_MICROSEMI dependency
Related show

Commit Message

Vladimir Oltean Dec. 15, 2019, 10:12 p.m.
From: Arnd Bergmann <arnd@arndb.de>


Selecting MSCC_OCELOT_SWITCH is not possible when NET_VENDOR_MICROSEMI
is disabled:

WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
  Depends on [n]: NETDEVICES [=y] && ETHERNET [=n] && NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]
  Selected by [m]:
  - NET_DSA_MSCC_FELIX [=m] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && NET_DSA [=y] && PCI [=y]

Add a Kconfig dependency on NET_VENDOR_MICROSEMI, which also implies
CONFIG_NETDEVICES.

Depending on a vendor config violates menuconfig locality for the DSA
driver, but is the smallest compromise since all other solutions are
much more complicated (see [0]).

https://www.spinics.net/lists/netdev/msg618808.html

Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Signed-off-by: Mao Wenan <maowenan@huawei.com>

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

---
Changes in v2:
- Back to Arnd's and Mao's original proposal. The final straw to the
  much more complicated approach in the v1 linked above is the need to
  do this in drivers/net/ethernet/Makefile:

  -obj-$(CONFIG_NET_VENDOR_MICROSEMI) += mscc/
  +obj-y += mscc/

 drivers/net/dsa/ocelot/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.1

Comments

David Miller Dec. 17, 2019, 3:24 a.m. | #1
From: Vladimir Oltean <olteanv@gmail.com>

Date: Mon, 16 Dec 2019 00:12:14 +0200

> From: Arnd Bergmann <arnd@arndb.de>

> 

> Selecting MSCC_OCELOT_SWITCH is not possible when NET_VENDOR_MICROSEMI

> is disabled:

> 

> WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH

>   Depends on [n]: NETDEVICES [=y] && ETHERNET [=n] && NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]

>   Selected by [m]:

>   - NET_DSA_MSCC_FELIX [=m] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && NET_DSA [=y] && PCI [=y]

> 

> Add a Kconfig dependency on NET_VENDOR_MICROSEMI, which also implies

> CONFIG_NETDEVICES.

> 

> Depending on a vendor config violates menuconfig locality for the DSA

> driver, but is the smallest compromise since all other solutions are

> much more complicated (see [0]).

> 

> https://www.spinics.net/lists/netdev/msg618808.html

> 

> Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> Signed-off-by: Mao Wenan <maowenan@huawei.com>

> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>


Applied.

Patch

diff --git a/drivers/net/dsa/ocelot/Kconfig b/drivers/net/dsa/ocelot/Kconfig
index 0031ca814346..6f9804093150 100644
--- a/drivers/net/dsa/ocelot/Kconfig
+++ b/drivers/net/dsa/ocelot/Kconfig
@@ -2,6 +2,7 @@ 
 config NET_DSA_MSCC_FELIX
 	tristate "Ocelot / Felix Ethernet switch support"
 	depends on NET_DSA && PCI
+	depends on NET_VENDOR_MICROSEMI
 	select MSCC_OCELOT_SWITCH
 	select NET_DSA_TAG_OCELOT
 	help