From patchwork Mon Dec 16 17:47:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 181767 Delivered-To: patch@linaro.org Received: by 2002:ac9:44c4:0:0:0:0:0 with SMTP id t4csp4626325och; Mon, 16 Dec 2019 10:01:46 -0800 (PST) X-Google-Smtp-Source: APXvYqxEKSrxefo+R54uU0EXHGvw339I0HUKlpKU71vvm78RB/hzGru/o2ODhiZCrIDFP5RgzmE2 X-Received: by 2002:a9d:6395:: with SMTP id w21mr33621246otk.3.1576519306567; Mon, 16 Dec 2019 10:01:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576519306; cv=none; d=google.com; s=arc-20160816; b=1J1YL3Ay/qI9y3HQU1YEh+1IR7NtD1/A+uumxgnNzubyDpKRd3o5104t+CiUGvEpa6 IIe6sHr7d5XXdJauq2xwmLw5UlCtkhbLEFd3eI0cbsIqI6R91RO1FJPvaeFu3L1cyclJ GJFS2tp87EN1RcEbi6pxtI8RW96QOhYBqjKhcg63fS9Hi2toGBti/8b5vnyfHQgYcBG4 BS3uQ58TDaXpFu01nAhuojMyHiGSLYDdX2BpD6aZkXp6w5XNnL5E5KOsEY2DvMl/fIy2 SvnNbLCcOD/TBLonoRRHLEXPq6lDc8ObM7GQeR1EfjyXX06n7FB1VxTDEL7ZWTw29r9c LcRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=A1qqx/S8GigOFQ8e6DE67CGYvd+zQqG2M8u3xISUVOs=; b=XoGOeMkY2zuRaI4GYkFptfuLgdS0ngRd8r3SyofcTcqSpnaYjNNb0hi/LMYHCGWgbx a8UuAXvcQCGq3CJFeQQG+RqEPSFXyXFLrIcLo/u0yeJ4FsDJFLHViuspVEPZoRKetoyS BMZTf60cKeqS+myXRHXYqkNgnuXo+6MxvOMND9f9gLhBQ/M3DXN0BLWA3XABHi9Ho+EN NoKibUKezQTMpwFP5Sgsd1BxP/Py798oGkely6D3IAE8f+0kTnOn1wMlSpRYtJvuDGv0 gXwS1LHi0eMtRNFfLFGYdf0RVrLAJi3QpK40B9atrjnc4jjzR5GvOQiDEEAaG2htcn6M izrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u5oMoTS4; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l17si10335738otk.218.2019.12.16.10.01.46; Mon, 16 Dec 2019 10:01:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u5oMoTS4; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728778AbfLPSBo (ORCPT + 14 others); Mon, 16 Dec 2019 13:01:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:37006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727711AbfLPSBo (ORCPT ); Mon, 16 Dec 2019 13:01:44 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84AE720726; Mon, 16 Dec 2019 18:01:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519304; bh=9Tb278d/ILZNVN+LrmogSNBrZri5snOMsvfwNybxyBM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u5oMoTS4UfAFdQQOTPUqKk4ii4FvPSsPMucHzPscLbzSMkkhF4eWHUFYI/VQunmnV VMkXFOEqQvWdLHKlbKZm2Josx97oyoIEonoG4OKNLQvRPAPQlWwVeVNu+FnBrp9u6Z 5W6IvMC3i28iCfzIx74j49yWy28t/Yv37GtH4fBk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Stanimir Varbanov , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 4.19 004/140] media: venus: remove invalid compat_ioctl32 handler Date: Mon, 16 Dec 2019 18:47:52 +0100 Message-Id: <20191216174748.998709817@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174747.111154704@linuxfoundation.org> References: <20191216174747.111154704@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann commit 4adc0423de92cf850d1ef5c0e7cb28fd7a38219e upstream. v4l2_compat_ioctl32() is the function that calls into v4l2_file_operations->compat_ioctl32(), so setting that back to the same function leads to a trivial endless loop, followed by a kernel stack overrun. Remove the incorrect assignment. Cc: stable@vger.kernel.org Fixes: 7472c1c69138 ("[media] media: venus: vdec: add video decoder files") Fixes: aaaa93eda64b ("[media] media: venus: venc: add video encoder files") Signed-off-by: Arnd Bergmann Acked-by: Stanimir Varbanov Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/qcom/venus/vdec.c | 3 --- drivers/media/platform/qcom/venus/venc.c | 3 --- 2 files changed, 6 deletions(-) --- a/drivers/media/platform/qcom/venus/vdec.c +++ b/drivers/media/platform/qcom/venus/vdec.c @@ -1115,9 +1115,6 @@ static const struct v4l2_file_operations .unlocked_ioctl = video_ioctl2, .poll = v4l2_m2m_fop_poll, .mmap = v4l2_m2m_fop_mmap, -#ifdef CONFIG_COMPAT - .compat_ioctl32 = v4l2_compat_ioctl32, -#endif }; static int vdec_probe(struct platform_device *pdev) --- a/drivers/media/platform/qcom/venus/venc.c +++ b/drivers/media/platform/qcom/venus/venc.c @@ -1220,9 +1220,6 @@ static const struct v4l2_file_operations .unlocked_ioctl = video_ioctl2, .poll = v4l2_m2m_fop_poll, .mmap = v4l2_m2m_fop_mmap, -#ifdef CONFIG_COMPAT - .compat_ioctl32 = v4l2_compat_ioctl32, -#endif }; static int venc_probe(struct platform_device *pdev)