From patchwork Mon Dec 16 17:47:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 181771 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp4654503ile; Mon, 16 Dec 2019 10:08:10 -0800 (PST) X-Google-Smtp-Source: APXvYqxnz9gh6anUtRkqmwxuI9LBRhjQdpBBUv9stWYdVNsgW+0iAn8hFovD1CYS4T2C+UsHuNf8 X-Received: by 2002:a9d:6c8:: with SMTP id 66mr33068078otx.271.1576519690230; Mon, 16 Dec 2019 10:08:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576519690; cv=none; d=google.com; s=arc-20160816; b=xCIfbxe2Ib0vEP1/MFyAViNh4ynr7sc9y7Qyd4mQhNqZQHMEikgZMo05TMc/bXi3kD OwNHfkKqwfpNhVXKuYbwNfnaPar/j4pJc9Ac7JYNZSqucqX+rv+UATMD+OcNmUA5IrpS F9NYyv0suEv7bms3vwUYnAZ59EOLRtPC3lyy2wg5q9RK8a46KiHAOeN2Ujjf4IyJ96A8 OTt8QPSA1jxczKsLdLLZocoRbPEZV5Nv82VvhVAGF9mOyno9DCN85jxP7h+Chyv7DVby UgbykdSi0+AuDFbl30RDz3uEjLHDH9BFITXB9kD+PILfr34VFreazUx6RbODNY2oPQvI ORkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Kb7rH2jug0lJk5VBj2BKHczTmQHPT98dsyA+HXVLtRQ=; b=uU6zR7hOomyQ7rFyAzrx5mkMAJFlraQmRV/XYNI96svJ1MCiz8QY8i+nPTQVkKDm3A IsuFwuzYYTf/+YciKsg+tRZnJkwtmt4OLsHgFQMscxUkaIDzx2ia6oP6whMb1k591rus YGmZAD/bsX9yErLYnY3iA3nrxgI+CJpOuXEaGtcTYaGV9qi6TnREi8JEhewrSRm4tBdV ooiEeLZdxvvG8kCsODyJ3VLAZpfu8P+K0rZQ5zGFDTb1gFPfnQ8Dl6S+eQClJfGTT4aK yBC10aMmaGmxUW9U2uZ+SRuNmMagDmTltIT7YgpeeW/Ou+NO1+5crAMd791dz1zkXE5E KRKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=G3LoYbvu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3si10724619oir.132.2019.12.16.10.08.10; Mon, 16 Dec 2019 10:08:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=G3LoYbvu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730092AbfLPSIJ (ORCPT + 27 others); Mon, 16 Dec 2019 13:08:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:49396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730219AbfLPSIE (ORCPT ); Mon, 16 Dec 2019 13:08:04 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 998A6206E0; Mon, 16 Dec 2019 18:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519684; bh=zlK8phi/sh4xEBUruI/ErgInYWuipq1OWubLY7IOSrQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G3LoYbvuzQQx2huoThAwzmBK0rx+aFEElIO5OFy7ybvKYECwJeyl+k+kYVbgsolO6 LctwF3PpmQSzIw/Fr7m/y096Xra+JUK7wK61XyWk9dzxZ4vWq7uNRx96UTmsmVoLXA aFyhlBnb1vk+B9ZqKebw3Oizr6qVl9Cs+LpCMp84= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dmitry Osipenko , Bjorn Andersson , Georgi Djakov Subject: [PATCH 5.3 026/180] interconnect: qcom: sdm845: Walk the list safely on node removal Date: Mon, 16 Dec 2019 18:47:46 +0100 Message-Id: <20191216174811.685771041@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174806.018988360@linuxfoundation.org> References: <20191216174806.018988360@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Georgi Djakov commit b29b8113bb41285eb7ed55ce0c65017b5c0240f7 upstream. As we will remove items off the list using list_del(), we need to use the safe version of list_for_each_entry(). Fixes: b5d2f741077a ("interconnect: qcom: Add sdm845 interconnect provider driver") Reported-by: Dmitry Osipenko Reviewed-by: Bjorn Andersson Signed-off-by: Georgi Djakov Cc: # v5.3+ Link: https://lore.kernel.org/r/20191212075332.16202-3-georgi.djakov@linaro.org Signed-off-by: Greg Kroah-Hartman --- drivers/interconnect/qcom/sdm845.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/interconnect/qcom/sdm845.c +++ b/drivers/interconnect/qcom/sdm845.c @@ -807,9 +807,9 @@ static int qnoc_remove(struct platform_d { struct qcom_icc_provider *qp = platform_get_drvdata(pdev); struct icc_provider *provider = &qp->provider; - struct icc_node *n; + struct icc_node *n, *tmp; - list_for_each_entry(n, &provider->nodes, node_list) { + list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) { icc_node_del(n); icc_node_destroy(n->id); }