From patchwork Mon Dec 16 19:48:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 181796 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp4773399ile; Mon, 16 Dec 2019 11:49:33 -0800 (PST) X-Google-Smtp-Source: APXvYqy/ic4OH5s4UbGlA8G+3trseP1YQoee2jx2bEr3T43wIZCPT8aHFeSrMfIWmhvT6wi2zGg6 X-Received: by 2002:a05:6830:681:: with SMTP id q1mr33783027otr.162.1576525773154; Mon, 16 Dec 2019 11:49:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576525773; cv=none; d=google.com; s=arc-20160816; b=QP8nZrMQq3btdtvJyqBsttZs9AcsiecPIrQgfxPiUc5icz+fWmkCsXc5IDbsiBE77v 8YBwKgzeOrBd75vmIlS5c9aavKSNeMi53CDukBFctxQ0seCksmddif2KWRWeh0dPpFjb fHHEiK9X1lYq78XWj8PUjH+DX61yittpJb76n9wPE24PI8mZ0t6vrukCHYNYry8zTGWk I+ff5FDSzoL5PuANEQ14IJHHubdxwik+kYLqW5h2D9eS6z5OFHLzYruxfLAodCtaMZ0Z ROwyOTuoLJcYwy8SCmxv33FzS8dBRKzUhk2IDlPNjZvnerjKm+FM+jch4sgb+C2c1SUQ rAbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=soV254XN3f/Xrv8wkVM/W/BBTTUTRXj9bA4JcGtiFRc=; b=aETKyndrccvbzxbrAPXCjBHe2iORbGYwXL03Ru2p7p+FrXqyZDeMVIv9gGL08mzLjf AyQn47eBFxMHZ8wH+gnMfy0dK3KMFoGd42+xqoRU45EPQsnxvkjHlvCQQk7dfGctg5yk i+68oI9Uylp736cgG4gOXk0DuKHFhVzuR+7Ng+4ilDAf0q31BoExI8rcDAxzWippzJel XQO7afp/UbGfYTfCNOVQfCWWg3MIsSrxHDjWzUzTTVLb3574B29P07yHiBza+PmvmB1J yDD4RV0ZTUQFAfmtLAS/YYZaOJkW8m7+XddD0emsw4qtmfD7X0mullk3tPd1n0QO1wuH iveQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w6si11549369oti.4.2019.12.16.11.49.32; Mon, 16 Dec 2019 11:49:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727417AbfLPTtb (ORCPT + 27 others); Mon, 16 Dec 2019 14:49:31 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:39581 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbfLPTtb (ORCPT ); Mon, 16 Dec 2019 14:49:31 -0500 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPA (Nemesis) id 1MbizQ-1i88iB1KcI-00dHi0; Mon, 16 Dec 2019 20:49:17 +0100 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Arnd Bergmann , kbuild test robot , "kernelci . org bot" , Olof's autobuilder , Stephen Rothwell , Karsten Keil , David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [staging-next] isdn: don't mark kcapi_proc_exit as __exit Date: Mon, 16 Dec 2019 20:48:56 +0100 Message-Id: <20191216194909.1983639-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:AwV4AqFxQtvHHuFtYDOmzzpO+UtCki+y5x1+qgMNBZ3auzo2P61 n80SihI9jUKtxW5+SH3BB2WX3IVdpMMeQLYNiFo+cpJnIanhLyr/UUNTUjAOxhZdyOM57xs 2OyNoVoDoxuP0/ywztpVoUdOXkzctQYvXqIwcAz7eXKrvf+B5R9qh7PfewFlnh3aMZ158mx XBMK8B6dod8uxR+8xzSww== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:FBvOzmlMejA=:CS+zCmdx1cBPOe0WA3ynhW 35fNy4EIZ+Qxn9p3JHIaj9ZisVTYicDewM210gJ9I2Lc3ArteeK6yZOPc9k4ZzXwh9sITe4fU snKAt7jOmXKjRudzFIREHcUMUyrxpsmhWasDKe2a9qIlP/XtxffaEVMdFH1aawxQjiQZxwult YGSyq0SOI1P+QERdhsbnRcgDm/TaIKeEljuC6cd4jgLfHnWsmpjDt8HTdLpNFWY2amZSB0LYY axItxzXaNW9hxjdo+seBWoBjhne8HHzlZ5aMRo1Mt1IlGlnszzhygh9KtEyi4QdT7YLaL68GH WCeUOfLlmgry/NMvjcyH/cE9PyDOTpfouED4JM/gjrao1WFHlXkTmRdL5+cZlcotIS/kB7MmU N9pw2kDrUNiDL3a40eF2baLf7umo1e5XGAV774QRff3TkjY85NyqJugvcnPS/L06zAuryODlG 0NL4kxWHTR7dsDrFmZ7MWOX5AbHDmFmGQBMPlIUikjSIiqAvPghnMCZwtJsf7KRLsHA6fkxgJ XBacbJ7y3sJleG2Ot1im/oN1pL7PkHJXMQNhqbVMmFSLZW6HnExTDUQ40D5/3eijY82wyy51E SLi4+wd8xdp92EURVhO34+bQqhe4U85bas/GhjiHHoauktpGKu84Foo+DKGRgs8oNTm52sKDb I3iOGYuuAlnsjLtezMsLiA6aw7p1yGIbdOqdKOd2WEmXveCvKFsz/Nvk8X5MBX9Eji2RacdtY ULm1mYC4fNtwNkaGoQkiL8eDUmN772K3Di4BL1L8XLb2KtWyniYEizknZyNf5oMyaSokASDaJ CdOjctYoP+CS4ywMKk+qT1HVEQdHymDLcL6N39Uf20EBzQ0bwb04s+M/JWbKMhhlge4IC6Csl pmG3TiNiVz3RbuDO1nPg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As everybody pointed out by now, my patch to clean up CAPI introduced a link time warning, as the two parts of the capi driver are now in one module and the exit function may need to be called in the error path of the init function: >> WARNING: drivers/isdn/capi/kernelcapi.o(.text+0xea4): Section mismatch in reference from the function kcapi_exit() to the function .exit.text:kcapi_proc_exit() The function kcapi_exit() references a function in an exit section. Often the function kcapi_proc_exit() has valid usage outside the exit section and the fix is to remove the __exit annotation of kcapi_proc_exit. Remove the incorrect __exit annotation. Reported-by: kbuild test robot Reported-by: kernelci.org bot Reported-by: Olof's autobuilder Reported-by: Stephen Rothwell Signed-off-by: Arnd Bergmann --- drivers/isdn/capi/kcapi_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 diff --git a/drivers/isdn/capi/kcapi_proc.c b/drivers/isdn/capi/kcapi_proc.c index 2bffbb8bf271..eadbe59b3753 100644 --- a/drivers/isdn/capi/kcapi_proc.c +++ b/drivers/isdn/capi/kcapi_proc.c @@ -217,7 +217,7 @@ kcapi_proc_init(void) proc_create("capi/driver", 0, NULL, &empty_fops); } -void __exit +void kcapi_proc_exit(void) { remove_proc_entry("capi/driver", NULL);