[net] of: mdio: mark stub of_mdiobus_child_is_phy as inline

Message ID 20191223132443.115540-1-Jason@zx2c4.com
State New
Headers show
Series
  • [net] of: mdio: mark stub of_mdiobus_child_is_phy as inline
Related show

Commit Message

Jason A. Donenfeld Dec. 23, 2019, 1:24 p.m.
The of_mdiobus_child_is_phy function was recently exported, with a stub
fallback added to simply return false as a static function. The inline
specifier was left out, leading to build time errors:

In file included from linux/include/linux/fs_enet_pd.h:21,
                 from linux/arch/powerpc/sysdev/fsl_soc.c:26:
linux/include/linux/of_mdio.h:58:13: error: ‘of_mdiobus_child_is_phy’ defined but not used [-Werror=unused-function]
   58 | static bool of_mdiobus_child_is_phy(struct device_node *child)
      |             ^~~~~~~~~~

This commit simply adds the missing inline keyboard.

Fixes: 0aa4d016c043 ("of: mdio: export of_mdiobus_child_is_phy")
Cc: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

---
 include/linux/of_mdio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.24.1

Comments

Andrew Lunn Dec. 23, 2019, 3:24 p.m. | #1
On Mon, Dec 23, 2019 at 02:24:43PM +0100, Jason A. Donenfeld wrote:
> The of_mdiobus_child_is_phy function was recently exported, with a stub

> fallback added to simply return false as a static function. The inline

> specifier was left out, leading to build time errors:

> 

> In file included from linux/include/linux/fs_enet_pd.h:21,

>                  from linux/arch/powerpc/sysdev/fsl_soc.c:26:

> linux/include/linux/of_mdio.h:58:13: error: ‘of_mdiobus_child_is_phy’ defined but not used [-Werror=unused-function]

>    58 | static bool of_mdiobus_child_is_phy(struct device_node *child)

>       |             ^~~~~~~~~~

> 

> This commit simply adds the missing inline keyboard.


Hi Jason

It is a good idea to search the netdev list before fixing things like
this:

https://lkml.org/lkml/2019/12/23/128

	Andrew

Patch

diff --git a/include/linux/of_mdio.h b/include/linux/of_mdio.h
index 79bc82e30c02..491a2b7e77c1 100644
--- a/include/linux/of_mdio.h
+++ b/include/linux/of_mdio.h
@@ -55,7 +55,7 @@  static inline int of_mdio_parse_addr(struct device *dev,
 }
 
 #else /* CONFIG_OF_MDIO */
-static bool of_mdiobus_child_is_phy(struct device_node *child)
+static inline bool of_mdiobus_child_is_phy(struct device_node *child)
 {
 	return false;
 }