diff mbox series

[v3,07/29] linux-user: Include tcg.h in syscall.c

Message ID 20191228231124.18307-8-richard.henderson@linaro.org
State Accepted
Commit 4c2169b2670cba1760cd03c8ff04b9d886d6f468
Headers show
Series cputlb: Remove support for MMU_MODE*_SUFFIX | expand

Commit Message

Richard Henderson Dec. 28, 2019, 11:11 p.m. UTC
Code movement in an upcoming patch will show that this file
was implicitly depending on tcg.h being included indirectly.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 linux-user/syscall.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.1

Comments

Philippe Mathieu-Daudé Dec. 29, 2019, 11:31 p.m. UTC | #1
On 12/29/19 12:11 AM, Richard Henderson wrote:
> Code movement in an upcoming patch will show that this file

> was implicitly depending on tcg.h being included indirectly.


Yes, it uses tcg_register_thread().

> 

> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>   linux-user/syscall.c | 1 +

>   1 file changed, 1 insertion(+)

> 

> diff --git a/linux-user/syscall.c b/linux-user/syscall.c

> index 171c0caef3..34825f15bf 100644

> --- a/linux-user/syscall.c

> +++ b/linux-user/syscall.c

> @@ -115,6 +115,7 @@

>   #include "user/syscall-trace.h"

>   #include "qapi/error.h"

>   #include "fd-trans.h"

> +#include "tcg.h"


Since tcg origin (57fec1fee94) we use -I$(SRC_PATH)/tcg.

$ git grep -F '#include "tcg.h"'|wc -l
16
$ git grep -F '#include "tcg/tcg.h"'|wc -l
19

IMO using "tcg/tcg.h" is cleaner.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


>   

>   #ifndef CLONE_IO

>   #define CLONE_IO                0x80000000      /* Clone io context */

>
diff mbox series

Patch

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 171c0caef3..34825f15bf 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -115,6 +115,7 @@ 
 #include "user/syscall-trace.h"
 #include "qapi/error.h"
 #include "fd-trans.h"
+#include "tcg.h"
 
 #ifndef CLONE_IO
 #define CLONE_IO                0x80000000      /* Clone io context */