[v3,08/29] linux-user: Include trace-root.h in syscall-trace.h

Message ID 20191228231124.18307-9-richard.henderson@linaro.org
State New
Headers show
Series
  • cputlb: Remove support for MMU_MODE*_SUFFIX
Related show

Commit Message

Richard Henderson Dec. 28, 2019, 11:11 p.m.
Code movement in an upcoming patch will show that this file
was implicitly depending on trace-root.h being included beforehand.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 include/user/syscall-trace.h | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.20.1

Comments

Philippe Mathieu-Daudé Dec. 29, 2019, 11:52 p.m. | #1
On 12/29/19 12:11 AM, Richard Henderson wrote:
> Code movement in an upcoming patch will show that this file

> was implicitly depending on trace-root.h being included beforehand.


The inlined functions call trace_guest_user_syscall[_ret] which are 
indeed declared in the root trace-events file:

trace-events:174:vcpu guest_user_syscall(uint64_t num, ...
trace-events:183:vcpu guest_user_syscall_ret(uint64_t num, ...

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


> 

> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>   include/user/syscall-trace.h | 2 ++

>   1 file changed, 2 insertions(+)

> 

> diff --git a/include/user/syscall-trace.h b/include/user/syscall-trace.h

> index 9e60473643..79fd3e5aa9 100644

> --- a/include/user/syscall-trace.h

> +++ b/include/user/syscall-trace.h

> @@ -10,6 +10,8 @@

>   #ifndef _SYSCALL_TRACE_H_

>   #define _SYSCALL_TRACE_H_

>   

> +#include "trace-root.h"

> +

>   /*

>    * These helpers just provide a common place for the various

>    * subsystems that want to track syscalls to put their hooks in. We

>

Patch

diff --git a/include/user/syscall-trace.h b/include/user/syscall-trace.h
index 9e60473643..79fd3e5aa9 100644
--- a/include/user/syscall-trace.h
+++ b/include/user/syscall-trace.h
@@ -10,6 +10,8 @@ 
 #ifndef _SYSCALL_TRACE_H_
 #define _SYSCALL_TRACE_H_
 
+#include "trace-root.h"
+
 /*
  * These helpers just provide a common place for the various
  * subsystems that want to track syscalls to put their hooks in. We