Remove stale references to Cell BE

Message ID 20191230185036.26435-1-luis.machado@linaro.org
State New
Headers show
Series
  • Remove stale references to Cell BE
Related show

Commit Message

Luis Machado Dec. 30, 2019, 6:50 p.m.
While reading some code i noticed we're still referencing Cell BE in a couple
parts. This patch removes those.

gdb/ChangeLog:

2019-12-30  Luis Machado  <luis.machado@linaro.org>

	* proc-service.c (get_ps_regcache): Remove reference to obsolete
	Cell BE architecture.
	* target.h (struct target_ops) <thread_architecture>: Likewise.

Change-Id: I7a9ccc603b00db22a6275bc5ab69e1417148cb72
---
 gdb/proc-service.c | 5 +----
 gdb/target.h       | 9 ++++-----
 2 files changed, 5 insertions(+), 9 deletions(-)

-- 
2.17.1

Comments

Simon Marchi Dec. 31, 2019, 5:59 p.m. | #1
On 2019-12-30 1:50 p.m., Luis Machado wrote:
> While reading some code i noticed we're still referencing Cell BE in a couple

> parts. This patch removes those.

> 

> gdb/ChangeLog:

> 

> 2019-12-30  Luis Machado  <luis.machado@linaro.org>

> 

> 	* proc-service.c (get_ps_regcache): Remove reference to obsolete

> 	Cell BE architecture.

> 	* target.h (struct target_ops) <thread_architecture>: Likewise.


Thanks, this is ok, but see one comment below.

> Change-Id: I7a9ccc603b00db22a6275bc5ab69e1417148cb72

> ---

>  gdb/proc-service.c | 5 +----

>  gdb/target.h       | 9 ++++-----

>  2 files changed, 5 insertions(+), 9 deletions(-)

> 

> diff --git a/gdb/proc-service.c b/gdb/proc-service.c

> index b0741318ad..75ad126472 100644

> --- a/gdb/proc-service.c

> +++ b/gdb/proc-service.c

> @@ -129,10 +129,7 @@ ps_pdwrite (struct ps_prochandle *ph, psaddr_t addr,

>  /* Get a regcache for LWPID using its inferior's "main" architecture,

>     which is the register set libthread_db expects to be using.  In

>     multi-arch debugging scenarios, the thread's architecture may

> -   differ from the inferior's "main" architecture.  E.g., in the Cell

> -   combined debugger, if GDB happens to interrupt SPU code, the

> -   thread's architecture is SPU, and the main architecture is

> -   PowerPC.  */

> +   differ from the inferior's "main" architecture.  */

>  

>  static struct regcache *

>  get_ps_regcache (struct ps_prochandle *ph, lwpid_t lwpid)

> diff --git a/gdb/target.h b/gdb/target.h

> index 1bb7276673..fcb727628a 100644

> --- a/gdb/target.h

> +++ b/gdb/target.h

> @@ -878,11 +878,10 @@ struct target_ops

>      /* Determine current architecture of thread PTID.

>  

>         The target is supposed to determine the architecture of the code where

> -       the target is currently stopped at (on Cell, if a target is in spu_run,

> -       to_thread_architecture would return SPU, otherwise PPC32 or PPC64).

> -       This is architecture used to perform decr_pc_after_break adjustment,

> -       and also determines the frame architecture of the innermost frame.

> -       ptrace operations need to operate according to target_gdbarch ().  */

> +       the target is currently stopped at.  This is architecture used to


Should this say "This architecture is used"?

Simon

Patch

diff --git a/gdb/proc-service.c b/gdb/proc-service.c
index b0741318ad..75ad126472 100644
--- a/gdb/proc-service.c
+++ b/gdb/proc-service.c
@@ -129,10 +129,7 @@  ps_pdwrite (struct ps_prochandle *ph, psaddr_t addr,
 /* Get a regcache for LWPID using its inferior's "main" architecture,
    which is the register set libthread_db expects to be using.  In
    multi-arch debugging scenarios, the thread's architecture may
-   differ from the inferior's "main" architecture.  E.g., in the Cell
-   combined debugger, if GDB happens to interrupt SPU code, the
-   thread's architecture is SPU, and the main architecture is
-   PowerPC.  */
+   differ from the inferior's "main" architecture.  */
 
 static struct regcache *
 get_ps_regcache (struct ps_prochandle *ph, lwpid_t lwpid)
diff --git a/gdb/target.h b/gdb/target.h
index 1bb7276673..fcb727628a 100644
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -878,11 +878,10 @@  struct target_ops
     /* Determine current architecture of thread PTID.
 
        The target is supposed to determine the architecture of the code where
-       the target is currently stopped at (on Cell, if a target is in spu_run,
-       to_thread_architecture would return SPU, otherwise PPC32 or PPC64).
-       This is architecture used to perform decr_pc_after_break adjustment,
-       and also determines the frame architecture of the innermost frame.
-       ptrace operations need to operate according to target_gdbarch ().  */
+       the target is currently stopped at.  This is architecture used to
+       perform decr_pc_after_break adjustment, and also determines the
+       frame architecture of the innermost frame.  ptrace operations need to
+       operate according to target_gdbarch ().  */
     virtual struct gdbarch *thread_architecture (ptid_t)
       TARGET_DEFAULT_RETURN (NULL);