diff mbox series

[PULL,2/9] hw/display/artist: Remove pointless initialization

Message ID 20200218193929.11404-3-richard.henderson@linaro.org
State Accepted
Commit 6c69f9c48e29376f16965f6e8ea9e1d01f368950
Headers show
Series target/hppa patch queue | expand

Commit Message

Richard Henderson Feb. 18, 2020, 7:39 p.m. UTC 
From: Philippe Mathieu-Daudé <f4bug@amsat.org>


We are initializating incy inconditionally:

    if (y1 <= y2) {
        incy = 1;
    } else {
        incy = -1;
    }

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Acked-by: Sven Schnelle <svens@stackframe.org>

Message-Id: <20200214001303.12873-3-f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 hw/display/artist.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.20.1
diff mbox series

Patch

diff --git a/hw/display/artist.c b/hw/display/artist.c
index abacb0e27d..47f0e9f0bc 100644
--- a/hw/display/artist.c
+++ b/hw/display/artist.c
@@ -572,7 +572,6 @@  static void draw_line(ARTISTState *s, int x1, int y1, int x2, int y2,
     buf = &s->vram_buffer[ARTIST_BUFFER_AP];
 
     c1 = false;
-    incy = 1;
 
     if (x2 > x1) {
         dx = x2 - x1;