[2/3,v2] drm/panel: Add DT bindings for Novatek NT35510-based panels

Message ID 20200223121841.26836-2-linus.walleij@linaro.org
State New
Headers show
Series
  • [1/3,v2] dt-bindings: Add vendor prefix for Hydis technologies
Related show

Commit Message

Linus Walleij Feb. 23, 2020, 12:18 p.m.
This adds device tree bindings for the Novatek NT35510-based
family of panels. Since several such panels are in existence
we define bindings common for all, and define the compatible
string for one certain panel (Hydis HVA40WV1).

As other panels are discovered and investigated, we can add
more compatibles to the binding using oneOf constructions.

Cc: Stephan Gerhold <stephan@gerhold.net>
Cc: devicetree@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
ChangeLog v1->v2:
- Rename file to novatek,nt35510,yaml to match the first
  compatible.
- Require both the specific display manufacturer compatible
  and the novatek,nt35510 compatible in strict sequence.
---
 .../display/panel/novatek,nt35510.yaml        | 56 +++++++++++++++++++
 1 file changed, 56 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml

-- 
2.21.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Comments

Rob Herring Feb. 25, 2020, 6:12 p.m. | #1
On Sun, 23 Feb 2020 13:18:40 +0100, Linus Walleij wrote:
> This adds device tree bindings for the Novatek NT35510-based

> family of panels. Since several such panels are in existence

> we define bindings common for all, and define the compatible

> string for one certain panel (Hydis HVA40WV1).

> 

> As other panels are discovered and investigated, we can add

> more compatibles to the binding using oneOf constructions.

> 

> Cc: Stephan Gerhold <stephan@gerhold.net>

> Cc: devicetree@vger.kernel.org

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> ---

> ChangeLog v1->v2:

> - Rename file to novatek,nt35510,yaml to match the first

>   compatible.

> - Require both the specific display manufacturer compatible

>   and the novatek,nt35510 compatible in strict sequence.

> ---

>  .../display/panel/novatek,nt35510.yaml        | 56 +++++++++++++++++++

>  1 file changed, 56 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml

> 


Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sam Ravnborg Feb. 29, 2020, 1:08 p.m. | #2
On Sun, Feb 23, 2020 at 01:18:40PM +0100, Linus Walleij wrote:
> This adds device tree bindings for the Novatek NT35510-based

> family of panels. Since several such panels are in existence

> we define bindings common for all, and define the compatible

> string for one certain panel (Hydis HVA40WV1).

> 

> As other panels are discovered and investigated, we can add

> more compatibles to the binding using oneOf constructions.

> 

> Cc: Stephan Gerhold <stephan@gerhold.net>

> Cc: devicetree@vger.kernel.org

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>


Applied to drm-misc-next.

	Sam

> ---

> ChangeLog v1->v2:

> - Rename file to novatek,nt35510,yaml to match the first

>   compatible.

> - Require both the specific display manufacturer compatible

>   and the novatek,nt35510 compatible in strict sequence.

> ---

>  .../display/panel/novatek,nt35510.yaml        | 56 +++++++++++++++++++

>  1 file changed, 56 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml

> 

> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml

> new file mode 100644

> index 000000000000..791fc9daa68b

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml

> @@ -0,0 +1,56 @@

> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2

> +---

> +$id: http://devicetree.org/schemas/display/panel/novatek,nt35510.yaml#

> +$schema: http://devicetree.org/meta-schemas/core.yaml#

> +

> +title: Novatek NT35510-based display panels

> +

> +maintainers:

> +  - Linus Walleij <linus.walleij@linaro.org>

> +

> +allOf:

> +  - $ref: panel-common.yaml#

> +

> +properties:

> +  compatible:

> +    items:

> +      - const: hydis,hva40wv1

> +      - const: novatek,nt35510

> +    description: This indicates the panel manufacturer of the panel

> +      that is in turn using the NT35510 panel driver. The compatible

> +      string determines how the NT35510 panel driver shall be configured

> +      to work with the indicated panel. The novatek,nt35510 compatible shall

> +      always be provided as a fallback.

> +  reg: true

> +  reset-gpios: true

> +  vdd-supply:

> +     description: regulator that supplies the vdd voltage

> +  vddi-supply:

> +     description: regulator that supplies the vddi voltage

> +  backlight: true

> +

> +required:

> +  - compatible

> +  - reg

> +

> +additionalProperties: false

> +

> +examples:

> +  - |

> +    #include <dt-bindings/gpio/gpio.h>

> +

> +    dsi@a0351000 {

> +        #address-cells = <1>;

> +        #size-cells = <0>;

> +        panel {

> +            compatible = "hydis,hva40wv1", "novatek,nt35510";

> +            reg = <0>;

> +            vdd-supply = <&ab8500_ldo_aux4_reg>;

> +            vddi-supply = <&ab8500_ldo_aux6_reg>;

> +            reset-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>;

> +            backlight = <&gpio_bl>;

> +        };

> +    };

> +

> +...

> -- 

> 2.21.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
new file mode 100644
index 000000000000..791fc9daa68b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
@@ -0,0 +1,56 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/novatek,nt35510.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Novatek NT35510-based display panels
+
+maintainers:
+  - Linus Walleij <linus.walleij@linaro.org>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    items:
+      - const: hydis,hva40wv1
+      - const: novatek,nt35510
+    description: This indicates the panel manufacturer of the panel
+      that is in turn using the NT35510 panel driver. The compatible
+      string determines how the NT35510 panel driver shall be configured
+      to work with the indicated panel. The novatek,nt35510 compatible shall
+      always be provided as a fallback.
+  reg: true
+  reset-gpios: true
+  vdd-supply:
+     description: regulator that supplies the vdd voltage
+  vddi-supply:
+     description: regulator that supplies the vddi voltage
+  backlight: true
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi@a0351000 {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        panel {
+            compatible = "hydis,hva40wv1", "novatek,nt35510";
+            reg = <0>;
+            vdd-supply = <&ab8500_ldo_aux4_reg>;
+            vddi-supply = <&ab8500_ldo_aux6_reg>;
+            reset-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>;
+            backlight = <&gpio_bl>;
+        };
+    };
+
+...