From patchwork Wed Mar 11 17:21:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 184409 Delivered-To: patches@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp869965ile; Wed, 11 Mar 2020 10:21:28 -0700 (PDT) X-Received: by 2002:a63:5c4:: with SMTP id 187mr3972216pgf.348.1583947288308; Wed, 11 Mar 2020 10:21:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583947288; cv=none; d=google.com; s=arc-20160816; b=Jh+oReolrlPGEev+9dSybvapSNWq3e0OaSs8Lk/1l7mSKlKnj6Zv83/QoYc/0bregD 9EQdi4TA7zflNjKEehmjrdZeiCxpWfjTyQyP9mQvyS523vcquzLqY+mhczlc+rkWxHBC n99h9lcJ4p6ymierprZnO5We2OL/wVaB9xNHFUGBx7LpOj0nt7LHYXuewP4C8zVbfMSo xq+s8ELipHzG0X+1IYhPr2wM84ZCPCZMNv4a+HCAWsrXBU/6KkXIC6aWbdnRtgIwB7q9 RKPp1pjTnH4p6BLoTb8kIEaPq0HRelEZ1iMsnuiq2EftUdTsskh/KaHKZ+otzgBr99Mo YFTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EGHWPlxApQjuktMa4xDP9Q063H+hJfu1b6AJ+NVENyk=; b=UXfla/Unzc0nRK8mRj4vM1D4af5AqRhUSrrlJDCaoV5r69wk4Q6gQveEpYPmBxAwEw +P02v5CZgiKzJwrRZ2R1Weoc/+hmG9fIdBhsXkpU5f3tOS1VPmwYKVwDwOL6sNf/HKrV dY5xbLVCH+DkJZa7GyD9Py+53lfbME+NmNX/53RN371cXhXxnC0OWs0XWL1/0m2XrLFg nJGAibhGDx5rsP/hFjow2ecCTIlwBpEfeCtp1Hvn+dPbPJKC42VjGm6UxB1LLdaP2N1f gPCtZwVcW1E3PFd0BVUs2k8vn/d7YziPR6zxQbnEqikjtG22iA58UInruv/ZegdAbwDL z17Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wzs9yWYI; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id i11sor2874889pfq.36.2020.03.11.10.21.28 for (Google Transport Security); Wed, 11 Mar 2020 10:21:28 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wzs9yWYI; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EGHWPlxApQjuktMa4xDP9Q063H+hJfu1b6AJ+NVENyk=; b=wzs9yWYIHxuZrh+l83G2npKrDy1oqKA1xypVVS2U3HsnbNYgw41X9lhRBnp5I2yzT1 g5VgsJUrdt4LeNiaK2vJ/mH7MyOeWmpLGprY3DMJa9CbNM0R9zNZPcoJYAiL9T2Rdcj9 +LcoDzpvuTgfkwpvij9j9ByGn7+WdlzBB7svWaFuqsRzYYOtH7AnAG602VatDxsx6EF9 594VtuNPghhGM6IC4h6UAS0/ANrg2roTguqX5Lx8EvmYVVJDXFkKA9wFpYUK84uDLvjJ Qk+4ms1LaPNgumDoE2yBA9ihADez2A0VyLMvk8/f567jxhIes7jevL9y497QVZCU0BzV poOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EGHWPlxApQjuktMa4xDP9Q063H+hJfu1b6AJ+NVENyk=; b=RzS3icMBk2pQp2P2oxm32D2AGDCXL9CUw8jGRrAzlv5VBzONRCkeYLCnVnuOuD1Vgu 6DTHLMM6obuMXyWSNbCQLoxE2zT1EkVEpWnpuvChc4nYYAcGLeUfj7cmHVykZrjxjqOH gGaCp2+uCN8jjsZLpi8k6hlKGsTimIwo8ScK0yiP0mgIUsFVP+kSZvpEPyLRAbXRIr63 4FK6/fH+u/cUBkW2kXdjhr5p15foVUQB4dFcOjj/JzYM8aJnglk/2U3YfesQPI1thXdY 7nH1DhgRZLpNYotcG8s0MmFtKwC9XwWLEcOSUlg5DFwRtLE5LmUGRBE91IU1W7vzxeGH RDbg== X-Gm-Message-State: ANhLgQ2jKZvMshjnJRHyEjlgIYZA9KrhS0glo9UegQVQrX53yHpqfEQR QOnYH9Daj/1eJMWo2DCNsA3eHYsj X-Google-Smtp-Source: ADFU+vsIQvS6vI9A6/ZJeX7p5NOAE/vGwSitovbBlSU6A/ubzt4w/w/19x/VN1rAPQPkC6KZ7bZHVw== X-Received: by 2002:a62:382:: with SMTP id 124mr3867452pfd.11.1583947287937; Wed, 11 Mar 2020 10:21:27 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id b24sm14914053pfi.52.2020.03.11.10.21.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 10:21:27 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Greg Kroah-Hartman , Rob Herring , Mark Rutland , ShuFan Lee , Heikki Krogerus , Suzuki K Poulose , Chunfeng Yun , Yu Chen , Felipe Balbi , Hans de Goede , Andy Shevchenko , Jun Li , Valentin Schneider , Guillaume Gardet , Jack Pham , linux-usb@vger.kernel.org, devicetree@vger.kernel.org Subject: [RESEND][PATCH v8 6/6] usb: dwc3: Rework resets initialization to be more flexible Date: Wed, 11 Mar 2020 17:21:09 +0000 Message-Id: <20200311172109.45134-7-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200311172109.45134-1-john.stultz@linaro.org> References: <20200311172109.45134-1-john.stultz@linaro.org> The dwc3 core binding specifies one reset. However some variants of the hardware may have more. Previously this was handled by using the dwc3-of-simple glue driver, but that resulted in a proliferation of bindings for for every variant, when the only difference was the clocks and resets lists. So this patch reworks the reading of the resets to fetch all the resets specified in the dts together. This patch was recommended by Rob Herring as an alternative to creating multiple bindings for each variant of hardware. Cc: Greg Kroah-Hartman Cc: Rob Herring Cc: Mark Rutland CC: ShuFan Lee Cc: Heikki Krogerus Cc: Suzuki K Poulose Cc: Chunfeng Yun Cc: Yu Chen Cc: Felipe Balbi Cc: Hans de Goede Cc: Andy Shevchenko Cc: Jun Li Cc: Valentin Schneider Cc: Guillaume Gardet Cc: Jack Pham Cc: linux-usb@vger.kernel.org Cc: devicetree@vger.kernel.org Suggested-by: Rob Herring Signed-off-by: John Stultz --- v3: Rework dwc3 core rather then adding another dwc-of-simple binding. v6: Re-introduce this patch, on Rob's suggestion --- drivers/usb/dwc3/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index ba21af5c1204..2afcc04da338 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1465,7 +1465,7 @@ static int dwc3_probe(struct platform_device *pdev) dwc3_get_properties(dwc); - dwc->reset = devm_reset_control_get_optional_shared(dev, NULL); + dwc->reset = devm_reset_control_array_get(dev, true, true); if (IS_ERR(dwc->reset)) return PTR_ERR(dwc->reset);