| Message ID | 20200319193323.2038-2-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Automation of Coverity Scan uploads (via Docker) | expand |
On 3/19/20 12:33 PM, Peter Maydell wrote: > In commit a1a98357e3fd in 2018 we added some workarounds for Coverity > not being able to handle the _Float* types introduced by recent > glibc. Newer versions of the Coverity scan tools have support for > these types, and will fail with errors about duplicate typedefs if we > have our workaround. Remove our copy of the typedefs. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 9bd3dcfd136..20f5c5f197d 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -33,20 +33,6 @@ #else #include "exec/poison.h" #endif -#ifdef __COVERITY__ -/* Coverity does not like the new _Float* types that are used by - * recent glibc, and croaks on every single file that includes - * stdlib.h. These typedefs are enough to please it. - * - * Note that these fix parse errors so they cannot be placed in - * scripts/coverity-model.c. - */ -typedef float _Float32; -typedef double _Float32x; -typedef double _Float64; -typedef __float80 _Float64x; -typedef __float128 _Float128; -#endif #include "qemu/compiler.h"
In commit a1a98357e3fd in 2018 we added some workarounds for Coverity not being able to handle the _Float* types introduced by recent glibc. Newer versions of the Coverity scan tools have support for these types, and will fail with errors about duplicate typedefs if we have our workaround. Remove our copy of the typedefs. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- Sadly I don't think there's any way to tell whether we should or should not provide the typedefs, so anybody with an older Coverity will presumably find this breaks them. --- include/qemu/osdep.h | 14 -------------- 1 file changed, 14 deletions(-) -- 2.20.1