diff mbox series

[v8,17/74] hw/semihosting: convert to cpu_halted_set

Message ID 20200326193156.4322-18-robert.foley@linaro.org
State Superseded
Headers show
Series per-CPU locks | expand

Commit Message

Robert Foley March 26, 2020, 7:30 p.m. UTC 
Signed-off-by: Robert Foley <robert.foley@linaro.org>

---
 hw/semihosting/console.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.17.1

Comments

Alex Bennée May 11, 2020, 10:25 a.m. UTC | #1 
Robert Foley <robert.foley@linaro.org> writes:

> Signed-off-by: Robert Foley <robert.foley@linaro.org>


Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


> ---

>  hw/semihosting/console.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

>

> diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c

> index 6346bd7f50..f70085f3c1 100644

> --- a/hw/semihosting/console.c

> +++ b/hw/semihosting/console.c

> @@ -131,7 +131,7 @@ static void console_wake_up(gpointer data, gpointer user_data)

>  {

>      CPUState *cs = (CPUState *) data;

>      /* cpu_handle_halt won't know we have work so just unbung here */

> -    cs->halted = 0;

> +    cpu_halted_set(cs, 0);

>      qemu_cpu_kick(cs);

>  }

>  

> @@ -154,7 +154,7 @@ target_ulong qemu_semihosting_console_inc(CPUArchState *env)

>      g_assert(current_cpu);

>      if (fifo8_is_empty(&c->fifo)) {

>          c->sleeping_cpus = g_slist_prepend(c->sleeping_cpus, current_cpu);

> -        current_cpu->halted = 1;

> +        cpu_halted_set(current_cpu, 1);

>          current_cpu->exception_index = EXCP_HALTED;

>          cpu_loop_exit(current_cpu);

>          /* never returns */



-- 
Alex Bennée
diff mbox series

Patch

diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c
index 6346bd7f50..f70085f3c1 100644
--- a/hw/semihosting/console.c
+++ b/hw/semihosting/console.c
@@ -131,7 +131,7 @@  static void console_wake_up(gpointer data, gpointer user_data)
 {
     CPUState *cs = (CPUState *) data;
     /* cpu_handle_halt won't know we have work so just unbung here */
-    cs->halted = 0;
+    cpu_halted_set(cs, 0);
     qemu_cpu_kick(cs);
 }
 
@@ -154,7 +154,7 @@  target_ulong qemu_semihosting_console_inc(CPUArchState *env)
     g_assert(current_cpu);
     if (fifo8_is_empty(&c->fifo)) {
         c->sleeping_cpus = g_slist_prepend(c->sleeping_cpus, current_cpu);
-        current_cpu->halted = 1;
+        cpu_halted_set(current_cpu, 1);
         current_cpu->exception_index = EXCP_HALTED;
         cpu_loop_exit(current_cpu);
         /* never returns */