diff mbox series

[v8,25/74] riscv: convert to cpu_halted

Message ID 20200326193156.4322-26-robert.foley@linaro.org
State Superseded
Headers show
Series per-CPU locks | expand

Commit Message

Robert Foley March 26, 2020, 7:31 p.m. UTC
From: "Emilio G. Cota" <cota@braap.org>


Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Sagar Karandikar <sagark@eecs.berkeley.edu>
Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cc: Alistair Francis <alistair23@gmail.com>
Reviewed-by: Palmer Dabbelt <palmer@dabbelt.com>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Signed-off-by: Emilio G. Cota <cota@braap.org>

Signed-off-by: Robert Foley <robert.foley@linaro.org>

---
 target/riscv/op_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

Comments

Alex Bennée May 11, 2020, 10:40 a.m. UTC | #1
Robert Foley <robert.foley@linaro.org> writes:

> From: "Emilio G. Cota" <cota@braap.org>

>

> Cc: Palmer Dabbelt <palmer@dabbelt.com>

> Cc: Sagar Karandikar <sagark@eecs.berkeley.edu>

> Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

> Cc: Alistair Francis <alistair23@gmail.com>

> Reviewed-by: Palmer Dabbelt <palmer@dabbelt.com>


You can drop Cc: lines fron patches once you have an a-b or r-b tag from
the person in question. They are basically a formalised way of saying "I
have tried to contact the maintainer/relevant party" and memorialising
it in the patches. The effect of Cc, r-b and a-b tags in the patch is
all pretty much the same in that people get Cc'ed anyway - on top of
what get_maintainers.pl will add as well!

> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

> Signed-off-by: Emilio G. Cota <cota@braap.org>

> Signed-off-by: Robert Foley <robert.foley@linaro.org>

> ---

>  target/riscv/op_helper.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c

> index c6412f680c..91f8833c2e 100644

> --- a/target/riscv/op_helper.c

> +++ b/target/riscv/op_helper.c

> @@ -182,7 +182,7 @@ void helper_wfi(CPURISCVState *env)

>          riscv_cpu_virt_enabled(env)) {

>          riscv_raise_exception(env, RISCV_EXCP_ILLEGAL_INST, GETPC());

>      } else {

> -        cs->halted = 1;

> +        cpu_halted_set(cs, 1);

>          cs->exception_index = EXCP_HLT;

>          cpu_loop_exit(cs);

>      }



-- 
Alex Bennée
Robert Foley May 11, 2020, 4:13 p.m. UTC | #2
On Mon, 11 May 2020 at 06:40, Alex Bennée <alex.bennee@linaro.org> wrote:
> Robert Foley <robert.foley@linaro.org> writes:

>

> > From: "Emilio G. Cota" <cota@braap.org>

> >

> > Cc: Palmer Dabbelt <palmer@dabbelt.com>

> > Cc: Sagar Karandikar <sagark@eecs.berkeley.edu>

> > Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

> > Cc: Alistair Francis <alistair23@gmail.com>

> > Reviewed-by: Palmer Dabbelt <palmer@dabbelt.com>

>

> You can drop Cc: lines fron patches once you have an a-b or r-b tag from

> the person in question. They are basically a formalised way of saying "I

> have tried to contact the maintainer/relevant party" and memorialising

> it in the patches. The effect of Cc, r-b and a-b tags in the patch is

> all pretty much the same in that people get Cc'ed anyway - on top of

> what get_maintainers.pl will add as well!


Thanks for explaining, good to know this. :)  Will correct this.

Thanks,
-Rob
diff mbox series

Patch

diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c
index c6412f680c..91f8833c2e 100644
--- a/target/riscv/op_helper.c
+++ b/target/riscv/op_helper.c
@@ -182,7 +182,7 @@  void helper_wfi(CPURISCVState *env)
         riscv_cpu_virt_enabled(env)) {
         riscv_raise_exception(env, RISCV_EXCP_ILLEGAL_INST, GETPC());
     } else {
-        cs->halted = 1;
+        cpu_halted_set(cs, 1);
         cs->exception_index = EXCP_HLT;
         cpu_loop_exit(cs);
     }