| Message ID | 20200402143913.24005-1-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/arm: don't expose "ieee_half" via gdbstub | expand |
On 4/2/20 7:39 AM, Alex Bennée wrote: > While support for parsing ieee_half in the XML description was added > to gdb in 2019 (a6d0f249) there is no easy way for the gdbstub to know > if the gdb end will understand it. Disable it for now and allow older > gdbs to successfully connect to the default -cpu max SVE enabled > QEMUs. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > target/arm/gdbstub.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On Thu, 2 Apr 2020 at 15:39, Alex Bennée <alex.bennee@linaro.org> wrote: > > While support for parsing ieee_half in the XML description was added > to gdb in 2019 (a6d0f249) there is no easy way for the gdbstub to know > if the gdb end will understand it. Disable it for now and allow older > gdbs to successfully connect to the default -cpu max SVE enabled > QEMUs. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- Applied to target-arm.next for 5.0, thanks. -- PMM
diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c index d9ef7d2187c..8efc535f2a0 100644 --- a/target/arm/gdbstub.c +++ b/target/arm/gdbstub.c @@ -192,7 +192,12 @@ static const struct TypeSize vec_lanes[] = { /* 16 bit */ { "uint16", 16, 'h', 'u' }, { "int16", 16, 'h', 's' }, - { "ieee_half", 16, 'h', 'f' }, + /* + * TODO: currently there is no reliable way of telling + * if the remote gdb actually understands ieee_half so + * we don't expose it in the target description for now. + * { "ieee_half", 16, 'h', 'f' }, + */ /* bytes */ { "uint8", 8, 'b', 'u' }, { "int8", 8, 'b', 's' },
While support for parsing ieee_half in the XML description was added to gdb in 2019 (a6d0f249) there is no easy way for the gdbstub to know if the gdb end will understand it. Disable it for now and allow older gdbs to successfully connect to the default -cpu max SVE enabled QEMUs. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- target/arm/gdbstub.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) -- 2.20.1