From patchwork Tue Apr 7 14:39:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 185238 Delivered-To: patches@linaro.org Received: by 2002:a50:3f90:0:0:0:0:0 with SMTP id e16csp1955907ecu; Tue, 7 Apr 2020 07:39:10 -0700 (PDT) X-Received: by 2002:a2e:9084:: with SMTP id l4mr1991309ljg.277.1586270350771; Tue, 07 Apr 2020 07:39:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586270350; cv=none; d=google.com; s=arc-20160816; b=VF03rAFUA7FQArlKNsEUTVWsVAJhSdTktx6peXr1RXkS/ZHKTrAQh/SjuOwejf/xME 4/mzSTqIPBLJPB7Unb8O/YeMpUGnpI0qwhBSYBkq0BRAJkDXefaO4mej/MqahQF6kB7t /UvDDASxU9QVtOgIfF43606Oo2dwJOqk7O0wQmQNBxq7Z9yRA69cFEBoAiPL5zkFieBW n+TsMP/HSZVaKmPnSBQD/2QZULi8BUZtEgil08xOUV9Ot057ZdT3od2Rp8x1CH6zBYaX 70EZhHSNCGHKgcQM1fObOBb8AxpUuJOv6XQdfDVFYrKeXntUYb1snHlKDzFb4zy2vqsk 8bQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=F6FPcP9wCF9lbemCjzdObes0liRQcDYLDA7JXgfzHU8=; b=zbpsrfGlEyIRQI267HZcE2tNm0/Hs6xy9CY90SSqwjeLCO5UGXYkPp2/D0XoyRorJB 0F9XqNY4R1G6EAHNVCULksd/vLDBcXvZbdKWtMDREt+iSwUofywim7NUHHfoehS2EXtw W4i3qM6cb8QdeajuJqqNuBKWWHpexUny//E2o8zO6i3XZ1LM7FxtC2M/W7t2ZcrhBQNl XQ9vzG9K44X794D46hwu2WxBnOdjYnCNF81LE/DXTLnGXdqTGRFU2hz2iu3ZiB701P17 o6LWuQ7qUPgQZJXJee+XchvVSf7vc/iAjhizs3IN+F0DTCwvND3/vkscTYsQDGdiMeEj gnsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=K0EkQvBs; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id b22sor2351200lji.34.2020.04.07.07.39.10 for (Google Transport Security); Tue, 07 Apr 2020 07:39:10 -0700 (PDT) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=K0EkQvBs; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F6FPcP9wCF9lbemCjzdObes0liRQcDYLDA7JXgfzHU8=; b=K0EkQvBseSNAZnXSPoBDXsWwFnCefw2469Vsn5MdviQD0EwQtHBK3xfI+p3BK+HRof /rgo1R5rvrqDCe30Fr1ldN7LLUzrb4WkSH2/RcqB5razJutC7W7rgZjiZ2fNgzDMjZcV a/SwNBlT4BiOfODTfu8heNHKPso0FPXvG0Q1Vj2B6Ob1+YFgjxURs67OKC4Yg3+6bRrn rtvWgq/tqd0INi/+Mayooul/EMvhJw0Q2twn6JjEpmJvrvPHv90I3YVvrnIRHV2EpyfQ OgZPntCnerpjt86rj1up2GBla2WAOETakfWvGZ0+gJyYPWNkul7I6AMxq1BnBdmsGY82 8yvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F6FPcP9wCF9lbemCjzdObes0liRQcDYLDA7JXgfzHU8=; b=IJOrJHE7lwJYDUNtQwkhsZJinfU2HURkXrlbU/uDupK06xGFiizwU5ZmWzHc8PgALV zpfjsCC1DKNttDTAHqmJhbCL28P2U8yzTo8Ljl20NEJKef/2/2Jh/r5cY6p4I3n7ykQL 8Re3nyOacfDJ7RQula2/had9GZ26UrWVJxQ+9hiIF9e0jMqTeGOdalm0h7f/XUj3XwnQ H5Zo79/ipdV+PfAKPp33aoSYLfCeifiyf4YllQ4/uI0x1bkXST+8b9yVhwd1I6MptsI0 7ec+VBh77v3ZBmCaHkPBs0yBF8PXqcdVErwo7yQaD91wuEfx9ifZWPueQdbLzFVxm3PL 5buQ== X-Gm-Message-State: AGi0PuaHTSUzZPSrfk0xm16JLmXxV3ZQlO7bxcyu+RqQA+9F/YekNDCY xdoAcHsSygHYfu76GccmGlJJkqLVWrKKig== X-Google-Smtp-Source: APiQypIUdq4uWT93PKLlqfFoVnrilfjjNkV3KFoFxdwzdlhs9bq/HjbfYr1gHCaARcG678Of2NMQhQ== X-Received: by 2002:a2e:9912:: with SMTP id v18mr1851732lji.199.1586270350418; Tue, 07 Apr 2020 07:39:10 -0700 (PDT) Return-Path: Received: from localhost.localdomain (h-158-174-22-210.NA.cust.bahnhof.se. [158.174.22.210]) by smtp.gmail.com with ESMTPSA id v21sm14585017lji.81.2020.04.07.07.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2020 07:39:09 -0700 (PDT) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: Ben Dooks , Krzysztof Kozlowski , Kukjin Kim Subject: [PATCH] mmc: s3cmci: Drop redundant code in s3cmci_setup_data() Date: Tue, 7 Apr 2020 16:39:03 +0200 Message-Id: <20200407143903.22477-1-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 The in-parameter struct mmc_data *data is never NULL, because the caller always provides a valid pointer. Hence drop the corresponding redundant code. Signed-off-by: Ulf Hansson --- drivers/mmc/host/s3cmci.c | 7 ------- 1 file changed, 7 deletions(-) -- 2.20.1 diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c index 1e616ae56b13..444b2769ae2c 100644 --- a/drivers/mmc/host/s3cmci.c +++ b/drivers/mmc/host/s3cmci.c @@ -958,13 +958,6 @@ static int s3cmci_setup_data(struct s3cmci_host *host, struct mmc_data *data) { u32 dcon, imsk, stoptries = 3; - /* write DCON register */ - - if (!data) { - writel(0, host->base + S3C2410_SDIDCON); - return 0; - } - if ((data->blksz & 3) != 0) { /* We cannot deal with unaligned blocks with more than * one block being transferred. */