[PULL,3/8] configure: disable PIE for Windows builds

Message ID	20200415104211.9388-4-alex.bennee@linaro.org
State	New
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; From: =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org> To: peter.maydell@linaro.org Subject: [PULL 3/8] configure: disable PIE for Windows builds Date: Wed, 15 Apr 2020 11:42:06 +0100 Message-Id: <20200415104211.9388-4-alex.bennee@linaro.org> In-Reply-To: <20200415104211.9388-1-alex.bennee@linaro.org> References: <20200415104211.9388-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: list Cc: Bug 1871798 <1871798@bugs.launchpad.net>, Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org, =?utf-8?q?Alex?= =?utf-8?q?_Benn=C3=A9e?= <alex.bennee@linaro.org>, James Le Cuirot <chewi@aura-online.co.uk>, Howard Spoelstra <hsp.cat7@gmail.com>, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@redhat.com> Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>
Series	a few small fixes (docker, user, pie and gdbstub) \| expand [PULL,for,5.0-rc3,0/8] a few small fixes (docker, user, pie and gdbstub) [PULL,1/8] tests/docker: add docs FEATURE flag and use for test-misc [PULL,2/8] configure: redirect sphinx-build check to config.log [PULL,3/8] configure: disable PIE for Windows builds [PULL,4/8] linux-user: fix /proc/self/stat handling [PULL,5/8] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray [PULL,6/8] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb [PULL,7/8] gdbstub: Do not use memset() on GByteArray [PULL,8/8] gdbstub: Introduce gdb_get_float32() to get 32-bit float registers

Message ID

20200415104211.9388-4-alex.bennee@linaro.org

State

New

Headers

Received-SPF: pass (google.com: domain of
	qemu-devel-bounces+patch=linaro.org@nongnu.org designates
	209.51.188.17 as permitted sender) client-ip=209.51.188.17; 
From: =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Subject: [PULL 3/8] configure: disable PIE for Windows builds
Date: Wed, 15 Apr 2020 11:42:06 +0100
Message-Id: <20200415104211.9388-4-alex.bennee@linaro.org>
In-Reply-To: <20200415104211.9388-1-alex.bennee@linaro.org>
References: <20200415104211.9388-1-alex.bennee@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: list
Cc: Bug 1871798 <1871798@bugs.launchpad.net>, Richard Henderson
	<richard.henderson@linaro.org>, qemu-devel@nongnu.org, =?utf-8?q?Alex?=
	=?utf-8?q?_Benn=C3=A9e?= <alex.bennee@linaro.org>,
	James Le Cuirot <chewi@aura-online.co.uk>, Howard Spoelstra
	<hsp.cat7@gmail.com>, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=
	<philmd@redhat.com>
Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>

Series

a few small fixes (docker, user, pie and gdbstub) | expand

Commit Message

Alex Bennée April 15, 2020, 10:42 a.m. UTC

It seems on some compilers the test can pass but still give you
broken binaries.

Fixes: d2cd29e30736
Fixes: https://bugs.launchpad.net/qemu/+bug/1871798
Cc: Bug 1871798 <1871798@bugs.launchpad.net>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Tested-by: Howard Spoelstra <hsp.cat7@gmail.com>

Tested-by: James Le Cuirot <chewi@aura-online.co.uk>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Message-Id: <20200414200631.12799-9-alex.bennee@linaro.org>

-- 
2.20.1

diff --git a/configure b/configure
index 25f7d915720..23b5e93752b 100755
--- a/configure
+++ b/configure
@@ -807,6 +807,7 @@  MINGW32*)
     audio_drv_list=""
   fi
   supported_os="yes"
+  pie="no"
 ;;
 GNU/kFreeBSD)
   bsd="yes"

[PULL,3/8] configure: disable PIE for Windows builds

Commit Message

Patch