[v8,06/13] net/dpaa2: move internal symbols into INTERNAL section

Message ID 20200515094752.28490-7-hemant.agrawal@nxp.com
State New
Headers show
Series
  • NXP DPAAx: move internal symbols to INTERNAL
Related show

Commit Message

Hemant Agrawal May 15, 2020, 9:47 a.m.
This patch moves the internal symbols to INTERNAL sections
so that any change in them is not reported as ABI breakage.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

---
 drivers/net/dpaa2/dpaa2_ethdev.h            |  2 ++
 drivers/net/dpaa2/rte_pmd_dpaa2_version.map | 12 +++++++-----
 2 files changed, 9 insertions(+), 5 deletions(-)

-- 
2.17.1

Comments

Ray Kinsella May 19, 2020, 11:15 a.m. | #1
On 15/05/2020 10:47, Hemant Agrawal wrote:
> This patch moves the internal symbols to INTERNAL sections

> so that any change in them is not reported as ABI breakage.

> 

> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

> ---

>  drivers/net/dpaa2/dpaa2_ethdev.h            |  2 ++

>  drivers/net/dpaa2/rte_pmd_dpaa2_version.map | 12 +++++++-----

>  2 files changed, 9 insertions(+), 5 deletions(-)

> 

> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.h b/drivers/net/dpaa2/dpaa2_ethdev.h

> index 2c49a7f01f..c7fb6539ff 100644

> --- a/drivers/net/dpaa2/dpaa2_ethdev.h

> +++ b/drivers/net/dpaa2/dpaa2_ethdev.h

> @@ -164,11 +164,13 @@ int dpaa2_remove_flow_dist(struct rte_eth_dev *eth_dev,

>  

>  int dpaa2_attach_bp_list(struct dpaa2_dev_priv *priv, void *blist);

>  

> +__rte_internal

>  int dpaa2_eth_eventq_attach(const struct rte_eth_dev *dev,

>  		int eth_rx_queue_id,

>  		struct dpaa2_dpcon_dev *dpcon,

>  		const struct rte_event_eth_rx_adapter_queue_conf *queue_conf);

>  

> +__rte_internal

>  int dpaa2_eth_eventq_detach(const struct rte_eth_dev *dev,

>  		int eth_rx_queue_id);

>  

> diff --git a/drivers/net/dpaa2/rte_pmd_dpaa2_version.map b/drivers/net/dpaa2/rte_pmd_dpaa2_version.map

> index f2bb793319..b633fdc2a8 100644

> --- a/drivers/net/dpaa2/rte_pmd_dpaa2_version.map

> +++ b/drivers/net/dpaa2/rte_pmd_dpaa2_version.map

> @@ -1,9 +1,4 @@

>  DPDK_20.0 {

> -	global:

> -

> -	dpaa2_eth_eventq_attach;

> -	dpaa2_eth_eventq_detach;

> -

>  	local: *;

>  };

>  

> @@ -14,3 +9,10 @@ EXPERIMENTAL {

>  	rte_pmd_dpaa2_set_custom_hash;

>  	rte_pmd_dpaa2_set_timestamp;

>  };

> +

> +INTERNAL {

> +	global:

> +

> +	dpaa2_eth_eventq_attach;

> +	dpaa2_eth_eventq_detach;

> +};

> 


As comments on [PATCH v8 05/13]

Patch

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.h b/drivers/net/dpaa2/dpaa2_ethdev.h
index 2c49a7f01f..c7fb6539ff 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.h
+++ b/drivers/net/dpaa2/dpaa2_ethdev.h
@@ -164,11 +164,13 @@  int dpaa2_remove_flow_dist(struct rte_eth_dev *eth_dev,
 
 int dpaa2_attach_bp_list(struct dpaa2_dev_priv *priv, void *blist);
 
+__rte_internal
 int dpaa2_eth_eventq_attach(const struct rte_eth_dev *dev,
 		int eth_rx_queue_id,
 		struct dpaa2_dpcon_dev *dpcon,
 		const struct rte_event_eth_rx_adapter_queue_conf *queue_conf);
 
+__rte_internal
 int dpaa2_eth_eventq_detach(const struct rte_eth_dev *dev,
 		int eth_rx_queue_id);
 
diff --git a/drivers/net/dpaa2/rte_pmd_dpaa2_version.map b/drivers/net/dpaa2/rte_pmd_dpaa2_version.map
index f2bb793319..b633fdc2a8 100644
--- a/drivers/net/dpaa2/rte_pmd_dpaa2_version.map
+++ b/drivers/net/dpaa2/rte_pmd_dpaa2_version.map
@@ -1,9 +1,4 @@ 
 DPDK_20.0 {
-	global:
-
-	dpaa2_eth_eventq_attach;
-	dpaa2_eth_eventq_detach;
-
 	local: *;
 };
 
@@ -14,3 +9,10 @@  EXPERIMENTAL {
 	rte_pmd_dpaa2_set_custom_hash;
 	rte_pmd_dpaa2_set_timestamp;
 };
+
+INTERNAL {
+	global:
+
+	dpaa2_eth_eventq_attach;
+	dpaa2_eth_eventq_detach;
+};