[v8,07/13] crypto: move internal symbols into INTERNAL section

Message ID 20200515094752.28490-8-hemant.agrawal@nxp.com
State New
Headers show
Series
  • NXP DPAAx: move internal symbols to INTERNAL
Related show

Commit Message

Hemant Agrawal May 15, 2020, 9:47 a.m.
This patch moves the internal symbols to INTERNAL sections
so that any change in them is not reported as ABI breakage.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

---
 drivers/crypto/dpaa2_sec/dpaa2_sec_event.h             | 5 +++--
 drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map | 6 ++++--
 drivers/crypto/dpaa_sec/dpaa_sec_event.h               | 8 ++++----
 drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map   | 6 ++++--
 4 files changed, 15 insertions(+), 10 deletions(-)

-- 
2.17.1

Comments

Ray Kinsella May 19, 2020, 11:17 a.m. | #1
On 15/05/2020 10:47, Hemant Agrawal wrote:
> This patch moves the internal symbols to INTERNAL sections

> so that any change in them is not reported as ABI breakage.

> 

> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

> ---

>  drivers/crypto/dpaa2_sec/dpaa2_sec_event.h             | 5 +++--

>  drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map | 6 ++++--

>  drivers/crypto/dpaa_sec/dpaa_sec_event.h               | 8 ++++----

>  drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map   | 6 ++++--

>  4 files changed, 15 insertions(+), 10 deletions(-)

> 

> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_event.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_event.h

> index c779d5d837..675cbbb81d 100644

> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_event.h

> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_event.h

> @@ -6,12 +6,13 @@

>  #ifndef _DPAA2_SEC_EVENT_H_

>  #define _DPAA2_SEC_EVENT_H_

>  

> -int

> -dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev,

> +__rte_internal

> +int dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev,

>  		int qp_id,

>  		struct dpaa2_dpcon_dev *dpcon,

>  		const struct rte_event *event);

>  

> +__rte_internal

>  int dpaa2_sec_eventq_detach(const struct rte_cryptodev *dev,

>  		int qp_id);

>  

> diff --git a/drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map b/drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map

> index 5952d645fd..3d863aff4d 100644

> --- a/drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map

> +++ b/drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map

> @@ -1,8 +1,10 @@

>  DPDK_20.0 {

> +	local: *;

> +};

> +

> +INTERNAL {

>  	global:

>  

>  	dpaa2_sec_eventq_attach;

>  	dpaa2_sec_eventq_detach;

> -

> -	local: *;

>  };

> diff --git a/drivers/crypto/dpaa_sec/dpaa_sec_event.h b/drivers/crypto/dpaa_sec/dpaa_sec_event.h

> index 8d1a018096..0b09fa8f75 100644

> --- a/drivers/crypto/dpaa_sec/dpaa_sec_event.h

> +++ b/drivers/crypto/dpaa_sec/dpaa_sec_event.h

> @@ -6,14 +6,14 @@

>  #ifndef _DPAA_SEC_EVENT_H_

>  #define _DPAA_SEC_EVENT_H_

>  

> -int

> -dpaa_sec_eventq_attach(const struct rte_cryptodev *dev,

> +__rte_internal

> +int dpaa_sec_eventq_attach(const struct rte_cryptodev *dev,

>  		int qp_id,

>  		uint16_t ch_id,

>  		const struct rte_event *event);

>  

> -int

> -dpaa_sec_eventq_detach(const struct rte_cryptodev *dev,

> +__rte_internal

> +int dpaa_sec_eventq_detach(const struct rte_cryptodev *dev,

>  		int qp_id);

>  

>  #endif /* _DPAA_SEC_EVENT_H_ */

> diff --git a/drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map b/drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map

> index 8580fa13db..023e120516 100644

> --- a/drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map

> +++ b/drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map

> @@ -1,8 +1,10 @@

>  DPDK_20.0 {

> +	local: *;

> +};

> +

> +INTERNAL {

>  	global:

>  

>  	dpaa_sec_eventq_attach;

>  	dpaa_sec_eventq_detach;

> -

> -	local: *;

>  };

> 


As comments on [PATCH v8 05/13]

Patch

diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_event.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_event.h
index c779d5d837..675cbbb81d 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_event.h
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_event.h
@@ -6,12 +6,13 @@ 
 #ifndef _DPAA2_SEC_EVENT_H_
 #define _DPAA2_SEC_EVENT_H_
 
-int
-dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev,
+__rte_internal
+int dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev,
 		int qp_id,
 		struct dpaa2_dpcon_dev *dpcon,
 		const struct rte_event *event);
 
+__rte_internal
 int dpaa2_sec_eventq_detach(const struct rte_cryptodev *dev,
 		int qp_id);
 
diff --git a/drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map b/drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map
index 5952d645fd..3d863aff4d 100644
--- a/drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map
+++ b/drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map
@@ -1,8 +1,10 @@ 
 DPDK_20.0 {
+	local: *;
+};
+
+INTERNAL {
 	global:
 
 	dpaa2_sec_eventq_attach;
 	dpaa2_sec_eventq_detach;
-
-	local: *;
 };
diff --git a/drivers/crypto/dpaa_sec/dpaa_sec_event.h b/drivers/crypto/dpaa_sec/dpaa_sec_event.h
index 8d1a018096..0b09fa8f75 100644
--- a/drivers/crypto/dpaa_sec/dpaa_sec_event.h
+++ b/drivers/crypto/dpaa_sec/dpaa_sec_event.h
@@ -6,14 +6,14 @@ 
 #ifndef _DPAA_SEC_EVENT_H_
 #define _DPAA_SEC_EVENT_H_
 
-int
-dpaa_sec_eventq_attach(const struct rte_cryptodev *dev,
+__rte_internal
+int dpaa_sec_eventq_attach(const struct rte_cryptodev *dev,
 		int qp_id,
 		uint16_t ch_id,
 		const struct rte_event *event);
 
-int
-dpaa_sec_eventq_detach(const struct rte_cryptodev *dev,
+__rte_internal
+int dpaa_sec_eventq_detach(const struct rte_cryptodev *dev,
 		int qp_id);
 
 #endif /* _DPAA_SEC_EVENT_H_ */
diff --git a/drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map b/drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map
index 8580fa13db..023e120516 100644
--- a/drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map
+++ b/drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map
@@ -1,8 +1,10 @@ 
 DPDK_20.0 {
+	local: *;
+};
+
+INTERNAL {
 	global:
 
 	dpaa_sec_eventq_attach;
 	dpaa_sec_eventq_detach;
-
-	local: *;
 };