[v8,13/13] bus/fslmc: remove unused symbols

Message ID 20200515094752.28490-14-hemant.agrawal@nxp.com
State New
Headers show
Series
  • NXP DPAAx: move internal symbols to INTERNAL
Related show

Commit Message

Hemant Agrawal May 15, 2020, 9:47 a.m.
rte_dpaa2_memsegs is not being used by any other library
or even within bus.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

---
 drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c    | 6 ------
 drivers/bus/fslmc/portal/dpaa2_hw_pvt.h     | 3 ---
 drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 -
 3 files changed, 10 deletions(-)

-- 
2.17.1

Comments

Ray Kinsella May 19, 2020, 11:29 a.m. | #1
On 15/05/2020 10:47, Hemant Agrawal wrote:
> rte_dpaa2_memsegs is not being used by any other library

> or even within bus.

> 

> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

> ---

>  drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c    | 6 ------

>  drivers/bus/fslmc/portal/dpaa2_hw_pvt.h     | 3 ---

>  drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 -

>  3 files changed, 10 deletions(-)

> 

> diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c

> index 79b148f20b..d9619848d8 100644

> --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c

> +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c

> @@ -28,12 +28,6 @@

>  #include "portal/dpaa2_hw_pvt.h"

>  #include "portal/dpaa2_hw_dpio.h"

>  

> -/* List of all the memseg information locally maintained in dpaa2 driver. This

> - * is to optimize the PA_to_VA searches until a better mechanism (algo) is

> - * available.

> - */

> -struct dpaa2_memseg_list rte_dpaa2_memsegs

> -	= TAILQ_HEAD_INITIALIZER(rte_dpaa2_memsegs);

>  

>  TAILQ_HEAD(dpbp_dev_list, dpaa2_dpbp_dev);

>  static struct dpbp_dev_list dpbp_dev_list

> diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h

> index 194b99c583..19fdd9cfaa 100644

> --- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h

> +++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h

> @@ -325,9 +325,6 @@ struct dpaa2_memseg {

>  	size_t len;

>  };

>  

> -TAILQ_HEAD(dpaa2_memseg_list, dpaa2_memseg);

> -extern struct dpaa2_memseg_list rte_dpaa2_memsegs;

> -

>  #ifdef RTE_LIBRTE_DPAA2_USE_PHYS_IOVA

>  extern uint8_t dpaa2_virt_mode;

>  static void *dpaa2_mem_ptov(phys_addr_t paddr) __rte_unused;

> diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map

> index 80da19a277..69e7dc6ad9 100644

> --- a/drivers/bus/fslmc/rte_bus_fslmc_version.map

> +++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map

> @@ -106,7 +106,6 @@ INTERNAL {

>  	rte_dpaa2_free_dpci_dev;

>  	rte_dpaa2_intr_disable;

>  	rte_dpaa2_intr_enable;

> -	rte_dpaa2_memsegs;

>  	rte_fslmc_driver_register;

>  	rte_fslmc_driver_unregister;

>  	rte_fslmc_get_device_count;

> 

Acked-by: Ray Kinsella <mdr@ashroe.eu>

Patch

diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
index 79b148f20b..d9619848d8 100644
--- a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
+++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
@@ -28,12 +28,6 @@ 
 #include "portal/dpaa2_hw_pvt.h"
 #include "portal/dpaa2_hw_dpio.h"
 
-/* List of all the memseg information locally maintained in dpaa2 driver. This
- * is to optimize the PA_to_VA searches until a better mechanism (algo) is
- * available.
- */
-struct dpaa2_memseg_list rte_dpaa2_memsegs
-	= TAILQ_HEAD_INITIALIZER(rte_dpaa2_memsegs);
 
 TAILQ_HEAD(dpbp_dev_list, dpaa2_dpbp_dev);
 static struct dpbp_dev_list dpbp_dev_list
diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
index 194b99c583..19fdd9cfaa 100644
--- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
+++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
@@ -325,9 +325,6 @@  struct dpaa2_memseg {
 	size_t len;
 };
 
-TAILQ_HEAD(dpaa2_memseg_list, dpaa2_memseg);
-extern struct dpaa2_memseg_list rte_dpaa2_memsegs;
-
 #ifdef RTE_LIBRTE_DPAA2_USE_PHYS_IOVA
 extern uint8_t dpaa2_virt_mode;
 static void *dpaa2_mem_ptov(phys_addr_t paddr) __rte_unused;
diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map
index 80da19a277..69e7dc6ad9 100644
--- a/drivers/bus/fslmc/rte_bus_fslmc_version.map
+++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map
@@ -106,7 +106,6 @@  INTERNAL {
 	rte_dpaa2_free_dpci_dev;
 	rte_dpaa2_intr_disable;
 	rte_dpaa2_intr_enable;
-	rte_dpaa2_memsegs;
 	rte_fslmc_driver_register;
 	rte_fslmc_driver_unregister;
 	rte_fslmc_get_device_count;