diff mbox series

[8/8] target/arm: Use a non-overlapping group for misc control

Message ID 20200518164052.18689-9-richard.henderson@linaro.org
State Superseded
Headers show
Series decodetree: Add non-overlapping groups | expand

Commit Message

Richard Henderson May 18, 2020, 4:40 p.m. UTC
This sub-group in the t32 deocode are mutually exclusive.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 target/arm/t32.decode | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.20.1

Comments

Philippe Mathieu-Daudé May 18, 2020, 4:56 p.m. UTC | #1
On 5/18/20 6:40 PM, Richard Henderson wrote:
> This sub-group in the t32 deocode are mutually exclusive.


"The miscellaneous control instructions are mutually exclusive within 
the t32 decode sub-group."?

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


> 

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>   target/arm/t32.decode | 4 ++--

>   1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/target/arm/t32.decode b/target/arm/t32.decode

> index c63082fc9c..c21a988f97 100644

> --- a/target/arm/t32.decode

> +++ b/target/arm/t32.decode

> @@ -312,13 +312,13 @@ CLZ              1111 1010 1011 ---- 1111 .... 1000 ....      @rdm

>                    &cps

>   

>       # Miscellaneous control

> -    {

> +    [

>         CLREX      1111 0011 1011 1111 1000 1111 0010 1111

>         DSB        1111 0011 1011 1111 1000 1111 0100 ----

>         DMB        1111 0011 1011 1111 1000 1111 0101 ----

>         ISB        1111 0011 1011 1111 1000 1111 0110 ----

>         SB         1111 0011 1011 1111 1000 1111 0111 0000

> -    }

> +    ]

>   

>       # Note that the v7m insn overlaps both the normal and banked insn.

>       {

>
diff mbox series

Patch

diff --git a/target/arm/t32.decode b/target/arm/t32.decode
index c63082fc9c..c21a988f97 100644
--- a/target/arm/t32.decode
+++ b/target/arm/t32.decode
@@ -312,13 +312,13 @@  CLZ              1111 1010 1011 ---- 1111 .... 1000 ....      @rdm
                  &cps
 
     # Miscellaneous control
-    {
+    [
       CLREX      1111 0011 1011 1111 1000 1111 0010 1111
       DSB        1111 0011 1011 1111 1000 1111 0100 ----
       DMB        1111 0011 1011 1111 1000 1111 0101 ----
       ISB        1111 0011 1011 1111 1000 1111 0110 ----
       SB         1111 0011 1011 1111 1000 1111 0111 0000
-    }
+    ]
 
     # Note that the v7m insn overlaps both the normal and banked insn.
     {