| Message ID | 20200520140541.30256-8-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | testing and plugin updates | expand |
On 5/20/20 7:05 AM, Alex Bennée wrote: > While we may gamely give the right information it can still confuse > the wide range of GDBs out there. For example ppc64abi32-linux-user > reports: > > warning: Selected architecture powerpc:common is not compatible with reported target architecture powerpc:common64 > warning: Architecture rejected target-supplied description > > but still connects. Add a test for a 0 pc and exit early if that is > the case. This may actually be a bug we need to fix? > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Cc: Richard Henderson <rth@twiddle.net> > --- > tests/tcg/multiarch/gdbstub/sha1.py | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/tests/tcg/multiarch/gdbstub/sha1.py b/tests/tcg/multiarch/gdbstub/sha1.py index 734553b98bb..2bfde49633c 100644 --- a/tests/tcg/multiarch/gdbstub/sha1.py +++ b/tests/tcg/multiarch/gdbstub/sha1.py @@ -65,6 +65,10 @@ except (gdb.error, AttributeError): print("SKIPPING (not connected)", file=sys.stderr) exit(0) +if gdb.parse_and_eval('$pc') == 0: + print("SKIP: PC not set") + exit(0) + try: # These are not very useful in scripts gdb.execute("set pagination off")
While we may gamely give the right information it can still confuse the wide range of GDBs out there. For example ppc64abi32-linux-user reports: warning: Selected architecture powerpc:common is not compatible with reported target architecture powerpc:common64 warning: Architecture rejected target-supplied description but still connects. Add a test for a 0 pc and exit early if that is the case. This may actually be a bug we need to fix? Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Cc: Richard Henderson <rth@twiddle.net> --- tests/tcg/multiarch/gdbstub/sha1.py | 4 ++++ 1 file changed, 4 insertions(+) -- 2.20.1