[1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines

Message ID 20200520133932.30441-2-erwan.leray@st.com
State New
Headers show
Series
  • add generic DT binding for RTS/CTS
Related show

Commit Message

Erwan Le Ray May 20, 2020, 1:39 p.m.
Add support of generic DT binding for annoucing RTS/CTS lines. The initial
binding 'st,hw-flow-control' is not needed anymore since generic binding
is available, but is kept for backward compatibility.

Signed-off-by: Erwan Le Ray <erwan.leray@st.com>


-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Comments

Greg KH June 27, 2020, 2:18 p.m. | #1
On Wed, May 20, 2020 at 03:39:31PM +0200, Erwan Le Ray wrote:
> Add support of generic DT binding for annoucing RTS/CTS lines. The initial

> binding 'st,hw-flow-control' is not needed anymore since generic binding

> is available, but is kept for backward compatibility.

> 

> Signed-off-by: Erwan Le Ray <erwan.leray@st.com>

> 

> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml

> index 75b8521eb7cb..06d5f251ec88 100644

> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml

> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml

> @@ -35,9 +35,11 @@ properties:

>      description: label associated with this uart

>  

>    st,hw-flow-ctrl:

> -    description: enable hardware flow control

> +    description: enable hardware flow control (deprecated)

>      $ref: /schemas/types.yaml#/definitions/flag

>  

> +  uart-has-rtscts: true

> +

>    dmas:

>      minItems: 1

>      maxItems: 2

> -- 

> 2.17.1

> 


Did this get ignored by the DT maintainers?  :(
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Rob Herring June 30, 2020, 6:35 p.m. | #2
On Sat, Jun 27, 2020 at 8:18 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>

> On Wed, May 20, 2020 at 03:39:31PM +0200, Erwan Le Ray wrote:

> > Add support of generic DT binding for annoucing RTS/CTS lines. The initial

> > binding 'st,hw-flow-control' is not needed anymore since generic binding

> > is available, but is kept for backward compatibility.

> >

> > Signed-off-by: Erwan Le Ray <erwan.leray@st.com>

> >

> > diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml

> > index 75b8521eb7cb..06d5f251ec88 100644

> > --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml

> > +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml

> > @@ -35,9 +35,11 @@ properties:

> >      description: label associated with this uart

> >

> >    st,hw-flow-ctrl:

> > -    description: enable hardware flow control

> > +    description: enable hardware flow control (deprecated)

> >      $ref: /schemas/types.yaml#/definitions/flag

> >

> > +  uart-has-rtscts: true

> > +

> >    dmas:

> >      minItems: 1

> >      maxItems: 2

> > --

> > 2.17.1

> >

>

> Did this get ignored by the DT maintainers?  :(


When it doesn't go to the DT list, you are playing roulette whether I
happen to see it. :(

Anyways,

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
index 75b8521eb7cb..06d5f251ec88 100644
--- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
@@ -35,9 +35,11 @@  properties:
     description: label associated with this uart
 
   st,hw-flow-ctrl:
-    description: enable hardware flow control
+    description: enable hardware flow control (deprecated)
     $ref: /schemas/types.yaml#/definitions/flag
 
+  uart-has-rtscts: true
+
   dmas:
     minItems: 1
     maxItems: 2