diff mbox series

[v1,11/12] util: Added tsan annotate for thread name.

Message ID 20200529132341.755-11-robert.foley@linaro.org
State Superseded
Headers show
Series Add Thread Sanitizer support to QEMU | expand

Commit Message

Robert Foley May 29, 2020, 1:23 p.m. UTC 
This allows us to see the name of the thread in tsan
warning reports such as this:

  Thread T7 'CPU 1/TCG' (tid=24317, running) created by main thread at:

Signed-off-by: Robert Foley <robert.foley@linaro.org>

---
 util/qemu-thread-posix.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.17.1

Comments

Emilio Cota June 1, 2020, 3:56 a.m. UTC | #1 
On Fri, May 29, 2020 at 09:23:41 -0400, Robert Foley wrote:
> This allows us to see the name of the thread in tsan

> warning reports such as this:

> 

>   Thread T7 'CPU 1/TCG' (tid=24317, running) created by main thread at:

> 

> Signed-off-by: Robert Foley <robert.foley@linaro.org>


Reviewed-by: Emilio G. Cota <cota@braap.org>


Thanks,

		Emilio
diff mbox series

Patch

diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c
index 838980aaa5..b4c2359272 100644
--- a/util/qemu-thread-posix.c
+++ b/util/qemu-thread-posix.c
@@ -15,6 +15,7 @@ 
 #include "qemu/atomic.h"
 #include "qemu/notify.h"
 #include "qemu-thread-common.h"
+#include "qemu/tsan.h"
 
 static bool name_threads;
 
@@ -513,6 +514,7 @@  static void *qemu_thread_start(void *args)
 # endif
     }
 #endif
+    QEMU_TSAN_ANNOTATE_THREAD_NAME(qemu_thread_args->name);
     g_free(qemu_thread_args->name);
     g_free(qemu_thread_args);
     pthread_cleanup_push(qemu_thread_atexit_notify, NULL);