[01/10] cpufreq: Cleanup header files included in core

Message ID CAKohponCtLRi1UJCN0z2hRVH=o326mtS2nUEvoi8Rf5H==vATw@mail.gmail.com
State New
Headers show

Commit Message

Viresh Kumar Aug. 3, 2013, 5:15 p.m.
On 3 August 2013 17:19, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> This patch intends to cleanup following issues in the header files included in
> cpufreq core layers:
> - Include headers in ascending order, so that we don't add same multiple times
>   by mistake.
> - <asm/> must be included after <linux/>, so that they override whatever they
>   need.
> - Remove unnecessary header files
> - Don't include files already included by cpufreq.h or cpufreq_governor.h
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Fixup due to compilation warning reported by Fengguang's kbuild system:
[Latest stuff pushed in my cpufreq-next branch]

Comments

Rafael J. Wysocki Aug. 3, 2013, 9:42 p.m. | #1
On Saturday, August 03, 2013 10:45:04 PM Viresh Kumar wrote:
> On 3 August 2013 17:19, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > This patch intends to cleanup following issues in the header files included in
> > cpufreq core layers:
> > - Include headers in ascending order, so that we don't add same multiple times
> >   by mistake.
> > - <asm/> must be included after <linux/>, so that they override whatever they
> >   need.
> > - Remove unnecessary header files
> > - Don't include files already included by cpufreq.h or cpufreq_governor.h
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> Fixup due to compilation warning reported by Fengguang's kbuild system:
> [Latest stuff pushed in my cpufreq-next branch]
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 70399ea..ccaf025 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -19,6 +19,7 @@
> 
>  #include <linux/cpu.h>
>  #include <linux/cpufreq.h>
> +#include <linux/delay.h>
>  #include <linux/device.h>
>  #include <linux/init.h>
>  #include <linux/kernel_stat.h>

Can you please repost the complete patch with this folded in?

Rafael

Patch

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 70399ea..ccaf025 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -19,6 +19,7 @@ 

 #include <linux/cpu.h>
 #include <linux/cpufreq.h>
+#include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/init.h>
 #include <linux/kernel_stat.h>