remoteproc: qcom: q6v5-mss: Fix kfree build error

Message ID 20200617065658.27567-1-naresh.kamboju@linaro.org
State New
Headers show
Series
  • remoteproc: qcom: q6v5-mss: Fix kfree build error
Related show

Commit Message

Naresh Kamboju June 17, 2020, 6:56 a.m.
This patch adds linux/slab.h to fix build error in qcom_q6v5_mss.c

Build error:
 ../drivers/remoteproc/qcom_q6v5_mss.c:
  In function ‘q6v5_mpss_init_image’:
 ../drivers/remoteproc/qcom_q6v5_mss.c:772:3:
  error: implicit declaration of function ‘kfree’;
  did you mean ‘vfree’? [-Werror=implicit-function-declaration]
   772 |   kfree(metadata);
       |   ^~~~~
       |   vfree

Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>

---
 drivers/remoteproc/qcom_q6v5_mss.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.1

Comments

Naresh Kamboju June 17, 2020, 1:49 p.m. | #1
+ linux-remoteproc@vger.kernel.org

On Wed, 17 Jun 2020 at 12:27, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>

> This patch adds linux/slab.h to fix build error in qcom_q6v5_mss.c

>

> Build error:

>  ../drivers/remoteproc/qcom_q6v5_mss.c:

>   In function ‘q6v5_mpss_init_image’:

>  ../drivers/remoteproc/qcom_q6v5_mss.c:772:3:

>   error: implicit declaration of function ‘kfree’;

>   did you mean ‘vfree’? [-Werror=implicit-function-declaration]

>    772 |   kfree(metadata);

>        |   ^~~~~

>        |   vfree

>

> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>

> ---

>  drivers/remoteproc/qcom_q6v5_mss.c | 1 +

>  1 file changed, 1 insertion(+)

>

> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c

> index feb70283b6a2..903b2bb97e12 100644

> --- a/drivers/remoteproc/qcom_q6v5_mss.c

> +++ b/drivers/remoteproc/qcom_q6v5_mss.c

> @@ -26,6 +26,7 @@

>  #include <linux/reset.h>

>  #include <linux/soc/qcom/mdt_loader.h>

>  #include <linux/iopoll.h>

> +#include <linux/slab.h>

>

>  #include "remoteproc_internal.h"

>  #include "qcom_common.h"

> --

> 2.17.1

>
Bjorn Andersson June 21, 2020, 7:40 a.m. | #2
On Tue 16 Jun 23:56 PDT 2020, Naresh Kamboju wrote:

> This patch adds linux/slab.h to fix build error in qcom_q6v5_mss.c

> 

> Build error:

>  ../drivers/remoteproc/qcom_q6v5_mss.c:

>   In function ‘q6v5_mpss_init_image’:

>  ../drivers/remoteproc/qcom_q6v5_mss.c:772:3:

>   error: implicit declaration of function ‘kfree’;

>   did you mean ‘vfree’? [-Werror=implicit-function-declaration]

>    772 |   kfree(metadata);

>        |   ^~~~~

>        |   vfree

> 

> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>


Thanks for the patch Naresh, it looks correct but I've not seen this
build error myself. Could you please let me know what you built to get
this and if you have any suggestion on what caused it? (So we can add a
Fixes: tag etc)

Regards,
Bjorn

> ---

>  drivers/remoteproc/qcom_q6v5_mss.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c

> index feb70283b6a2..903b2bb97e12 100644

> --- a/drivers/remoteproc/qcom_q6v5_mss.c

> +++ b/drivers/remoteproc/qcom_q6v5_mss.c

> @@ -26,6 +26,7 @@

>  #include <linux/reset.h>

>  #include <linux/soc/qcom/mdt_loader.h>

>  #include <linux/iopoll.h>

> +#include <linux/slab.h>

>  

>  #include "remoteproc_internal.h"

>  #include "qcom_common.h"

> -- 

> 2.17.1

>
Naresh Kamboju June 22, 2020, 6:18 a.m. | #3
On Sun, 21 Jun 2020 at 13:12, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>

> On Tue 16 Jun 23:56 PDT 2020, Naresh Kamboju wrote:

>

> > This patch adds linux/slab.h to fix build error in qcom_q6v5_mss.c

> >

> > Build error:

> >  ../drivers/remoteproc/qcom_q6v5_mss.c:

> >   In function ‘q6v5_mpss_init_image’:

> >  ../drivers/remoteproc/qcom_q6v5_mss.c:772:3:

> >   error: implicit declaration of function ‘kfree’;

> >   did you mean ‘vfree’? [-Werror=implicit-function-declaration]

> >    772 |   kfree(metadata);

> >        |   ^~~~~

> >        |   vfree

> >

> > Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>

>

> Thanks for the patch Naresh, it looks correct but I've not seen this

> build error myself. Could you please let me know what you built to get

> this and if you have any suggestion on what caused it? (So we can add a

> Fixes: tag etc)


Thanks for the review.
This was an arm64 modules build failure on linux -next 20200616 tag.
This fix has already been taken care of by
Herbert Xu <herbert@gondor.apana.org.au> and got merged.
Fixes: f0187db056dc ("iov_iter: Move unnecessary inclusion of...")

ref:
https://lore.kernel.org/lkml/20200616010502.GA28834@gondor.apana.org.au/

- Naresh

Patch

diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
index feb70283b6a2..903b2bb97e12 100644
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -26,6 +26,7 @@ 
 #include <linux/reset.h>
 #include <linux/soc/qcom/mdt_loader.h>
 #include <linux/iopoll.h>
+#include <linux/slab.h>
 
 #include "remoteproc_internal.h"
 #include "qcom_common.h"