| Message ID | 20200521120621.2658-1-dinghao.liu@zju.edu.cn |
|---|---|
| State | Accepted |
| Commit | 606578801afe6ec8bb03f5d494a4bae49a684ef3 |
| Headers | show |
| Series | media: camss: ispif: Fix runtime PM imbalance on error | expand |
diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c index 1f33b4eb198c..5722e971b184 100644 --- a/drivers/media/platform/qcom/camss/camss-ispif.c +++ b/drivers/media/platform/qcom/camss/camss-ispif.c @@ -344,8 +344,10 @@ static int ispif_set_power(struct v4l2_subdev *sd, int on) } ret = pm_runtime_get_sync(dev); - if (ret < 0) + if (ret < 0) { + pm_runtime_put_sync(dev); goto exit; + } ret = camss_enable_clocks(ispif->nclocks, ispif->clock, dev); if (ret < 0) {
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/media/platform/qcom/camss/camss-ispif.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)