ACPICA:enable 64bit build for aarch64 architecture

Message ID 1376466309-14710-1-git-send-email-naresh.bhat@linaro.org
State New
Headers show

Commit Message

naresh.bhat@linaro.org Aug. 14, 2013, 7:45 a.m.
From: Naresh Bhat <naresh.bhat@linaro.org>

Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>

Enable 64 bit build for aarch64 architecture in ACPICA Linux
platform specific defines.
---
 source/include/platform/aclinux.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Moore, Robert Aug. 14, 2013, 4:17 p.m. | #1
OK, we'll add this for the next acpica release.
Thanks,
Bob

> -#if defined(__ia64__) || defined(__x86_64__)
> +#if defined(__ia64__) || defined(__x86_64__) || (__aarch64__)


Shouldn't this be:

> -#if defined(__ia64__) || defined(__x86_64__)
> +#if defined(__ia64__) || defined(__x86_64__) || defined(__aarch64__)


> -----Original Message-----
> From: naresh.bhat@linaro.org [mailto:naresh.bhat@linaro.org]
> Sent: Wednesday, August 14, 2013 12:45 AM
> To: devel@acpica.org
> Cc: Moore, Robert; patches@linaro.org; linaro-acpi@lists.linaro.org;
> Naresh Bhat
> Subject: [PATCH] ACPICA:enable 64bit build for aarch64 architecture
> 
> From: Naresh Bhat <naresh.bhat@linaro.org>
> 
> Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>
> 
> Enable 64 bit build for aarch64 architecture in ACPICA Linux platform
> specific defines.
> ---
>  source/include/platform/aclinux.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source/include/platform/aclinux.h
> b/source/include/platform/aclinux.h
> index e561292..6b8b1ab 100644
> --- a/source/include/platform/aclinux.h
> +++ b/source/include/platform/aclinux.h
> @@ -159,7 +159,7 @@
>  #define ACPI_FLUSH_CPU_CACHE()
>  #define ACPI_CAST_PTHREAD_T(pthread) ((ACPI_THREAD_ID) (pthread))
> 
> -#if defined(__ia64__) || defined(__x86_64__)
> +#if defined(__ia64__) || defined(__x86_64__) || (__aarch64__)
>  #define ACPI_MACHINE_WIDTH          64
>  #define COMPILER_DEPENDENT_INT64    long
>  #define COMPILER_DEPENDENT_UINT64   unsigned long
> --
> 1.7.9.5
naresh.bhat@linaro.org Aug. 14, 2013, 4:40 p.m. | #2
Hi Robert,

Ah my bad typo's..:( , you are right it is "defined(__aarch64__)" I
don't know some how I have missed the defined (looks like I was in
hurry).

Thanks for identifying and correcting it.

Regards
-Naresh Bhat

On 14 August 2013 21:47, Moore, Robert <robert.moore@intel.com> wrote:
> OK, we'll add this for the next acpica release.
> Thanks,
> Bob
>
>> -#if defined(__ia64__) || defined(__x86_64__)
>> +#if defined(__ia64__) || defined(__x86_64__) || (__aarch64__)
>
>
> Shouldn't this be:
>
>> -#if defined(__ia64__) || defined(__x86_64__)
>> +#if defined(__ia64__) || defined(__x86_64__) || defined(__aarch64__)
>
>
>> -----Original Message-----
>> From: naresh.bhat@linaro.org [mailto:naresh.bhat@linaro.org]
>> Sent: Wednesday, August 14, 2013 12:45 AM
>> To: devel@acpica.org
>> Cc: Moore, Robert; patches@linaro.org; linaro-acpi@lists.linaro.org;
>> Naresh Bhat
>> Subject: [PATCH] ACPICA:enable 64bit build for aarch64 architecture
>>
>> From: Naresh Bhat <naresh.bhat@linaro.org>
>>
>> Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>
>>
>> Enable 64 bit build for aarch64 architecture in ACPICA Linux platform
>> specific defines.
>> ---
>>  source/include/platform/aclinux.h |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/source/include/platform/aclinux.h
>> b/source/include/platform/aclinux.h
>> index e561292..6b8b1ab 100644
>> --- a/source/include/platform/aclinux.h
>> +++ b/source/include/platform/aclinux.h
>> @@ -159,7 +159,7 @@
>>  #define ACPI_FLUSH_CPU_CACHE()
>>  #define ACPI_CAST_PTHREAD_T(pthread) ((ACPI_THREAD_ID) (pthread))
>>
>> -#if defined(__ia64__) || defined(__x86_64__)
>> +#if defined(__ia64__) || defined(__x86_64__) || (__aarch64__)
>>  #define ACPI_MACHINE_WIDTH          64
>>  #define COMPILER_DEPENDENT_INT64    long
>>  #define COMPILER_DEPENDENT_UINT64   unsigned long
>> --
>> 1.7.9.5
>
Moore, Robert Aug. 14, 2013, 5:34 p.m. | #3
OK, done.


> -----Original Message-----
> From: Naresh Bhat [mailto:naresh.bhat@linaro.org]
> Sent: Wednesday, August 14, 2013 9:40 AM
> To: Moore, Robert
> Cc: devel@acpica.org; patches@linaro.org; linaro-acpi@lists.linaro.org
> Subject: Re: [PATCH] ACPICA:enable 64bit build for aarch64 architecture
> 
> Hi Robert,
> 
> Ah my bad typo's..:( , you are right it is "defined(__aarch64__)" I don't
> know some how I have missed the defined (looks like I was in hurry).
> 
> Thanks for identifying and correcting it.
> 
> Regards
> -Naresh Bhat
> 
> On 14 August 2013 21:47, Moore, Robert <robert.moore@intel.com> wrote:
> > OK, we'll add this for the next acpica release.
> > Thanks,
> > Bob
> >
> >> -#if defined(__ia64__) || defined(__x86_64__)
> >> +#if defined(__ia64__) || defined(__x86_64__) || (__aarch64__)
> >
> >
> > Shouldn't this be:
> >
> >> -#if defined(__ia64__) || defined(__x86_64__)
> >> +#if defined(__ia64__) || defined(__x86_64__) || defined(__aarch64__)
> >
> >
> >> -----Original Message-----
> >> From: naresh.bhat@linaro.org [mailto:naresh.bhat@linaro.org]
> >> Sent: Wednesday, August 14, 2013 12:45 AM
> >> To: devel@acpica.org
> >> Cc: Moore, Robert; patches@linaro.org; linaro-acpi@lists.linaro.org;
> >> Naresh Bhat
> >> Subject: [PATCH] ACPICA:enable 64bit build for aarch64 architecture
> >>
> >> From: Naresh Bhat <naresh.bhat@linaro.org>
> >>
> >> Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>
> >>
> >> Enable 64 bit build for aarch64 architecture in ACPICA Linux platform
> >> specific defines.
> >> ---
> >>  source/include/platform/aclinux.h |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/source/include/platform/aclinux.h
> >> b/source/include/platform/aclinux.h
> >> index e561292..6b8b1ab 100644
> >> --- a/source/include/platform/aclinux.h
> >> +++ b/source/include/platform/aclinux.h
> >> @@ -159,7 +159,7 @@
> >>  #define ACPI_FLUSH_CPU_CACHE()
> >>  #define ACPI_CAST_PTHREAD_T(pthread) ((ACPI_THREAD_ID) (pthread))
> >>
> >> -#if defined(__ia64__) || defined(__x86_64__)
> >> +#if defined(__ia64__) || defined(__x86_64__) || (__aarch64__)
> >>  #define ACPI_MACHINE_WIDTH          64
> >>  #define COMPILER_DEPENDENT_INT64    long
> >>  #define COMPILER_DEPENDENT_UINT64   unsigned long
> >> --
> >> 1.7.9.5
> >

Patch

diff --git a/source/include/platform/aclinux.h b/source/include/platform/aclinux.h
index e561292..6b8b1ab 100644
--- a/source/include/platform/aclinux.h
+++ b/source/include/platform/aclinux.h
@@ -159,7 +159,7 @@ 
 #define ACPI_FLUSH_CPU_CACHE()
 #define ACPI_CAST_PTHREAD_T(pthread) ((ACPI_THREAD_ID) (pthread))
 
-#if defined(__ia64__) || defined(__x86_64__)
+#if defined(__ia64__) || defined(__x86_64__) || (__aarch64__)
 #define ACPI_MACHINE_WIDTH          64
 #define COMPILER_DEPENDENT_INT64    long
 #define COMPILER_DEPENDENT_UINT64   unsigned long